[HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.13-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #45456

Action Performed:

1. Go to staging.new.expensify.com
2. Log out if logged in.
3. Do not enter email or phone number in login field.
4. Navigate to an expired or invalid magic link (https://staging.new.expensify.com/v/17947659/471551
   )
5. Click "just sign in here"
6. Click "request one here"

Expected Result:

Since the login field is empty, the error message should be "Please enter an email or phone number"

Actual Result:

The error message is "The given email is not valid." when the login field is empty

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6553650_1721995908851.20240726_200630.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c8fc425d7d2acad3
• Upwork Job ID: 1816860521532505990
• Last Price Increase: 2024-07-26
• Automatic offers:
• DylanDylann | Reviewer | 103281132
• ShridharGoel | Contributor | 103281135

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Login - Incorrect error message "The given email is not valid." when login field is empty.

What is the root cause of that problem?

The login credentials are not available, which leads to sign in happening with a blank email.

App/src/components/ValidateCode/ExpiredValidateCodeModal.tsx

Lines 38 to 41 in c0f7868

	onPress={() => {
	Session.beginSignIn(credentials?.login ?? '');
	Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);
	}}

What changes do you think we should make in order to solve the problem?

If login data like email is not available, the the request one here option shouldn't be shown.

{
    credentials?.login ? (
        <Text style={styles.textAlignCenter}>
            {translate('validateCodeModal.expiredCodeDescription')}
            {translate('validateCodeModal.or')}{' '}
            <TextLink
                onPress={() => {
                    Session.beginSignIn(credentials?.login ?? '');
                    Navigation.setNavigationActionToMicrotaskQueue(Navigation.goBack);
                }}
            >
                {translate('validateCodeModal.requestOneHere')}
            </TextLink>
        </Text>
    ) : (
        <Text style={styles.textAlignCenter}>
            {translate('validateCodeModal.expiredCodeDescription')}
        </Text>
    )
}

[ShridharGoel]

@marcochavezf Since this is a deploy blocker, I can open the PR quickly.

[marcochavezf]

Sounds good, let's do it @ShridharGoel

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c8fc425d7d2acad3