Update the magic code expired page by nkdengineer · Pull Request #45456 · Expensify/App

nkdengineer · 2024-07-16T08:32:31Z

Details

Fixed Issues

$ #45242
PROPOSAL: #45242 (comment)

Tests

Login with email
Copy the link from 'click this magic link' in your mail
Wait for the link to expire
Verify that: request one here is displayed on expired page

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login with email
Copy the link from 'click this magic link' in your mail
Wait for the link to expire
Verify that: request one here is displayed on expired page

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-07-16T09:05:58Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2024-07-16T09:53:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

NA

Android: mWeb Chrome

NA

iOS: Native

NA

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

2024-07-16.12.15.53.mov

MacOS: Desktop

NA

ZhenjaHorbach · 2024-07-16T10:20:20Z

It's minor issue
But when we press request one here. we can see incorrect magic code for a short period of time

I also noticed that after pressing request one here. the timer does not start at 30 seconds
But from a lower value

ZhenjaHorbach · 2024-07-17T09:22:45Z

It's minor issue But when we press request one here. we can see incorrect magic code for a short period of time
I also noticed that after pressing `request one here.` the timer does not start at 30 seconds But from a lower value

@nkdengineer
Can you take a look when you're free, please ?

nkdengineer · 2024-07-18T02:27:24Z

I'll update soon

ZhenjaHorbach · 2024-07-23T13:45:31Z

@nkdengineer
What is the status of this PR?

nkdengineer · 2024-07-23T13:54:21Z

Will give an update tomorrow.

nkdengineer · 2024-07-23T16:19:04Z

@ZhenjaHorbach please check again

ZhenjaHorbach · 2024-07-23T17:09:14Z

@nkdengineer
Thanks for the quick fix !

But I can still see incorrect magic code for a short period of time (You can add requestAnimationFrame for this to fix this issue)

Plus let's create constant for 30 seconds

nkdengineer · 2024-07-24T03:26:06Z

@ZhenjaHorbach thanks your suggestion
please check again

ZhenjaHorbach · 2024-07-24T07:00:42Z

src/components/ValidateCode/ExpiredValidateCodeModal.tsx

+                            onPress={() => {
+                                requestAnimationFrame(() => {
+                                    Session.beginSignIn(credentials?.login ?? '');
+                                });


Oh, my fault
Sorry for misleading you 😅
I think we'd better wrap Navigation.goBack instead Session.beginSignIn with an requestAnimationFrame ( Plus we have Navigation.setNavigationActionToMicrotaskQueue which we can use as an alternative to requestAnimationFrame )

@ZhenjaHorbach please check again

It's good now
Thanks for the fix !

ZhenjaHorbach · 2024-07-25T06:52:31Z

Everything works well !
LGTM

techievivek

Thanks for the improvement. 🚀

OSBotify · 2024-07-26T04:32:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-26T05:36:41Z

🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.13-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-29T18:39:35Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.13-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	failure ❌

Update the magic code expired page

e009acb

nkdengineer marked this pull request as ready for review July 16, 2024 09:05

nkdengineer requested a review from a team as a code owner July 16, 2024 09:05

melvin-bot bot requested review from ZhenjaHorbach and removed request for a team July 16, 2024 09:05

nkdengineer added 2 commits July 23, 2024 22:48

Merge branch 'main' into fix/45242

54c12e6

set time remaining

71e5c08

add new const

766a898

ZhenjaHorbach reviewed Jul 24, 2024

View reviewed changes

fix: remove useless code

b543401

ZhenjaHorbach approved these changes Jul 25, 2024

View reviewed changes

melvin-bot bot requested a review from techievivek July 25, 2024 06:51

techievivek assigned nkdengineer Jul 26, 2024

techievivek approved these changes Jul 26, 2024

View reviewed changes

techievivek merged commit 2b36366 into Expensify:main Jul 26, 2024

github-actions bot mentioned this pull request Jul 26, 2024

Deploy Checklist: New Expensify 2024-07-26 #46264

Closed

48 tasks

lanitochka17 mentioned this pull request Jul 26, 2024

[HOLD for payment 2024-08-07] [HOLD for payment 2024-08-05] [$250] Login - Incorrect error message "The given email is not valid." when login field is empty #46307

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 29, 2024

[HOLD for payment 2024-08-05] Update the magic code expired page to include a link to take user to login page #45242

Closed

Conversation

nkdengineer commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 16, 2024

Uh oh!

ZhenjaHorbach commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Jul 18, 2024

Uh oh!

ZhenjaHorbach commented Jul 23, 2024

Uh oh!

nkdengineer commented Jul 23, 2024

Uh oh!

nkdengineer commented Jul 23, 2024

Uh oh!

ZhenjaHorbach commented Jul 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nkdengineer commented Jul 24, 2024

Uh oh!

ZhenjaHorbach Jul 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nkdengineer Jul 25, 2024

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach Jul 25, 2024

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jul 25, 2024

Uh oh!

techievivek left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 26, 2024

Uh oh!

OSBotify commented Jul 26, 2024

Uh oh!

OSBotify commented Jul 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nkdengineer commented Jul 16, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 16, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 16, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 17, 2024 •

edited

Loading

ZhenjaHorbach commented Jul 23, 2024 •

edited

Loading

ZhenjaHorbach Jul 24, 2024 •

edited

Loading