[Due for payment 2025-02-25] [$250] Prevent self approval remains enabled with only one member

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.96-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #55740
Email or phone of affected tester (no customers): gibethlehem@gmail.com
Issue reported by: Applause Internal Team
Device used: macOS/chrome
App Component: Workspace Settings

Action Performed:

Prerequisites:

• Control workspace with two members( admin and employee)
• Workflow and Rules are enabled

Steps

1. Go to https://staging.new.expensify.com/ > Sign in
2. Go to Settings > Workspaces > Workflows > Enable approvals
3. Go to Rules section, toggle Prevent Self Approvals. (Self approvals can be enabled because there are at least two members.)
4. Go to members > Remove the employee by clicking the employee and remove it from the opened RHN
5. Go to Rules section. Notice Prevent Self Approvals is still enabled

Expected Result:

Prevent Self Approval is disabled when there is only one member. Self approvals can't be enabled until this workspace has at least two members.

Actual Result:

Prevent Self Approval remains Enabled with only the owner as a member.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6739183_1739250164964.Screen_Recording_2025-02-11_at_6.22.09_in_the_morning.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021889681298278222810
• Upwork Job ID: 1889681298278222810
• Last Price Increase: 2025-02-12
• Automatic offers:
• mkzie2 | Contributor | 106109805

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Prevent self approval remains enabled with only one member

What is the root cause of that problem?

The logic to disable the "Prevent self-approvals" toggle based on the member count is only executed at the time the toggle is changed.

App/src/pages/workspace/rules/ExpenseReportRulesSection.tsx

Lines 49 to 60 in 48520ec

	function handleTogglePreventSelfApprovals(isEnabled: boolean) {
	if (!isEnabled) {
	setPolicyPreventSelfApproval(policyID, false);
	return;
	}
	if (selfApproversEmails.length === 0) {
	setPolicyPreventSelfApproval(policyID, true);
	} else {
	setIsPreventSelfApprovalsModalVisible(true);
	}
	}

What changes do you think we should make in order to solve the problem?

We can use useEffect hook that monitors the workspace member count. Whenever the member count drops below 2 and preventSelfApproval is enabled, the effect should automatically disable it by calling setPolicyPreventSelfApproval(policyID, false).

    useEffect(() => {
        if (defaultWorkflowMembers && defaultWorkflowMembers.length < 2 && policy?.preventSelfApproval) {
            setPolicyPreventSelfApproval(policyID, false);
        }
    }, [defaultWorkflowMembers, policy?.preventSelfApproval, policyID]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[mkzie2]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-11 15:24:06 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Prevent Self Approval remains Enabled with only the owner as a member.

What is the root cause of that problem?

We don't have any logic to disable preventSelfApproval after removing the members in the member detail page like we do in WorkspaceMembersPage.

App/src/pages/workspace/WorkspaceMembersPage.tsx

Line 236 in 5b05237

if (newEmployeesCount === 1 && policy?.preventSelfApproval) {

What changes do you think we should make in order to solve the problem?

We need to apply the same logic in WorkspaceMembersPage here

const previousEmployeesCount = Object.keys(policy?.employeeList ?? {}).length;
if (previousEmployeesCount - 1 === 1 && policy?.preventSelfApproval) {
    // We can't let the "Prevent Self Approvals" enabled if there's only one workspace user
    setPolicyPreventSelfApproval(route.params.policyID, false);
}

App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

Line 148 in 5b05237

const removeUser = useCallback(() => {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Create a test for removeMembers and assert that preventSelfApproval is updated to false if we only have one member

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lakchote]

Handling this one as I have worked on the feature.

[lakchote]

@IuliiaHerets I'm unable to reproduce.

See the video test below, on staging:

Screen.Recording.2025-02-11.at.11.29.59.mov

[mkzie2]

@lakchote I still can able to reproduce this one on staging and on the latest main.

Screen.Recording.2025-02-11.at.18.04.00.mov

[lakchote]

I've retested and I'm still not able to reproduce either on staging or main @mkzie2.

What is the result of the API call SetPolicyPreventSelfApproval when you are removing the member?

[mkzie2]

@lakchote To reproduce this one, you should remove the member in the member detail page like I did here #56644 (comment).

It's a frontend issue because we don't have logic to call SetPolicyPreventSelfApproval API in member detail page like we do in the member page. I updated proposal.