[Due for payment 2025-04-14] Move `attendees` from `Transaction` type to `Comment`

[francoisl]

Problem

In #48008, an attendees prop was added to the Transaction type.

App/src/types/onyx/Transaction.ts

Lines 385 to 386 in aea476b

	/** Selected attendees */
	attendees?: Attendee[];

However, this is inconsistent with our backend, where attendees are stored inside the comment instead:

• Example transaction with attendees set on Expensify Classic
  

• Example if you set attendees from NewDot at the moment
  

Solution

1. Move attendees from Transaction to Comment (i.e. this), and update everywhere we read/set transaction.attendees to transaction?.comment?.attendees
2. Test creating an expense with attendees in Expensify Classic (OldDot), make sure attendees are displayed properly when opening the expense in NewDot

Notes for testing

• To be able to see the attendees in NewDot, uncomment the commented code in shouldShowAttendees() (i.e. this)-
• The backend changes to set and update attendees via New Expensify aren't complete yet, so create transactions with attendees from OldDot like so:

1. Create a workspace in New Expensify
2. Sign in to the same account on Classic (www.expensify.com or staging.expensify.com)
3. Go to Expenses > New Expense > Manually Create
4. Enter any merchant name, amount, date, and values in the Attendees selector
5. Save the expense
6. In NewDot, find and open the corresponding expense
7. Make sure the attendees are displayed correctly

---

This is part of #44725

Issue Owner

Current Issue Owner: @sakluger

[francoisl]

@allroundexperts this will be the first piece we need for https://expensify.slack.com/archives/C02NK2DQWUX/p1741128361803779?thread_ts=1741053521.226809&cid=C02NK2DQWUX, let me know if you have any questions!

[allroundexperts]

Seems clear enough to me. Will try to raise a PR tomorrow!

[melvin-bot]

📣 @sibtain-ali-deel! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[allroundexperts]

Okay. I delved into this today. Having attendees directly on transaction seems like a better option to me. Consider this piece of code. If we move attendees to comment, it'd be difficult to have it as pending.

[francoisl]

Is that the only case that's hard to migrate?

As an example, we already have waypoints inside the Comment type, and modifiedWaypoints in Transaction. Can we mimic the same thing here for attendees?

[francoisl]

@allroundexperts does that make sense?