Attendee Tracking: Created AttendeeSelectionPage

[zfurtak]

Details

Fixed Issues

$ #47171
$ #47172
PROPOSAL:

Tests

1. Click + -> Submit expense
2. Choose workspace, amount
3. On expense summary screen, expand options
4. Attendees menu item should be seen with displayName of the current user(who are creating the expanse)
5. Click on the attendees
6. Attendees selection page should appear with this user user selected
7. Also on the screen should be seen sections Recents and Contacts without workspaces in them
8. You should be able to choose someone, then they should appear in the top section
9. Click Save -> Attendees button should have now users who were chosen

• Verify that no errors appear in the JS console

Offline tests

QA Steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[blazejkustra]

Make sure it doesn't break filtering logic for participants screen and others (by looking at the usage)

[ZhenjaHorbach]

I am not sure is it a bug or not
Since we need to wait recentAttendees
But I set includeRecentReports: true for testing

And when I open screen Recents list is empty, but when I unselect submitter of the Request
I have full Recents list

2024-09-04.10.18.18.mov

[filip-solecki]

Looks like a bug, let me check

[ZhenjaHorbach]

@filip-solecki
And I'm sorry 😅
But I found another issue
We can't find submitter of the Request using search

[filip-solecki]

@ZhenjaHorbach can you upload a video?

[ZhenjaHorbach]

But actually it works a bit strange

When we open screen, we couldn't find the submitter using search
But if we unselect, submitter will be always visible using search

2024-09-04.11.08.55.mov

[blazejkustra]

The diff just got hugee (we need to merge the newest main on the feature branch)

Also @zfurtak / @filip-solecki let's add test steps to the description 👀

[Julesssss]

Thanks all, this is looking good. As we haven't yet made the backend changes available to you I think we are in a good place to merge to the feature branch. Then we can create bugs for the remaining issues.

Once main is merged I'm going to add a C+ reviewer to try to locate other bugs that may have been mixed.

[ZhenjaHorbach]

In this case React Compiler left !

https://github.com/Expensify/App/actions/runs/10701554408/job/29667753333?pr=48008

[ZhenjaHorbach]

@zfurtak
Thanks for fixing !
But sorry for making you do extra work
We can ignore this particular problem following this comment 😅

But it's optional
In any case LGTM !

[zfurtak]

@ZhenjaHorbach don't worry! it was not very elegant but for sure quick fix 😊

And when I open screen Recents list is empty, but when I unselect submitter of the Request
I have full Recents list

About this bug, I couldn't reproduce it, did you do anything special? 😅

When we open screen, we couldn't find the submitter using search
But if we unselect, submitter will be always visible using search

This one I managed to reproduce and indeed it's very weird... I will look into this right now 🕵️‍♀️

[ZhenjaHorbach]

And when I open screen Recents list is empty, but when I unselect submitter of the Request
I have full Recents list

About this bug, I couldn't reproduce it, did you do anything special? 😅

Yeah
I set includeRecentReports: true for testing
But I think it's not critical
Since first of all we need to start using recentAttendees (which is not ready yet)
And then retest this issue

[blazejkustra]

LGTM!

[Julesssss]

Okay, this is looking good. Let's merge these changes to the feature branch so we can get the backend changes in place for you. Then we can handle the remaining bugs (recent empty, workspaces showing in list, ect)

[parasharrajat]

Attendee is optional thus editing an attendee on an old transaction where no attendee was selected, shows required attendee error. We didn't was default attendee. It caused #62325