Refactor MoneyRequestAttendeeSelector to use useSearchSelector hook#71849
Refactor MoneyRequestAttendeeSelector to use useSearchSelector hook#71849iwiznia merged 33 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
melvin-bot
bot
requested review from
sobitneupane
and removed request for
a team
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@NJ-2020 Could you please resolve the merge conflicts, |
|
I'll fix it tomorrow morning. Thanks |
sobitneupane
left a comment
sobitneupane
left a comment
There was a problem hiding this comment.
I noticed the following issue while testing the app: once I deselect the current account, it no longer appears in the list.
Screen.Recording.2025-10-13.at.15.59.38.mov
@NJ-2020 Is this the expected behavior? On staging and production, the current user appears in the list. |
|
Another strange issue I noticed: when I select the first option in the list, its email and profile change to those of the current user, and the option cannot be deselected. I can’t reproduce the issue consistently. After clearing the cache, it doesn’t occur initially, but it reappears after some time. Screen.Recording.2025-10-13.at.17.14.43.mov |
| import { | ||
| filterAndOrderOptions, | ||
| formatSectionsFromSearchTerm, | ||
| getAttendeeOptions, |
There was a problem hiding this comment.
I believe we can remove getAttendeeOptions from OptionsListUtils if it's not used elsewhere.
| [attendees], | ||
| ); | ||
|
|
||
| const {searchTerm, debouncedSearchTerm, setSearchTerm, availableOptions, selectedOptions, toggleSelection, areOptionsInitialized, onListEndReached} = useSearchSelector({ |
There was a problem hiding this comment.
@NJ-2020 We’re currently using searchTerm instead of debouncedSearchTerm in InviteReportParticipantsPage and other pages that use useSearchSelector. Should we do the same here if there are no side effects?
There was a problem hiding this comment.
@sobitneupane debouncedSearchTerm is used for searchInServer
There was a problem hiding this comment.
@sosek108 Even for serchInServer, we are using searchTerm returned by useSearchSelector in InviteReportParticipantsPage.
App/src/pages/InviteReportParticipantsPage.tsx
Lines 68 to 71 in 27845f8
I agree that we should use the debounced value for API requests, though.
There was a problem hiding this comment.
so probably we need to update that in InviteReportParticipantsPage.
Or maybe (out of scope?) can we move this searchInServer call to the hook?
Pros:
- less code duplication
Cons:
- hook has side effect
There was a problem hiding this comment.
Even for serchInServer, we are using searchTerm returned by useSearchSelector in InviteReportParticipantsPage
@sobitneupane FYI, I see debouncedSearchTerm is being implemented/used in several PRs including: #71446 and #71427
There was a problem hiding this comment.
I think if necessary we can move searchInServer to the hook and add create new property/flag useDebounce: true | false, if it's set to true then searchInServer will use debouncedSearchTerm, else use the normal search term
cc: @sosek108
| includeUserToInvite: true, | ||
| excludeLogins: CONST.EXPENSIFY_EMAILS_OBJECT, | ||
| includeRecentReports: true, | ||
| getValidOptionsConfig: { |
There was a problem hiding this comment.
It seems getValidOptionsConfig is being passed to useSearchSelector but isn’t used. Let’s either utilize it in useSearchSelector if necessary, or remove it if not.
|
|
||
| useEffect(() => { | ||
| handleSelectionChange(selectedOptions); | ||
| }, [selectedOptions, handleSelectionChange]); |
There was a problem hiding this comment.
I might be missing some context, but could you clarify why this change is needed? It doesn’t seem like the usual way we handle selection. Is this consistent with how it’s done on other pages?
There was a problem hiding this comment.
useSearchSelector should handle selection using toggleOption
|
👀 |
| import { | ||
| filterAndOrderOptions, | ||
| formatSectionsFromSearchTerm, | ||
| getAttendeeOptions, |
| if (isPaidGroupPolicy) { | ||
| const orderedOptions = orderOptions(optionList, searchTerm, { | ||
|
|
||
| const orderedOptions = orderOptions( |
There was a problem hiding this comment.
hook is responsible for ordering. Is there any cause we need to order this again?
There was a problem hiding this comment.
@sosek108 I'm following the current implementation logic where we reorder the options/list for group paid policies:
App/src/pages/iou/request/MoneyRequestAttendeeSelector.tsx
Lines 103 to 112 in 5c27729
This was originally added in #48008 and later modified in #53056.
If necessary, we can ask the author to understand the reasoning behind this approach and check if this still necessary. Thanks
|
|
||
| useEffect(() => { | ||
| handleSelectionChange(selectedOptions); | ||
| }, [selectedOptions, handleSelectionChange]); |
There was a problem hiding this comment.
useSearchSelector should handle selection using toggleOption
| const initialSelectedOptions = useMemo( | ||
| () => | ||
| attendees.map((attendee) => ({ | ||
| accountID: attendee.accountID ?? CONST.DEFAULT_NUMBER_ID, | ||
| login: attendee.email, | ||
| text: attendee.displayName, | ||
| searchText: attendee.searchText ?? attendee.displayName, | ||
| avatarUrl: attendee.avatarUrl, | ||
| reportID: CONST.DEFAULT_NUMBER_ID.toString(), | ||
| selected: true, | ||
| })), | ||
| [attendees], | ||
| ); |
There was a problem hiding this comment.
I belive that we don't need that when we use useSearchSelector
There was a problem hiding this comment.
I think when user is opening the money request attendee selector we have default selected options here
So I think we should pass it into useSearchSelector.
Wdyt?, please lmk if I am missing something.
| [attendees], | ||
| ); | ||
|
|
||
| const {searchTerm, debouncedSearchTerm, setSearchTerm, availableOptions, selectedOptions, toggleSelection, areOptionsInitialized, onListEndReached} = useSearchSelector({ |
There was a problem hiding this comment.
@sobitneupane debouncedSearchTerm is used for searchInServer
| const restOfRecents = [...orderedAvailableOptions.recentReports].slice(5); | ||
| const contactsWithRestOfRecents = [...restOfRecents, ...orderedAvailableOptions.personalDetails]; |
There was a problem hiding this comment.
you can pass maxRecentReportsToShow: 5 to the hook to get only 5 elements for recents
Fixed ☑️
Sorry about that, fixed ☑️
I just modified some of the code, can you please re-test to check if the issue still persists? Thanks. |
melvin-bot
bot
requested review from
heyjennahay
and removed request for
a team
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@sobitneupane Weird, I've tried this multiple times, clearing cache/using 2 browser with same account, but still I couldn't Could you please re-check if the bug still occurs (this PR/staging)? And if possible can you please try sending/DM me the Onyx state data, that way it will help me resolve this bug faster. Thanks |
|
I am trying to reproduce the issue. It seems the issue is no longer reproducible. I will try again and let you know if I can reproduce it. |
There was a problem hiding this comment.
Screenshots/Videos
Android: HybridApp
Screen.Recording.2025-11-05.at.18.10.17.mov
Android: mWeb Chrome
Screen.Recording.2025-11-05.at.18.13.25.mov
iOS: HybridApp
Screen.Recording.2025-11-05.at.17.40.13.mov
Screen.Recording.2025-11-05.at.17.45.07.mov
iOS: mWeb Safari
Screen.Recording.2025-11-05.at.17.46.54.mov
MacOS: Chrome / Safari
Screen.Recording.2025-11-05.at.17.14.40.mov
Updated:
Screen.Recording.2025-11-12.at.21.01.07.mov
Screen.Recording.2025-11-12.at.21.04.29.mov
MacOS: Desktop
Screen.Recording.2025-11-05.at.18.18.33.mov
|
@NJ-2020 The behavior of Recents differs between staging and the PR. In staging, we only show five contacts. In the PR, when I deselect selected contacts, almost all of them move to Recents, causing more than five to appear. RecordingsScreen.Recording.2025-11-05.at.18.29.40.movScreen.Recording.2025-11-05.at.18.30.07.mov |
|
Refactor PR, doesn’t have any new product considerations. Removing and unsubscribing myself |
@sobitneupane Fixed ☑️ |
sobitneupane
left a comment
sobitneupane
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified there are no new alerts related to the
canBeMissingparam foruseOnyx - I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
|
@iwiznia Kindly bump |
|
I already approved, was waiting for @sosek108 to re-approve, or we don't want to wait on their review? |
I think we're already good to merge |
sosek108
left a comment
sosek108
left a comment
There was a problem hiding this comment.
LGTM :)
Sorry for the delay, I've just seen a bump
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.2.62-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀
|
6 participants
Explanation of Change
Refactor MoneyRequestAttendeeSelector to use useSearchSelector hook, remove unused/duplicated code.
Fixed Issues
$ #71064
PROPOSAL: #71064 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
71064_android_native.mp4
Android: mWeb Chrome
71064_android_mweb.mp4
iOS: Native
Screen.Recording.2025-10-06.at.11.06.50.mp4
iOS: mWeb Safari
Screen.Recording.2025-10-06.at.10.59.53.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-10-06.at.10.00.11.mp4
MacOS: Desktop
Screen.Recording.2025-10-06.at.11.09.35.mp4