[Due for payment 2025-05-22] [$250] Investigate iOS crash: TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined

[thienlnam]

Looks similar to this, #57786 but it's come back?

App version:9.1.31 (9.1.31.3)
OS version: iosiOS 18.3.2
Model:iPhone 14
Date:Apr 28, 2025, 7:55:47 AM

Exception in HostFunction: Unhandled JS Exception: TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined, stack: getOnboardingInitialPath@386950:39 startOnboardingFlow@386936:85 anonymous@601648:66 processNext@71250:18 _processUpdate@71175:30 anonymous@40356:22 Error: Exception in HostFunction: Unhandled JS Exception: TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined, stack: getOnboardingInitialPath@386950:39 startOnboardingFlow@386936:85 anonymous@601648:66 processNext@71250:18 _processUpdate@71175:30 anonymous@40356:22 at validatePathConfig (/private/var/containers/Bundle/Application/CFBECB19-6DAF-4A05-9B05-2C3BBC539E44/Expensify.app/main.jsbundle:345859:49) at anonymous (/private/var/containers/Bundle/Application/CFBECB19-6DAF-4A05-9B05-2C3BBC539E44/Expensify.app/main.jsbundle:345871:29) at forEach (native) at validatePathConfig (/private/var/containers/Bundle/Application/CFBECB19-6DAF-4A05-9B05-2C3BBC539E44/Expensify.app/main.jsbundle:345866:45) at anonymous (/private/var/containers/Bundle/Application/CFBECB19-6DAF-4A05-9B05-2C3BBC539E44/Expensify.app/main.jsbundle:345871:29) at forEach (native) at validatePathConfig (/private/var/containers/Bundle/Application/CFBECB19-6DAF-4A05-9B05-2C3BBC539E44/Expensify.app/main.jsbundle:345866:45) at anonymous (/private/var/containers/Bundle/Application/CFBECB19-6DAF-4A05-9B05-2C3BBC539E44/Expensify.app/main.jsbundle:345871:29) at forEach (native) at validatePathConfig (/private/var/containers/Bundle/Application/CFBECB19-6DAF-4A05-9B05-2C3BBC539E44/Expensify.app/main.jsbundle:345866:45) at NavigationContainerInner (/private/var/containers/Bundle/Application/CFBECB19-6DAF-4A05-9B05-2C3BBC539E44/Expensify.app/main.jsbundle:348677:58) at renderWithHooks (/private/var/containers/Bundle/Application/CFBECB19-6DAF-4A05-9B05-2C3BBC539E44/Expensify.app/main.jsbundle:85137:24) at updateForwardRef (/private/var/containers/Bundle/Application/CFBECB19

com.expensify.expensifylite_issue_7e6561266c32bd1eb77ce2c59edd70a4_crash_session_fc203a2f12dc46939c3d147377c84cad_DNE_1_v2_stacktrace.txt

App version:9.1.30 (9.1.30.4)
OS version: iosiOS 18.3.2
Model:iPhone 15 Pro
Date:Apr 22, 2025, 1:58:06 PM

Exception in HostFunction: Unhandled JS Exception: TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined, stack: getOnboardingInitialPath@386866:39 startOnboardingFlow@386852:85 anonymous@601459:66 processNext@71250:18 _processUpdate@71175:30 anonymous@40356:22 Error: Exception in HostFunction: Unhandled JS Exception: TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined, stack: getOnboardingInitialPath@386866:39 startOnboardingFlow@386852:85 anonymous@601459:66 processNext@71250:18 _processUpdate@71175:30 anonymous@40356:22 at bailoutOnAlreadyFinishedWork (/private/var/containers/Bundle/Application/63FB44C0-318B-496F-B963-27591FC48B86/Expensify.app/main.jsbundle:86360:61) at attemptEarlyBailoutIfNoScheduledUpdate (/private/var/containers/Bundle/Application/63FB44C0-318B-496F-B963-27591FC48B86/Expensify.app/main.jsbundle:86413:40) at beginWork (/private/var/containers/Bundle/Application/63FB44C0-318B-496F-B963-27591FC48B86/Expensify.app/main.jsbundle:86418:159) at performUnitOfWork (/private/var/containers/Bundle/Application/63FB44C0-318B-496F-B963-27591FC48B86/Expensify.app/main.jsbundle:88005:25) at workLoopSync (/private/var/containers/Bundle/Application/63FB44C0-318B-496F-B963-27591FC48B86/Expensify.app/main.jsbundle:87916:55) at renderRootSync (/private/var/containers/Bundle/Application/63FB44C0-318B-496F-B963-27591FC48B86/Expensify.app/main.jsbundle:87900:19) at performConcurrentWorkOnRoot (/private/var/containers/Bundle/Application/63FB44C0-318B-496F-B963-27591FC48B86/Expensify.app/main.jsbundle:87707:160)

com.expensify.expensifylite_issue_42a044f8dfb3b91fac2fea265fd5e1f5_crash_session_3532bcd02b304b729744acf949189841_DNE_1_v2_stacktrace.txt

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021916929894008918195
• Upwork Job ID: 1916929894008918195
• Last Price Increase: 2025-04-28
• Automatic offers:
• nkdengineer | Contributor | 107097092

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @NicMendonca

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021916929894008918195

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-d (External)

[melvin-bot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot]

Upwork job price has been updated to $250

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined

What is the root cause of that problem?

When we call onboardingValues.signupQualifier, onboardingValues itself is undefined at the time we're trying to access it.
This is why we're crashing — we're trying to read a property signupQualifier of undefined

What changes do you think we should make in order to solve the problem?

Here

App/src/libs/actions/Welcome/OnboardingFlow.ts

Line 69 in bd0f3f2

const isVsb = onboardingValues && 'signupQualifier' in onboardingValues && onboardingValues.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB;

App/src/pages/OnboardingWorkEmail/BaseOnboardingWorkEmail.tsx

Line 48 in bd0f3f2

const isVsb = onboardingValues && 'signupQualifier' in onboardingValues && onboardingValues.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB;

App/src/pages/OnboardingWorkEmailValidation/BaseOnboardingWorkEmailValidation.tsx

Line 38 in bd0f3f2

const isVsb = onboardingValues && 'signupQualifier' in onboardingValues && onboardingValues.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB;

we should explicitly check signupQualifier with optional chain

const isVsb = onboardingValues?.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB;
const isSmb = onboardingValues?.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.SMB;
const isIndividual = onboardingValues?.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.INDIVIDUAL;
...

and on other locations where we use signupQualifier
This way, if onboardingValues is undefined, it will NOT crash, it will just return false.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.