[Due for payment 2025-05-22] [Due for payment 2025-05-20] [$250] Report fields - Search field disappears after entering search term

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.42-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: #60488
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Report fields are enabled in workspace settings > More features.
• Create a list type report field with at least 16 list values.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Report fields.
3. Click on the list type report field.
4. Click List values.
5. Enter search term in the search field.

Expected Result:

Search field will not disappear after entering search term.

Actual Result:

Search field disappears after entering search term.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6825246_1746684692248.20250508_140838.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021920379890102559140
• Upwork Job ID: 1920379890102559140
• Last Price Increase: 2025-05-15

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Burhan-Rashid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report fields - Search field disappears after entering search term

What is the root cause of that problem?

we are showing the search bar only if the length of the filtered list items is greater than 15. Once we enter some text in the search bar and the matching items list length is less than 15, the search bar disappears.

App/src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx

Lines 333 to 335 in f9942f1

	{filteredListValues.length > CONST.SEARCH_ITEM_LIMIT && (
	<SearchBar
	label={translate('workspace.reportFields.findReportField')}

Issue coming from this PR: #60488

What changes do you think we should make in order to solve the problem?

Instead of using the filtered list length filteredListValues.length, we need to use the original list length data.length

{data?.length > CONST.SEARCH_ITEM_LIMIT && (
                    <SearchBar
                        label={translate('workspace.reportFields.findReportField')}
                        inputValue={inputValue}
                        onChangeText={setInputValue}
                        shouldShowEmptyState={!shouldShowEmptyState && filteredListValues.length === 0}
                    />
                )}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.