Skip to content

Fix: add search bar to lists with items above 15#60488

Merged
roryabraham merged 29 commits intoExpensify:mainfrom
daledah:fix/59864
May 7, 2025
Merged

Fix: add search bar to lists with items above 15#60488
roryabraham merged 29 commits intoExpensify:mainfrom
daledah:fix/59864

Conversation

@daledah
Copy link
Contributor

@daledah daledah commented Apr 18, 2025

Explanation of Change

Fixed Issues

$ #59864
PROPOSAL: #59864 (comment)

Tests

  1. Go to WS Categories Page
  2. Verify that: If there's more than 15 categories there will be a search bar
  3. Type some text to search bar
  4. Verify that: The category list is filtered based on input
  5. Type a nonexistent category name
  6. Verify that: "No result found matching ..." text is displayed
  7. Click on clear (x) button
  8. Verify that: Input text is cleared and category list is reset.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Go to WS Categories Page
  2. Verify that: If there's more than 15 categories there will be a search bar
  3. Type some text to search bar
  4. Verify that: The category list is filtered based on input
  5. Type a nonexistent category name
  6. Verify that: "No result found matching ..." text is displayed
  7. Click on clear (x) button
  8. Verify that: Input text is cleared and category list is reset.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2025-04-21.at.09.42.03.mov
Android: mWeb Chrome
Screen.Recording.2025-04-21.at.09.53.29.mov
iOS: Native
Screen.Recording.2025-04-21.at.09.53.53.mov
iOS: mWeb Safari
Screen.Recording.2025-04-21.at.09.59.02.mov
MacOS: Chrome / Safari
Screen.Recording.2025-04-21.at.10.19.28.mov
MacOS: Desktop
Screen.Recording.2025-04-21.at.10.20.10.mov

@daledah daledah changed the title Fix/59864 Fix: add search bar to lists with items above 15 Apr 18, 2025
@daledah daledah marked this pull request as ready for review April 21, 2025 03:40
@daledah daledah requested review from a team as code owners April 21, 2025 03:40
@melvin-bot melvin-bot bot requested review from thesahindia and removed request for a team April 21, 2025 03:41
@melvin-bot
Copy link

melvin-bot bot commented Apr 21, 2025

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Contributor

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@shawnborton
Copy link
Contributor

For the search icon, I think we don't need to wrap it with any kind of horizontal padding or anything, let's just display the 20x20 icon all the way over to the right:
CleanShot 2025-04-21 at 10 36 58@2x

This way it lines up perfectly when we have the "x" icon in place:

CleanShot 2025-04-21 at 10 37 33@2x

@shawnborton
Copy link
Contributor

I think that even when you are not focused in the search input, as long as it has a value, we should show the "x" button. Right now it only shows the "x" if you are focused into it:
CleanShot 2025-04-21 at 10 37 59@2x

@shawnborton
Copy link
Contributor

Otherwise generally the functionality feels nice and snappy to me!

@shawnborton
Copy link
Contributor

Can you show us all of the pages where you added this? I assume for things like distance rates, members, tags, categories, maybe even report fields?

@dannymcclain
Copy link
Contributor

Agree with all of Shawn's comments above, but yeah this is feeling pretty good!

@dubielzyk-expensify
Copy link
Contributor

dubielzyk-expensify commented Apr 22, 2025

Great callouts, @shawnborton . Just tested the test build and other than those comments this is looking great 👍

Just a sidenote for designers that there's an interesting case when you multi-select. We could decide to do nothing here or we could decide to clear the selection or search filter when interacting with it. I think we wanna do nothing, but just mentioning it:

CleanShot.2025-04-22.at.10.07.34.mp4

While it's weird that you have selections that aren't shown, but I think it's weirder if we start messing with their interactions. Given you might wanna select "Car", then search for "Entertainment" and select that, then another etc. Thoughts?

@shawnborton
Copy link
Contributor

Great find and great points - I think I agree with the "do nothing" approach for now then, because as you say, you might want to filter, find something, select it, and then clear the filter and do something with all of your selections.

@daledah
Copy link
Contributor Author

daledah commented Apr 22, 2025

If that's the case, how about we display both filtered results and selected results in the page? The selected items will be placed on top of the list for better view. I think I can work on that.

@shawnborton
Copy link
Contributor

I think the idea is to do nothing here. So just leave the behavior as it currently is. cc @Expensify/design for gut check.

@dannymcclain
Copy link
Contributor

I'm fine with doing nothing for now. I think if we find that people are using it and getting confused, we can try displaying both selected and filtered. But for now, I'm down to do nothing and leave as is.

@daledah
Copy link
Contributor Author

daledah commented Apr 22, 2025

Can you show us all of the pages where you added this

Here's the pages that I implemented search in this PR:

  1. WS Members Page
Screenshot 2025-04-22 at 22 36 55
  1. WS Categories Page
Screenshot 2025-04-22 at 22 37 01
  1. WS Tags Page
Screenshot 2025-04-22 at 22 40 38
  1. WS View Tags Page
Screenshot 2025-04-22 at 22 40 51
  1. WS Report Fields Page
Screenshot 2025-04-22 at 22 44 22
  1. WS Report Field List Values Page
Screenshot 2025-04-22 at 22 44 30

I didn't implement Distance rates page and Taxes Page

@daledah
Copy link
Contributor Author

daledah commented Apr 22, 2025

Here's the updated Icon:

Screen.Recording.2025-04-22.at.22.51.19.mov

cc @shawnborton

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Performance Comparison Report 📊 (5/12)

Meaningless Changes To Duration (4/11)

Show entries
Name Duration
App start time nativeLaunchEnd_To_appCreationStart 77.650 ms → 78.193 ms (+0.543 ms, +0.7%)
App start time nativeLaunch 24.298 ms → 24.328 ms (+0.029 ms, ±0.0%)
App start time appCreation 73.150 ms → 72.500 ms (-0.650 ms, -0.9%)
App start time appCreationEnd_To_contentAppeared 496.414 ms → 507.967 ms (+11.553 ms, +2.3%)
App start time runJsBundle 312.983 ms → 318.350 ms (+5.367 ms, +1.7%)
App start time regularAppStart 0.020 ms → 0.020 ms (-0.001 ms, -3.4%)
App start time TTI 1708.746 ms → 1740.860 ms (+32.113 ms, +1.9%)
App start time (CPU) 148.668 % → 147.348 % (-1.320 %, -0.9%)
App start time (FPS) 59.829 FPS → 60.000 FPS (+0.171 FPS, ±0.0%)
App start time (RAM) 399.280 MB → 393.632 MB (-5.648 MB, -1.4%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 25.813 % → 25.837 % (+0.024 %, ±0.0%)
Open search router TTI Open Search Router TTI 1272.770 ms → 1291.596 ms (+18.826 ms, +1.5%)
Open search router TTI Load Search Options 140.734 ms → 141.782 ms (+1.048 ms, +0.7%)
Open search router TTI (CPU) 146.644 % → 145.679 % (-0.966 %, -0.7%)
Open search router TTI (FPS) 60.000 FPS → 60.000 FPS
Open search router TTI (RAM) 414.545 MB → 415.388 MB (+0.843 MB, ±0.0%)
Open search router TTI (CPU/JS) 0.000 % → 0.000 %
Open search router TTI (CPU/UI) 26.045 % → 25.907 % (-0.138 %, -0.5%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 490.536 ms → 487.494 ms (-3.042 ms, -0.6%)
Report typing (CPU) 96.529 % → 96.359 % (-0.169 %, ±0.0%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 477.306 MB → 476.556 MB (-0.750 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 20.788 % → 20.857 % (+0.069 %, ±0.0%)
Chat opening Chat TTI 750.723 ms → 736.230 ms (-14.493 ms, -1.9%)
Chat opening (CPU) 159.535 % → 161.574 % (+2.039 %, +1.3%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 400.850 MB → 401.009 MB (+0.159 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 33.053 % → 32.927 % (-0.126 %, ±0.0%)
Money request - Open Manual Tracking 138.937 ms → 141.846 ms (+2.909 ms, +2.1%)
Money request - Open Contacts 229.244 ms → 236.505 ms (+7.261 ms, +3.2%)
Money request - Open Create 139.404 ms → 140.846 ms (+1.442 ms, +1.0%)
Money request (CPU) 178.343 % → 179.214 % (+0.872 %, ±0.0%)
Money request (FPS) 59.183 FPS → 59.026 FPS (-0.157 FPS, ±0.0%)
Money request (RAM) 469.302 MB → 471.845 MB (+2.543 MB, +0.5%)
Money request (CPU/JS) 0.000 % → 0.000 %
Money request (CPU/UI) 44.443 % → 45.117 % (+0.673 %, +1.5%)
Show details
Name Duration
App start time (RAM) Baseline
Mean: 399.280 MB
Stdev: 7.200 MB (1.8%)
Runs: 380.71875 384.2109375 387.953125 388.251953125 388.423828125 388.5 388.96875 389.767578125 389.921875 390.08203125 390.203125 390.525390625 390.53125 391.083984375 394.68359375 394.7747395833333 394.8854166666667 395.6575520833333 396.328125 396.33984375 397.625 398.7174479166667 398.9934895833333 399.4619140625 399.5104166666667 399.9075520833333 399.9700520833333 400.0221354166667 400.25 400.4755859375 400.9921875 401.0377604166667 401.3580729166667 401.4700520833333 401.875 402.1197916666667 402.2958984375 402.44921875 402.51953125 402.8372395833333 402.9622395833333 402.9947916666667 403.03125 403.9361979166667 404.1393229166667 404.46484375 404.91796875 405.3359375 405.4830729166667 405.751953125 405.904296875 406.0078125 407.6064453125 407.6927083333333 408.5234375 408.73046875 409.3056640625 410.2353515625 411.6497395833333 412.4326171875

Current
Mean: 393.632 MB
Stdev: 8.297 MB (2.1%)
Runs: 377.39453125 378.6653645833333 380.0390625 380.2057291666667 380.69140625 381.8932291666667 382.2122395833333 382.4375 382.859375 384.2018229166667 384.93359375 385.19921875 386.669921875 387.1888020833333 387.2578125 387.708984375 389.04296875 389.4466145833333 389.5130208333333 389.7200520833333 390.85546875 390.8971354166667 390.919921875 391.3958333333333 391.529296875 391.63671875 392.1692708333333 392.47265625 394.0572916666667 394.6328125 396.546875 396.8489583333333 396.8776041666667 396.935546875 397.1380208333333 397.2161458333333 397.8736979166667 397.95703125 398.0520833333333 398.1106770833333 398.1953125 398.6171875 398.6575520833333 398.828125 398.8932291666667 399.109375 400.2864583333333 401.046875 401.5091145833333 402.0403645833333 403.1510416666667 403.4557291666667 404.0494791666667 405.3346354166667 406 407.3138020833333 408.3763020833333 414.3841145833333
App start time (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
App start time (CPU/UI) Baseline
Mean: 25.813 %
Stdev: 2.182 % (8.5%)
Runs: 21 21.9 22.1 22.1 22.5 22.6 22.7 22.7 23.4 23.4 24 24 24 24 24.1 24.1 24.6 24.7 25.2 25.2 25.3 25.3 25.3 25.3 25.3 25.4 25.4 25.5 25.9 25.9 26 26 26 26 26.2 26.5 26.5 26.5 26.7 26.7 26.9 27 27 27 27 27 27.1 27.3 27.5 27.7 28 28 28.1 28.4 28.5 28.8 29.9 30.2 30.6 30.8

Current
Mean: 25.837 %
Stdev: 2.799 % (10.8%)
Runs: 19.9 21.1 21.8 22 22.5 22.6 22.7 22.7 23.1 23.2 23.2 23.2 23.7 23.8 23.8 23.9 24 24 24 24.1 24.5 24.5 24.6 24.6 24.6 24.7 24.7 24.8 25 25.9 25.9 26 26 26 26 26.2 26.2 26.4 26.4 26.6 27.1 27.3 27.4 27.4 27.9 28.4 28.5 28.8 29.2 29.3 29.4 29.4 29.8 30 30 30.6 31.2 31.3 32.5

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Performance Comparison Report 📊 (6/12)

Meaningless Changes To Duration (5/11)

Show entries
Name Duration
App start time nativeLaunchEnd_To_appCreationStart 77.650 ms → 78.193 ms (+0.543 ms, +0.7%)
App start time nativeLaunch 24.298 ms → 24.328 ms (+0.029 ms, ±0.0%)
App start time appCreation 73.150 ms → 72.500 ms (-0.650 ms, -0.9%)
App start time appCreationEnd_To_contentAppeared 496.414 ms → 507.967 ms (+11.553 ms, +2.3%)
App start time runJsBundle 312.983 ms → 318.350 ms (+5.367 ms, +1.7%)
App start time regularAppStart 0.020 ms → 0.020 ms (-0.001 ms, -3.4%)
App start time TTI 1708.746 ms → 1740.860 ms (+32.113 ms, +1.9%)
App start time (CPU) 148.668 % → 147.348 % (-1.320 %, -0.9%)
App start time (FPS) 59.829 FPS → 60.000 FPS (+0.171 FPS, ±0.0%)
App start time (RAM) 399.280 MB → 393.632 MB (-5.648 MB, -1.4%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 25.813 % → 25.837 % (+0.024 %, ±0.0%)
Open search router TTI Open Search Router TTI 1272.770 ms → 1291.596 ms (+18.826 ms, +1.5%)
Open search router TTI Load Search Options 140.734 ms → 141.782 ms (+1.048 ms, +0.7%)
Open search router TTI (CPU) 146.644 % → 145.679 % (-0.966 %, -0.7%)
Open search router TTI (FPS) 60.000 FPS → 60.000 FPS
Open search router TTI (RAM) 414.545 MB → 415.388 MB (+0.843 MB, ±0.0%)
Open search router TTI (CPU/JS) 0.000 % → 0.000 %
Open search router TTI (CPU/UI) 26.045 % → 25.907 % (-0.138 %, -0.5%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 490.536 ms → 487.494 ms (-3.042 ms, -0.6%)
Report typing (CPU) 96.529 % → 96.359 % (-0.169 %, ±0.0%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 477.306 MB → 476.556 MB (-0.750 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 20.788 % → 20.857 % (+0.069 %, ±0.0%)
Chat opening Chat TTI 750.723 ms → 736.230 ms (-14.493 ms, -1.9%)
Chat opening (CPU) 159.535 % → 161.574 % (+2.039 %, +1.3%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 400.850 MB → 401.009 MB (+0.159 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 33.053 % → 32.927 % (-0.126 %, ±0.0%)
Money request - Open Manual Tracking 138.937 ms → 141.846 ms (+2.909 ms, +2.1%)
Money request - Open Contacts 229.244 ms → 236.505 ms (+7.261 ms, +3.2%)
Money request - Open Create 139.404 ms → 140.846 ms (+1.442 ms, +1.0%)
Money request (CPU) 178.343 % → 179.214 % (+0.872 %, ±0.0%)
Money request (FPS) 59.183 FPS → 59.026 FPS (-0.157 FPS, ±0.0%)
Money request (RAM) 469.302 MB → 471.845 MB (+2.543 MB, +0.5%)
Money request (CPU/JS) 0.000 % → 0.000 %
Money request (CPU/UI) 44.443 % → 45.117 % (+0.673 %, +1.5%)
Show details
Name Duration
Open search router TTI Open Search Router TTI Baseline
Mean: 1272.770 ms
Stdev: 85.058 ms (6.7%)
Runs: 1057.750163000077 1064.3576259999536 1068.2388920001686 1069.0166840003803 1073.1959639997222 1074.3559580002911 1079.6703289998695 1079.7611090000719 1083.3077799999155 1083.8899749997072 1084.1690269997343 1085.6055510002188 1086.6394859999418 1088.2415770003572 1089.1479500001296 1089.6861980003305 1091.3323160000145 1091.9257000000216 1092.5553799998015 1092.6609700000845 1093.016601999756 1094.1581629998982 1099.951783000026 1101.9044599998742 1106.039916999638 1111.425048999954 1112.1460370002314 1116.5246190000325 1117.7058109999634 1119.8525399998762 1127.443808000069 1127.6542569999583 1128.108153999783 1129.7177740000188 1130.1829439997673 1131.6512460000813 1131.7347009996884 1131.7561039999127 1132.5167239997536 1135.3733729999512 1135.7208660002798 1136.9718019999564 1141.0316570000723 1141.8208829998039 1142.3092450001277 1142.7765709999949 1143.4480389999226 1143.9075939999893 1148.6971439998597 1148.8507489999756 1148.8516850001179 1149.5264900000766 1150.1984459999949 1155.332641999703 1155.4296059999615 1157.9137369999662 1158.0578209999949 1159.1342779998668 1165.1667889999226 1166.990967000369 1167.7855630000122 1168.4210210000165 1169.375489000231 1171.805420000106 1172.8018800001591 1174.7867029998451 1174.8431400000118 1175.3310560001992 1176.939168999903 1178.9205729998648 1180.0439059999771 1181.0993249998428 1181.7380369999446 1184.665771999862 1185.4793710000813 1187.5830080001615 1187.6655679997057 1187.8188889999874 1188.907226999756 1191.7554529998451 1192.4554050001316 1196.4863289999776 1200.6302910000086 1202.9380700001493 1203.1825769999996 1206.319540000055 1209.2333580004051 1209.305583000183 1210.8287769998424 1210.9079999998212 1211.7690440001898 1212.428549000062 1212.5529789999127 1214.528768000193 1214.726766999811 1214.726766999811 1214.74454900017 1216.7583829998039 1216.7709150002338 1217.0141610000283 1219.4596770000644 1220.0756029998884 1221.0738530000672 1222.7346200002357 1223.0346270003356 1223.763590999879 1224.4268799996935 1225.0230720001273 1225.6647959998809 1228.0992439999245 1228.869791999925 1230.7114260001108 1231.3237709999084 1231.8358569997363 1233.0464280000888 1233.3306080000475 1233.447063000407 1233.9890140001662 1234.4237480000593 1234.8592130001634 1234.8592130001634 1236.5596519997343 1236.643635999877 1237.213378999848 1237.776368000079 1238.535808000248 1239.6953949998133 1239.6953949998133 1240.0250660004094 1240.6291919997893 1241.7468270002864 1242.6822510003112 1243.2798669999465 1243.2798669999465 1243.4570730002597 1244.685099999886 1244.8650719998404 1245.001018000301 1245.2093110000715 1246.552409000229 1248.4296880001202 1248.4296880001202 1248.8668630002066 1249.4925130000338 1249.600708000362 1249.771851000376 1250.18648400018 1250.9573979997076 1251.132406000048 1251.3918050001375 1251.859172000084 1252.323040000163 1252.490683000069 1254.379558000248 1255.7857270003296 1256.0692549999803 1256.8592130001634 1257.6714280000888 1258.0587570001371 1258.8451740001328 1259.115356999915 1259.23177199997 1259.3308109999634 1259.3906660000794 1259.5377209996805 1259.7744150003418 1259.7989920000546 1259.9440930001438 1262.5951750003733 1262.9556479998864 1262.96980800014 1264.494955000002 1265.2507329997607 1266.408894999884 1267.3875330002047 1267.7336019999348 1268.3981130002066 1268.413290000055 1269.6212170002982 1270.0733650000766 1270.394125000108 1270.9302580002695 1271.1173510001972 1271.1990159996785 1271.794964000117 1273.3573410003446 1274.0697840000503 1274.2521170000546 1275.2017009998672 1275.5150150000118 1275.6781009999104 1275.7270510001108 1276.1442060000263 1276.6671549999155 1277.1662200000137 1277.1662200000137 1277.2018639999442 1277.400839000009 1277.871989000123 1277.871989000123 1277.8868410000578 1278.3273529997095 1278.6728529999964 1278.6728529999964 1279.4372570002452 1279.5154229998589 1279.9363609999418 1280.250692000147 1280.6737879998982 1281.026205000002 1281.0332849998958 1281.2683920003474 1281.2846280001104 1281.588012999855 1282.7379160001874 1283.24898400018 1283.24898400018 1283.4346110001206 1284.1840830002911 1284.8975430000573 1285.076864999719 1285.755492999684 1285.8077400000766 1286.2409669999033 1286.6752929999493 1286.7730720001273 1287.5207120003179 1287.5768640004098 1287.7729500001296 1287.82474800013 1287.9711110000499 1288.4971529999748 1288.645101999864 1289.4671229999512 1291.2633880004287 1291.5050869998522 1292.569742999971 1293.7114670001902 1294.2119559999555 1294.864014999941 1294.9797369996086 1295.5298270001076 1295.8865160001442 1296.3569750003517 1296.544637999963 1296.8300789999776 1297.8368329997174 1298.0393070001155 1298.7615160001442 1299.628337000031 1299.9806730002165 1300.1693120002747 1301.5853269998915 1301.9563810001127 1302.6889249999076 1303.7377530001104 1303.7567960000597 1303.979656000156 1304.1126709999517 1304.8811860000715 1305.085491000209 1305.1368010002188 1305.1580409999005 1305.4233400002122 1305.4888109997846 1306.8151050000452 1306.8151050000452 1306.9226079997607 1307.5054529998451 1307.5054529998451 1307.9109300002456 1308.2957770000212 1308.392985000275 1308.4128020000644 1308.5029299999587 1310.336670000106 1310.5013839998282 1311.9462490002625 1312.7874759999104 1312.9258219995536 1313.2354329996742 1313.3098960001953 1313.8068450000137 1313.963175999932 1314.615722999908 1315.9014900000766 1316.1507979999296 1316.1507979999296 1317.3431410002522 1317.5056159999222 1317.8560389997438 1318.3900160002522 1318.85884599993 1318.8806979996152 1319.3791910000145 1319.7058109999634 1320.9222830003127 1321.032755999826 1321.497070999816 1321.5556639996357 1321.6743169999681 1321.7726239999756 1321.8491620002314 1322.794353000354 1323.8177499999292 1323.9737959997728 1324.1538090002723 1324.2491060001776 1324.6756600001827 1326.8299159999005 1326.8653170000762 1327.3830569996499 1327.9241949999705 1328.2408050000668 1328.7924810000695 1329.4932050001808 1329.5461430000141 1329.8450120002963 1330.9800619999878 1330.9995130002499 1331.3737800000235 1333.0598960001953 1333.7460130001418 1333.8125410000794 1334.5529790003784 1334.650146999862 1335.0834160000086 1335.319213999901 1335.7644050000235 1335.795003999956 1335.807128999848 1335.8384610000066 1336.182455000002 1338.6272789998911 1340.6557220001705 1340.725058000069 1340.771159000229 1341.7477620001882 1341.819540000055 1342.6069340002723 1342.6357840001583 1342.9815279999748 1343.772949999664 1343.959351000376 1344.2512619998306 1345.2279880000278 1345.5163579997607 1346.520428000018 1346.8228360000066 1347.084635999985 1347.1043709996156 1347.3901379997842 1347.6855469997972 1348.1154379998334 1348.2813320001587 1348.2813320001587 1348.7544760000892 1349.1949470001273 1349.85705600027 1351.1387129998766 1351.975992999971 1352.007569000125 1352.3922940003686 1352.6722820000723 1353.2769379997626 1355.6929119997658 1357.0349120004103 1358.2556570000015 1358.3985190000385 1358.8204760001972 1359.3680429998785 1359.406860999763 1359.5529789999127 1360.0187180000357 1360.0425219996832 1362.0755620002747 1362.0755620002747 1364.1893730000593 1364.283692999743 1365.0985519997776 1365.2373869996518 1365.834351000376 1367.1352129997686 1367.4310719999485 1367.734864000231 1368.291464000009 1368.5372729999945 1368.6675619999878 1368.8369140001014 1368.8514819997363 1370.8820810001343 1373.5951739996672 1373.6229669996537 1373.9619149998762 1373.9619149998762 1374.7369800000452 1375.1859140000306 1375.6907959999517 1376.1900229998864 1377.2744550001808 1379.0170499999076 1379.6063649998978 1382.2999680000357 1383.9372979998589 1385.0911059998907 1388.1862800000235 1388.5331629998982 1388.6228849999607 1389.083617999684 1392.1161710000597 1392.2855230001733 1393.6807059999555 1394.7072349996306 1396.3930669999681 1400.0262860003859 1400.7203379999846 1401.4738369998522 1401.7515869997442 1403.3382979999296 1410.6241870000958 1412.0745439999737 1412.4865320003591 1413.872965999879 1418.2379150004126 1420.2841799999587 1429.0493580000475 1429.0493580000475 1432.4138600002043 1434.5458990000188 1437.9053150000982 1443.5049250000156 1446.7403159998357 1454.9874269999564

Current
Mean: 1291.596 ms
Stdev: 78.132 ms (6.0%)
Runs: 1099.6745609999634 1110.8420830001123 1111.7561040003784 1112.3271900000982 1116.019980000332 1116.5645750002004 1119.3753259996884 1120.0664070001803 1120.0959479999729 1120.3676350000314 1121.253866000101 1121.98567799991 1123.0511479997076 1123.477011000272 1124.2786870002747 1124.9060879996978 1125.1584890000522 1125.5311690000817 1125.5572110000066 1127.4751389999874 1130.3082690001465 1131.3826099997386 1131.696940000169 1135.5056160003878 1137.4790860000066 1138.0433359998278 1138.0457770000212 1138.4221609998494 1141.895020000171 1142.0814629998058 1143.5360109996982 1143.6813970003277 1146.7084559998475 1147.0562749998644 1147.5754809998907 1147.6388760004193 1150.339397000149 1151.3823250001296 1153.453125 1156.7054449999705 1159.0681969998404 1160.5574139999226 1160.5632330002263 1160.9879160001874 1162.6036380003206 1164.8435879996978 1166.9258639998734 1170.2004809998907 1172.7299000001512 1172.9557289998047 1174.9741220003925 1175.5523689999245 1183.4340420002118 1187.5586349996738 1188.1794030000456 1190.088339000009 1193.4673669999465 1194.837565000169 1196.0958670000546 1198.0340169998817 1200.2803140003234 1205.6072599999607 1206.347616000101 1206.558878999669 1208.358196000103 1211.6329349996522 1212.0082609998062 1212.5579840000719 1213.7521569998935 1214.5715340003371 1216.6802579998039 1218.3926189998165 1219.3211679998785 1222.8599049998447 1224.5845139999874 1226.6757000000216 1227.4892989997752 1227.8177899997681 1229.154542000033 1229.6041670003906 1229.6041670003906 1231.0090739997104 1232.563476999756 1234.857951999642 1236.2272549998015 1236.8842380000278 1239.9092619996518 1239.951417000033 1241.6422529998235 1243.0597740001976 1243.1361090000719 1244.6944989999756 1245.6272789998911 1245.6795660001226 1250.213705000002 1250.4418540000916 1250.6428629998118 1250.7796229999512 1250.9891770002432 1252.7064209999517 1252.9121509999968 1253.6682939999737 1254.3132330002263 1255.3678389997222 1256.2362879998982 1256.7952069998719 1257.8652749997564 1257.8656009999104 1259.0857750000432 1259.5940350000747 1259.8768310002051 1261.34399499977 1261.5513920001686 1262.9690359998494 1263.7104500001296 1263.7383630000986 1264.8369560004212 1264.8643400003202 1265.3750820001587 1267.5893560000695 1269.5303960000165 1270.5344659998082 1271.9662679997273 1272.0238859998062 1272.0238859998062 1272.0324300001375 1273.5688889999874 1275.3354090000503 1275.4849050003104 1275.9394539999776 1276.118570999708 1276.2132580000907 1276.2132580000907 1276.3278810000047 1276.5489099998958 1277.3752850000747 1278.302693999838 1279.0362150003202 1280.4167479998432 1280.9167080000043 1281.0316570000723 1281.1063239998184 1281.1556000001729 1281.6594650000334 1282.4383960003033 1282.69690000033 1282.8083509998396 1283.1116949999705 1284.3245450002141 1284.8066409998573 1285.7755539999343 1286.9503590003587 1287.047201000154 1287.9344889996573 1287.9499920001253 1288.0594489998184 1289.4454759997316 1290.0771900000982 1290.5561529998668 1290.6264650002122 1290.6264650002122 1290.982667000033 1290.9924329998903 1291.1234129997902 1291.272135999985 1291.422322999686 1291.5861829998903 1292.1117769996636 1292.1117769996636 1293.8549809996039 1294.4140220000409 1295.1000570002943 1295.1343590002507 1295.4016939997673 1295.584635999985 1295.7099199998192 1295.7099199998192 1296.0928150000982 1296.6985679999925 1296.6985679999925 1297.618449000176 1297.7750659999438 1298.045533000026 1298.1243500001729 1298.1428640000522 1298.7565919999033 1299.5380049999803 1300.212320999708 1300.9306239997968 1301.360880999826 1302.0334479999729 1302.352987000253 1302.4156899997033 1302.8300789999776 1303.0778819997795 1303.1414399999194 1303.1505950000137 1303.5831709997728 1303.6186119997874 1303.6501070000231 1304.088541999925 1305.0740970000625 1305.128866000101 1305.1784680001438 1305.3021650002338 1305.900839000009 1305.9738370003179 1306.4270030003972 1306.5571699999273 1307.4234629999846 1307.4490160001442 1307.84322099993 1308.5783700002357 1308.5783700002357 1308.867920000106 1309.5024430002086 1309.625326000154 1310.2325849998742 1310.416464000009 1310.8482670001686 1311.1005460000597 1311.5861420002766 1311.8907890003175 1312.279052999802 1312.9599210000597 1313.154542000033 1313.8979909997433 1314.10599800013 1314.2419850002043 1314.7846679999493 1315.138224999886 1315.4460050002672 1315.6017660000362 1315.6017660000362 1315.904908000026 1315.9335529999807 1316.4567070002668 1316.9114589998499 1317.4413250000216 1317.4598799999803 1317.9186209999025 1318.0850840001367 1318.4447439997457 1318.745810000226 1318.9459649999626 1319.7932549999095 1320.2814539996907 1320.4602870000526 1320.5462250001729 1320.5462250001729 1321.0684820003808 1321.2037360002287 1321.8433030000888 1321.8433030000888 1321.957154000178 1322.07605100004 1322.2599700000137 1322.2599700000137 1322.647867999971 1323.6764730000868 1323.738607000094 1324.1089679999277 1324.1517340000719 1324.1853030002676 1324.7897140001878 1325.1149499998428 1326.0109870000742 1326.0703949998133 1326.0703949998133 1327.5469570001587 1327.5501310001127 1327.6463630003855 1328.3933919998817 1328.487182999961 1328.4966239999048 1328.565673999954 1328.7017419999465 1329.507529000286 1329.7144380002283 1330.250855000224 1330.4836840000935 1330.567871000152 1330.613159999717 1331.6996260001324 1331.8370770001784 1332.00130299991 1332.00130299991 1332.0621750000864 1332.197348000016 1332.6833909996785 1333.5584720000625 1333.810465999879 1333.9042980000377 1334.0441090003587 1335.610311999917 1335.806559999939 1336.2359629999846 1336.4075530003756 1336.6984870000742 1337.0685640000738 1337.447348000016 1338.4907639999874 1338.878703000024 1341.2783619998954 1341.2803960000165 1341.9816490001976 1342.1566580003127 1342.1566580003127 1342.1784680001438 1344.1847340003587 1344.2125659999438 1344.2125659999438 1344.4749759999104 1344.8931479998864 1344.9823819999583 1345.6125900000334 1346.1605230001733 1346.2417399999686 1346.4872240000404 1347.1661380003206 1347.6786710000597 1348.184855000116 1348.444906000048 1350.6145430002362 1350.7060150001198 1351.3040370000526 1351.944540000055 1352.1774499998428 1352.2104090000503 1352.8186039999127 1353.629803000018 1353.8522949996404 1354.0937510002404 1354.1896570003591 1354.4582530003972 1355.181112000253 1355.2592779998668 1355.5449630003422 1356.8167730001733 1357.530071000103 1358.9375419998541 1359.1516120000742 1360.658773000352 1360.8545339996926 1361.1781419999897 1362.2740480001085 1362.6986090000719 1363.0309659997001 1367.3887129998766 1369.1678879996762 1370.061321000103 1370.0986740002409 1370.2190350000747 1370.3493660003878 1370.7631439999677 1371.1536460001953 1371.3058279999532 1371.595255999826 1374.7759610000066 1375.5087889996357 1376.0835779998451 1376.134603000246 1376.8859050003812 1378.3181570000015 1378.5100510003977 1378.6843270002864 1378.6903490000404 1378.7962239999324 1379.163453000132 1379.6154789999127 1380.8787850001827 1382.4403490000404 1384.263998000417 1385.555378999561 1386.041830000002 1386.7186280000024 1387.382569000125 1388.6063649998978 1388.7420250000432 1391.864909000229 1391.981322999578 1392.509603000246 1394.4863690002821 1395.8575450000353 1396.253947999794 1400.3068050001748 1402.7574869999662 1403.4190270002 1403.8131519998424 1410.729493000079 1410.9680590000935 1414.0898850001395 1419.3115250002593 1420.1145430002362 1422.9622810003348 1430.6570240003057 1434.1453860001639 1434.1453860001639 1439.2571620000526 1440.6207280000672 1440.6207280000672 1440.7638360001147 1449.269614000339 1449.3404950001277 1460.9886490004137 1463.28202399984 1478.1290700002573
Open search router TTI Load Search Options Baseline
Mean: 140.734 ms
Stdev: 6.030 ms (4.3%)
Runs: 125.53837099997327 129.27937800018117 130.49422200024128 131.3161619999446 132.47294100001454 133.1740319998935 133.71093799965456 134.1799320001155 134.29178899992257 134.94189499970526 135.33565300004557 135.76875799987465 136.20564799988642 136.46293100016192 136.88439899962395 136.89298500027508 136.9357500001788 137.04471900034696 137.97953299991786 138.05594899971038 138.53523699985817 138.60620100004598 138.6579189999029 138.7666429998353 138.83911100029945 138.98327599978074 139.09468600014225 139.21512900013477 140.31392400013283 140.3278810000047 141.09338299976662 141.24438499985263 141.37658699974418 141.45780400000513 141.84948700014502 142.7699789996259 142.89302599988878 143.32743299985304 143.4237870001234 143.72945099975914 143.76822900027037 144.0201419997029 144.3420009999536 144.42158999992535 144.67110200040042 145.59362800000235 145.80220499960706 146.19702199986205 146.33227600017563 146.340739000123 147.16752099990845 147.29569499986246 147.76761899981648 147.88277200004086 149.33886700030416 149.9635820002295 150.37402400001884 153.78047700040042 156.7595629999414

Current
Mean: 141.782 ms
Stdev: 7.038 ms (5.0%)
Runs: 126.375 126.84765699971467 127.25850400002673 127.6294760000892 127.92789799999446 130.5734450002201 133.30521599994972 133.3835859997198 134.67814100021496 134.9045000001788 135.53373200027272 136.10990400006995 136.93705300008878 137.15274999989197 137.28499400010332 137.70153800025582 138.1832279996015 138.42521200003102 138.76997900009155 140.31510500004515 140.79398599965498 140.92671700008214 141.2354739997536 141.42684000032023 141.6202799999155 141.6279710000381 141.7041429998353 141.9841310000047 142.19649200001732 142.60864199977368 142.7649340000935 143.02697800006717 143.0622969996184 143.27148400014266 143.584146999754 143.70300300000235 144.1422530002892 144.14705500006676 144.7149249999784 144.72814900008962 144.91019700001925 145.02148499991745 145.54675300000235 146.15311700012535 146.18912799982354 146.58483899990097 147.16776499990374 147.2900390001014 147.5376799996011 147.74507699999958 148.06925400020555 149.20369499968365 150.02539000008255 150.55635599978268 151.23990799998865 151.4142249999568 153.37190699996427 156.9221189999953 157.5946049997583
Open search router TTI (CPU) Baseline
Mean: 146.644 %
Stdev: 3.799 % (2.6%)
Runs: 139.16315911335695 139.63495830369183 141.04232799806985 141.06523631533406 141.5021411427297 141.70324057802972 143.14098670013928 143.16242380047996 143.16787582275097 143.1863314856184 143.34247178841125 143.357349817744 143.436958148995 143.80032774506344 143.88282931463579 143.90268951474766 144.111284366068 144.36410924120858 144.4258844851896 144.43524315094007 144.44316556299827 144.56639077326838 144.65178038793704 144.96163684838697 145.0254927143182 145.3820885833751 145.60392813674318 145.6382166158742 145.80591619416955 146.1342193667171 146.18768031698596 146.24941311570373 146.37538110125942 146.77083598086432 146.85073281508443 147.1126774192991 147.11451235777207 147.64687096395454 148.02672950842154 148.048975570062 148.1808399252751 148.3306471723464 148.68349031203232 148.73739668723584 149.08770801001623 149.16475241968374 149.47109076057342 149.69314312158136 149.9443392067758 150.68291779486526 150.79231976005946 151.19152106747632 151.19587139089944 151.54615445632305 151.6630320201571 151.8974276141258 153.45444217276884 153.71841862848473 155.98031735392937 156.8231671756992

Current
Mean: 145.679 %
Stdev: 3.422 % (2.3%)
Runs: 138.7234554831434 139.21299701315394 139.767913706615 139.8154970463382 140.18478783855534 140.57303414824804 140.6438002784328 140.87544174640385 141.15140476901863 141.31645537874485 142.06483961414665 142.4392973898906 142.51672248708746 142.54341689688803 142.58388412732634 143.9260392702605 144.07747330273264 144.161581095619 144.1878373889681 144.25175947463936 144.44280975946793 144.73221402317802 144.95466468535238 145.41089160774106 145.71328669313226 145.8133164398699 146.16689065164744 146.40255107420657 146.4451934237126 146.50180805409482 146.60343442847505 146.6757809179489 146.78098699267653 146.84348746885303 147.0081792239317 147.1434765381699 147.28784100846593 147.30117671578952 147.34184892408243 147.3516323473213 147.35620079978295 147.4764357848258 147.67830252872056 147.9054850799698 147.98710620004482 148.07832635539256 148.19249412099148 148.65818387856805 148.84767439119273 148.85379698999114 149.01877589696 149.29133069472545 150.15043156844402 150.45478729783304 150.99232946432244 151.1873222837367 151.68720511580085 153.6112582679469

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Performance Comparison Report 📊 (7/12)

Meaningless Changes To Duration (6/11)

Show entries
Name Duration
App start time nativeLaunchEnd_To_appCreationStart 77.650 ms → 78.193 ms (+0.543 ms, +0.7%)
App start time nativeLaunch 24.298 ms → 24.328 ms (+0.029 ms, ±0.0%)
App start time appCreation 73.150 ms → 72.500 ms (-0.650 ms, -0.9%)
App start time appCreationEnd_To_contentAppeared 496.414 ms → 507.967 ms (+11.553 ms, +2.3%)
App start time runJsBundle 312.983 ms → 318.350 ms (+5.367 ms, +1.7%)
App start time regularAppStart 0.020 ms → 0.020 ms (-0.001 ms, -3.4%)
App start time TTI 1708.746 ms → 1740.860 ms (+32.113 ms, +1.9%)
App start time (CPU) 148.668 % → 147.348 % (-1.320 %, -0.9%)
App start time (FPS) 59.829 FPS → 60.000 FPS (+0.171 FPS, ±0.0%)
App start time (RAM) 399.280 MB → 393.632 MB (-5.648 MB, -1.4%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 25.813 % → 25.837 % (+0.024 %, ±0.0%)
Open search router TTI Open Search Router TTI 1272.770 ms → 1291.596 ms (+18.826 ms, +1.5%)
Open search router TTI Load Search Options 140.734 ms → 141.782 ms (+1.048 ms, +0.7%)
Open search router TTI (CPU) 146.644 % → 145.679 % (-0.966 %, -0.7%)
Open search router TTI (FPS) 60.000 FPS → 60.000 FPS
Open search router TTI (RAM) 414.545 MB → 415.388 MB (+0.843 MB, ±0.0%)
Open search router TTI (CPU/JS) 0.000 % → 0.000 %
Open search router TTI (CPU/UI) 26.045 % → 25.907 % (-0.138 %, -0.5%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 490.536 ms → 487.494 ms (-3.042 ms, -0.6%)
Report typing (CPU) 96.529 % → 96.359 % (-0.169 %, ±0.0%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 477.306 MB → 476.556 MB (-0.750 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 20.788 % → 20.857 % (+0.069 %, ±0.0%)
Chat opening Chat TTI 750.723 ms → 736.230 ms (-14.493 ms, -1.9%)
Chat opening (CPU) 159.535 % → 161.574 % (+2.039 %, +1.3%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 400.850 MB → 401.009 MB (+0.159 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 33.053 % → 32.927 % (-0.126 %, ±0.0%)
Money request - Open Manual Tracking 138.937 ms → 141.846 ms (+2.909 ms, +2.1%)
Money request - Open Contacts 229.244 ms → 236.505 ms (+7.261 ms, +3.2%)
Money request - Open Create 139.404 ms → 140.846 ms (+1.442 ms, +1.0%)
Money request (CPU) 178.343 % → 179.214 % (+0.872 %, ±0.0%)
Money request (FPS) 59.183 FPS → 59.026 FPS (-0.157 FPS, ±0.0%)
Money request (RAM) 469.302 MB → 471.845 MB (+2.543 MB, +0.5%)
Money request (CPU/JS) 0.000 % → 0.000 %
Money request (CPU/UI) 44.443 % → 45.117 % (+0.673 %, +1.5%)
Show details
Name Duration
Open search router TTI (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Open search router TTI (RAM) Baseline
Mean: 414.545 MB
Stdev: 4.833 MB (1.2%)
Runs: 402.9140625 404.6515625 407.4700520833333 407.5546875 408.119140625 408.27109375 408.8020833333333 409.684375 410.5859375 410.85546875 411.2239583333333 411.3953125 411.515625 411.619140625 411.63203125 411.7838541666667 411.8587239583333 411.940625 411.9498697916667 412.0358072916667 412.3255208333333 412.32734375 412.38125 412.412109375 412.8626302083333 412.90234375 412.9140625 413.10859375 413.3177083333333 413.392578125 413.5403645833333 413.71796875 413.9798177083333 414.1109375 414.2669270833333 414.37734375 414.80078125 415.24140625 415.9290364583333 416.408203125 416.9251302083333 417.2467447916667 417.253125 418.30234375 418.400390625 418.9270833333333 419.14609375 419.29921875 419.318359375 420.0227864583333 420.9244791666667 421.11484375 421.30078125 422.4049479166667 422.5481770833333 422.7296875 423.784375 423.990625 424.3216145833333

Current
Mean: 415.388 MB
Stdev: 4.867 MB (1.2%)
Runs: 404.103515625 407.59609375 408.4078125 408.471875 408.6373697916667 408.8294270833333 409.0904947916667 409.716796875 409.9036458333333 409.9225260416667 410.4765625 410.5436197916667 410.79765625 410.8893229166667 410.927734375 411.0006510416667 412.0110677083333 412.1421875 412.5234375 412.6966145833333 412.7005208333333 412.90703125 413.23984375 414.0852864583333 414.0911458333333 414.23828125 414.6516927083333 415.2102864583333 415.4524739583333 415.7115885416667 415.7662760416667 415.878125 416.2102864583333 416.690625 416.8296875 417.07578125 417.1140625 417.1764322916667 417.40625 417.60390625 418.2473958333333 418.4036458333333 418.89375 419.20234375 419.2376302083333 419.2923177083333 419.455078125 419.57265625 420.2467447916667 420.3078125 421.21171875 422.0442708333333 422.20234375 422.3098958333333 422.3515625 422.779296875 423.76796875 424.1061197916667 425.5299479166667
Open search router TTI (CPU/JS) Baseline
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

Current
Mean: 0.000 %
Stdev: 0.000 % (NaN%)
Runs: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Performance Comparison Report 📊 (8/12)

Meaningless Changes To Duration (7/11)

Show entries
Name Duration
App start time nativeLaunchEnd_To_appCreationStart 77.650 ms → 78.193 ms (+0.543 ms, +0.7%)
App start time nativeLaunch 24.298 ms → 24.328 ms (+0.029 ms, ±0.0%)
App start time appCreation 73.150 ms → 72.500 ms (-0.650 ms, -0.9%)
App start time appCreationEnd_To_contentAppeared 496.414 ms → 507.967 ms (+11.553 ms, +2.3%)
App start time runJsBundle 312.983 ms → 318.350 ms (+5.367 ms, +1.7%)
App start time regularAppStart 0.020 ms → 0.020 ms (-0.001 ms, -3.4%)
App start time TTI 1708.746 ms → 1740.860 ms (+32.113 ms, +1.9%)
App start time (CPU) 148.668 % → 147.348 % (-1.320 %, -0.9%)
App start time (FPS) 59.829 FPS → 60.000 FPS (+0.171 FPS, ±0.0%)
App start time (RAM) 399.280 MB → 393.632 MB (-5.648 MB, -1.4%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 25.813 % → 25.837 % (+0.024 %, ±0.0%)
Open search router TTI Open Search Router TTI 1272.770 ms → 1291.596 ms (+18.826 ms, +1.5%)
Open search router TTI Load Search Options 140.734 ms → 141.782 ms (+1.048 ms, +0.7%)
Open search router TTI (CPU) 146.644 % → 145.679 % (-0.966 %, -0.7%)
Open search router TTI (FPS) 60.000 FPS → 60.000 FPS
Open search router TTI (RAM) 414.545 MB → 415.388 MB (+0.843 MB, ±0.0%)
Open search router TTI (CPU/JS) 0.000 % → 0.000 %
Open search router TTI (CPU/UI) 26.045 % → 25.907 % (-0.138 %, -0.5%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 490.536 ms → 487.494 ms (-3.042 ms, -0.6%)
Report typing (CPU) 96.529 % → 96.359 % (-0.169 %, ±0.0%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 477.306 MB → 476.556 MB (-0.750 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 20.788 % → 20.857 % (+0.069 %, ±0.0%)
Chat opening Chat TTI 750.723 ms → 736.230 ms (-14.493 ms, -1.9%)
Chat opening (CPU) 159.535 % → 161.574 % (+2.039 %, +1.3%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 400.850 MB → 401.009 MB (+0.159 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 33.053 % → 32.927 % (-0.126 %, ±0.0%)
Money request - Open Manual Tracking 138.937 ms → 141.846 ms (+2.909 ms, +2.1%)
Money request - Open Contacts 229.244 ms → 236.505 ms (+7.261 ms, +3.2%)
Money request - Open Create 139.404 ms → 140.846 ms (+1.442 ms, +1.0%)
Money request (CPU) 178.343 % → 179.214 % (+0.872 %, ±0.0%)
Money request (FPS) 59.183 FPS → 59.026 FPS (-0.157 FPS, ±0.0%)
Money request (RAM) 469.302 MB → 471.845 MB (+2.543 MB, +0.5%)
Money request (CPU/JS) 0.000 % → 0.000 %
Money request (CPU/UI) 44.443 % → 45.117 % (+0.673 %, +1.5%)
Show details
Name Duration
Open search router TTI (CPU/UI) Baseline
Mean: 26.045 %
Stdev: 1.044 % (4.0%)
Runs: 23.7 23.9 24 24.3 24.3 24.5 24.6 24.6 24.8 24.9 25 25 25.1 25.1 25.3 25.4 25.6 25.6 25.7 25.9 25.9 25.9 25.9 26 26 26 26 26 26.1 26.2 26.2 26.3 26.3 26.3 26.3 26.3 26.4 26.6 26.6 26.7 26.7 26.7 26.8 26.9 26.9 26.9 26.9 26.9 27.1 27.1 27.1 27.3 27.3 27.4 27.4 27.9 28 28

Current
Mean: 25.907 %
Stdev: 1.003 % (3.9%)
Runs: 23.8 24.2 24.3 24.8 24.8 24.8 24.8 24.8 24.9 24.9 24.9 24.9 25 25.3 25.3 25.3 25.3 25.3 25.4 25.5 25.5 25.5 25.5 25.5 25.6 25.6 25.6 25.7 25.7 25.8 25.8 25.9 25.9 25.9 26 26.1 26.3 26.3 26.3 26.3 26.4 26.6 26.6 26.6 26.6 26.6 26.7 27 27.1 27.1 27.1 27.4 27.6 27.8 27.9 28.2 28.3
Report typing Composer typing rerender count Baseline
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1.000 renders
Stdev: 0.000 renders (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1 1
Report typing Message sent Baseline
Mean: 490.536 ms
Stdev: 31.566 ms (6.4%)
Runs: 437.7513020001352 438.8619389999658 439.66984099987894 442.50268599996343 446.08695500018075 448.6018880000338 449.1984459999949 455.24772199988365 457.57572399964556 458.22709200019017 458.5417070002295 460.15934300003573 460.3496100003831 461.4254560000263 464.2394619998522 464.2613119999878 464.52498300001025 464.8370369998738 465.1643070001155 467.81087299995124 468.32226599985734 468.7839770000428 470.2675779997371 471.3669029995799 471.54183000000194 474.7383630000986 481.53393599996343 487.8947749999352 488.31677300017327 488.64672899991274 490.7014159997925 494.6423339997418 495.95275900000706 497.0393880000338 500.606364000123 500.6727289999835 502.4659020002 504.1743979998864 509.08040399989113 510.6039630002342 515.7469489998184 515.8515220000409 516.7257489999756 517.9302580002695 518.1504719997756 520.8344319998287 524.5500090001151 525.1274420004338 525.6656909999438 526.8300780002028 527.5637620002963 527.6239420003258 527.7211919999681 528.1464439998381 529.5428880001418 529.8669429998845 533.7934159999713 535.9106450001709 546.7072350000963 555.4577639997005

Current
Mean: 487.494 ms
Stdev: 30.114 ms (6.2%)
Runs: 430.52360100019723 437.5793869998306 440.27608199976385 441.9355470002629 445.68672699993476 449.2012120001018 449.4665939998813 450.619262999855 452.5305590000935 454.550904000178 456.753337000031 457.8537190002389 458.4214280000888 458.6733809998259 459.9963389998302 460.7236739997752 460.8668220001273 461.03922599973157 464.05265399999917 464.59041399974376 474.0715330000967 474.88435899978504 475.18347200006247 476.9217940000817 477.25952199986205 479.04972400004044 479.12007599975914 480.0590820000507 487.7647299999371 490.3629970001057 490.5757649997249 494.4616700001061 494.9219570001587 495.44759200001135 496.5375580000691 498.81384300021455 499.14473500009626 499.1857909997925 499.7734380001202 503.3211260000244 503.60815500002354 505.68306499999017 505.99454799992964 507.39217199990526 507.6158039998263 512.1553960000165 516.7549240002409 516.8416749997996 517.5865879999474 520.125 522.5054120002314 524.8315840000287 525.0091559998691 525.0266929999925 525.4202879997902 528.3565269997343 529.4569089999422 531.909708999563 537.3988450001925 563.7482099998742

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Performance Comparison Report 📊 (9/12)

Meaningless Changes To Duration (8/11)

Show entries
Name Duration
App start time nativeLaunchEnd_To_appCreationStart 77.650 ms → 78.193 ms (+0.543 ms, +0.7%)
App start time nativeLaunch 24.298 ms → 24.328 ms (+0.029 ms, ±0.0%)
App start time appCreation 73.150 ms → 72.500 ms (-0.650 ms, -0.9%)
App start time appCreationEnd_To_contentAppeared 496.414 ms → 507.967 ms (+11.553 ms, +2.3%)
App start time runJsBundle 312.983 ms → 318.350 ms (+5.367 ms, +1.7%)
App start time regularAppStart 0.020 ms → 0.020 ms (-0.001 ms, -3.4%)
App start time TTI 1708.746 ms → 1740.860 ms (+32.113 ms, +1.9%)
App start time (CPU) 148.668 % → 147.348 % (-1.320 %, -0.9%)
App start time (FPS) 59.829 FPS → 60.000 FPS (+0.171 FPS, ±0.0%)
App start time (RAM) 399.280 MB → 393.632 MB (-5.648 MB, -1.4%)
App start time (CPU/JS) 0.000 % → 0.000 %
App start time (CPU/UI) 25.813 % → 25.837 % (+0.024 %, ±0.0%)
Open search router TTI Open Search Router TTI 1272.770 ms → 1291.596 ms (+18.826 ms, +1.5%)
Open search router TTI Load Search Options 140.734 ms → 141.782 ms (+1.048 ms, +0.7%)
Open search router TTI (CPU) 146.644 % → 145.679 % (-0.966 %, -0.7%)
Open search router TTI (FPS) 60.000 FPS → 60.000 FPS
Open search router TTI (RAM) 414.545 MB → 415.388 MB (+0.843 MB, ±0.0%)
Open search router TTI (CPU/JS) 0.000 % → 0.000 %
Open search router TTI (CPU/UI) 26.045 % → 25.907 % (-0.138 %, -0.5%)
Report typing Composer typing rerender count 1.000 renders → 1.000 renders
Report typing Message sent 490.536 ms → 487.494 ms (-3.042 ms, -0.6%)
Report typing (CPU) 96.529 % → 96.359 % (-0.169 %, ±0.0%)
Report typing (FPS) 60.000 FPS → 60.000 FPS
Report typing (RAM) 477.306 MB → 476.556 MB (-0.750 MB, ±0.0%)
Report typing (CPU/JS) 0.000 % → 0.000 %
Report typing (CPU/UI) 20.788 % → 20.857 % (+0.069 %, ±0.0%)
Chat opening Chat TTI 750.723 ms → 736.230 ms (-14.493 ms, -1.9%)
Chat opening (CPU) 159.535 % → 161.574 % (+2.039 %, +1.3%)
Chat opening (FPS) 60.000 FPS → 60.000 FPS
Chat opening (RAM) 400.850 MB → 401.009 MB (+0.159 MB, ±0.0%)
Chat opening (CPU/JS) 0.000 % → 0.000 %
Chat opening (CPU/UI) 33.053 % → 32.927 % (-0.126 %, ±0.0%)
Money request - Open Manual Tracking 138.937 ms → 141.846 ms (+2.909 ms, +2.1%)
Money request - Open Contacts 229.244 ms → 236.505 ms (+7.261 ms, +3.2%)
Money request - Open Create 139.404 ms → 140.846 ms (+1.442 ms, +1.0%)
Money request (CPU) 178.343 % → 179.214 % (+0.872 %, ±0.0%)
Money request (FPS) 59.183 FPS → 59.026 FPS (-0.157 FPS, ±0.0%)
Money request (RAM) 469.302 MB → 471.845 MB (+2.543 MB, +0.5%)
Money request (CPU/JS) 0.000 % → 0.000 %
Money request (CPU/UI) 44.443 % → 45.117 % (+0.673 %, +1.5%)
Show details
Name Duration
Report typing (CPU) Baseline
Mean: 96.529 %
Stdev: 5.497 % (5.7%)
Runs: 88.16568779446666 88.29387157482124 88.44108375942136 88.88064880060033 89.07353294588694 91.06548705364678 91.09872467240093 91.15367204321598 91.43986304315939 91.44397682376798 91.49664804463889 91.64548715602317 91.65258073430023 91.81150105621062 91.92700745836488 92.31774510177415 92.32765258470481 92.84387066469533 92.9496057229332 93.12320195891716 93.21679630708911 93.3110289189359 93.57895907898305 93.78877014892963 93.90540004245139 94.11063186335191 94.16657766767395 95.05150449157168 95.07917844766378 95.09706255937148 95.40954993080062 95.6682345476236 95.69476090139196 96.1576315779174 96.76916645410951 96.86954308377805 96.99505035246581 98.19854415611827 98.5763723395137 98.59282391653284 98.7784637621943 99.15065810073565 100.37423607232581 100.67371921182152 100.77384520467834 100.98946180587299 101.27602677971566 102.14739907454525 102.30961220955439 102.42881657227439 102.7797993642435 102.9476647528745 102.95631851714218 102.96974318922337 103.15547182197686 103.54438600675513 103.62069767777676 104.31329559952569 111.25290126520734 113.88899961812088

Current
Mean: 96.359 %
Stdev: 4.559 % (4.7%)
Runs: 89.24864083112931 90.01844075526273 90.13494244562753 90.24044068059922 90.287003314979 90.48306351361745 91.23428022809381 91.29159725920304 91.43121456806504 91.49582851487293 91.95415987419894 91.9774644539061 92.0837913944776 92.14749878215783 92.44722539952728 93.00461831232882 93.0635959429348 93.25139964459287 93.5451128394519 93.6184109125483 94.11098095048418 94.24608653630308 94.3520048588097 94.5172532546445 94.5628472375225 94.62922202267593 94.70454277471048 94.72666043636809 94.75745647625808 95.17649028269422 95.18013646672102 95.7220188363868 95.91441520470163 96.84290717430113 97.03138799845529 97.04446507477468 97.06781908000441 97.1079541849016 98.10278720024752 99.28952893225646 99.41218974603102 100.00300499520962 100.30530297600625 100.34255929455126 101.15340558004122 101.16894558087264 101.41177518053127 102.05544013489408 102.46942306256182 102.48325228281489 102.6212065436104 102.84512088439307 102.86666876193581 102.95085711828074 103.02332012652123 104.66814658537525 104.83487658245241 106.18001536429747
Report typing (FPS) Baseline
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60

Current
Mean: 60.000 FPS
Stdev: 0.000 FPS (0.0%)
Runs: 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60 60
Report typing (RAM) Baseline
Mean: 477.306 MB
Stdev: 5.750 MB (1.2%)
Runs: 464.24076704545456 468.7126953125 469.05557528409093 469.9007457386364 470.38363486842104 470.74165482954544 470.8365234375 471.28018465909093 471.66015625 472.26065340909093 472.3042763157895 472.39133522727275 472.77734375 472.84354440789474 472.8865411931818 473.20435855263156 473.69797585227275 473.72585227272725 473.7750355113636 474.0740411931818 474.28817471590907 474.75088778409093 475.23508522727275 475.2713068181818 475.40926846590907 475.515625 475.64790482954544 475.65571732954544 475.8881578947368 476.2434895833333 476.248046875 476.31796875 476.57901278409093 477.2439630681818 477.447265625 477.58861019736844 477.7504111842105 478.1087582236842 479.33370535714283 479.5901988636364 479.7935546875 480.07831101190476 480.28104440789474 480.7001488095238 482.0004111842105 482.41673519736844 482.97265625 483.00123355263156 483.1892578125 483.4354538690476 484.11772017045456 485.09126420454544 485.12357954545456 485.19058388157896 485.6605674342105 486.2783203125 486.4488075657895 491.03104440789474 493.36762152777777

Current
Mean: 476.556 MB
Stdev: 5.005 MB (1.1%)
Runs: 467.2321134868421 467.6879111842105 467.8743832236842 468.32791940789474 469.9505859375 470.32113486842104 470.6599786931818 471.0111328125 471.5250822368421 471.66122159090907 472.36434659090907 472.51242897727275 472.65340909090907 473.03036221590907 473.25514914772725 473.284375 473.57546164772725 473.66796875 474.046875 474.3109375 474.3707386363636 474.427734375 474.82102272727275 474.8513671875 474.92507102272725 475.34457236842104 476.1408025568182 476.1857244318182 476.43270596590907 476.4689453125 476.67524857954544 476.70365767045456 476.98526278409093 477.08314732142856 477.3806640625 477.5548650568182 477.73721590909093 478.1807154605263 478.68607954545456 478.8345703125 478.88583096590907 479.20926339285717 479.79276315789474 480.076171875 480.219921875 480.3149671052632 480.39329769736844 482.218359375 482.5408203125 482.61513157894734 483.0709635416667 483.99095394736844 484.29111842105266 484.8349095394737 485.3310032894737 488.1731770833333 488.9868421052632

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.42-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.43-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@github-actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.1.44-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

Comment on lines +18 to +20
const filtered = normalizedSearchQuery.length ? data.filter((item) => filterData(item, normalizedSearchQuery)) : data;
const sorted = sortData(filtered);
setResult(sorted);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The company cards array was sorted in place, so React didn't re-render because the reference didn't change. See issue #62202 for details. Fixed in PR #65806.

[allSubRates, selectedPerDiem, canSelectMultiple, styles.flex2, styles.alignItemsStart, styles.textSupporting, styles.label, styles.pl2, styles.alignSelfEnd],
);

const filterRate = useCallback((rate: PolicyOption, searchInput: string) => !!rate.text?.toLowerCase().includes(searchInput), []);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We forgot to run the filter on the subrate name, which caused #74879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DeployBlockerCash This issue or pull request should block deployment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants