fix: cards are not sorted after page refresh by linhvovan29546 · Pull Request #65806 · Expensify/App

linhvovan29546 · 2025-07-10T03:56:52Z

Explanation of Change

This PR applies a shallow copy to the data to fix the issue where the sorted data does not re-render when using setState.
For more detail please check the proposal below

Fixed Issues

$ #62202
PROPOSAL: #62202 (comment)

Tests

Go to staging.new.expensify.com
Log in to applausetester+ccardfeed@applause.expensifail.com
Go to workspace settings > Company card.
Change to Visa cards feed.
Click Assign card.
Assign a few users randomly with card (do not assign the users alphabetically, but randomly).
Refresh the page
Verify that the assigned cards will be arranged alphabetically by member's name or primary login.

Note: If you don’t have access to the account above, you will need to mock the card local.

Verify that no errors appear in the JS console

Offline tests

Same as tests above

QA Steps

Same as tests above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-07-10.at.10.47.49.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2025-07-10.at.10.42.52.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-10.at.10.30.23.mov

MacOS: Desktop

Screen.Recording.2025-07-10.at.10.39.01.mov

melvin-bot · 2025-07-10T04:11:42Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

QichenZhu · 2025-07-11T04:45:23Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
https://expensify.slack.com/archives/C01GTK53T8Q/p1751286039132129
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
Can't test because of an existing issue.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
N/A. This is due to how React's rendering works. While unit tests are technically possible, it's not a good use case.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-native.mp4

Android: mWeb Chrome

android-web.mp4

iOS: HybridApp

ios-native.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

mac-web.mov

MacOS: Desktop

mac-desktop.mov

QichenZhu · 2025-07-11T05:05:11Z

@linhvovan29546, I noticed the card order shifts briefly when the page loads. Maybe it's because I'm using fake data. Can you check if it happens on your side?

Screen.Recording.2025-07-11.at.17.03.50.mov

QichenZhu · 2025-07-11T05:06:46Z

NAB: The card list is empty when you access it through a link while logged out. This already exists on staging.

staging-bug.mov

linhvovan29546 · 2025-07-11T05:11:04Z

I noticed the card order shifts briefly when the page loads. Maybe it's because I'm using fake data. Can you check if it happens on your side?

I'm don't see briefly in my side(i'm also using fake data, which initially displays an empty page), i think that may because the sort inside useEffect so that might a briefly delay, do you have test account for that (I think the C+ team has a test account)

QichenZhu · 2025-07-11T05:29:55Z

@linhvovan29546, thanks for the confirming! I don't have one yet. I've asked the internal team for help.

QichenZhu

Confirmed order shifting happens with real data too. Otherwise looks good.

If @AndrewGable or QA think it's an issue, I can take it and raise a follow-up PR since @linhvovan29546 can't reproduce it.

linhvovan29546 · 2025-07-12T00:02:07Z

@QichenZhu Perhaps my first alternative solution will resolve this issue?

QichenZhu · 2025-07-14T06:24:45Z

@linhvovan29546, there's a startTransition() inside the effect, so the sort is meant to be deferred. Putting it in useState() goes against that intention.

App/src/hooks/useSearchResults.ts

Lines 16 to 17 in 9332bd1

    
           useEffect(() => { 
        
               startTransition(() => {

QichenZhu · 2025-07-15T14:06:10Z

@AndrewGable, I approved the PR but have a concern in this comment. Could you take a look when you have a moment? Thanks!

AndrewGable · 2025-07-16T17:39:36Z

Seems like a bug for sure. I am not sure how testing data would cause this?

linhvovan29546 · 2025-07-17T08:16:05Z

Putting it in useState() goes against that intention.

I'm not sure if we intended that case. I think we use startTransition for the scenario when searching for data.

QichenZhu · 2025-07-17T13:28:30Z

Seems like a bug for sure.

Thanks for confirming. We'll work on a fix.

I am not sure how testing data would cause this?

It turns out this isn't caused by the testing data.

QichenZhu · 2025-07-17T15:19:27Z

Putting it in useState() goes against that intention.

I'm not sure if we intended that case. I think we use startTransition for the scenario when searching for data.

Thanks @linhvovan29546, that makes sense. But only sorting inside useState()'s initializer feels a bit odd. Logically we should also do filtering there, though it doesn't make much difference for this issue.

linhvovan29546 · 2025-07-17T15:27:14Z

I think sorting inside useState() should be sufficient. There's no need to filter here since initially, we don't have a search value. Does this approach resolve your issue?

QichenZhu · 2025-07-17T15:36:40Z

Yes, it does. Let's do it.

linhvovan29546 · 2025-07-17T15:40:43Z

Yes, it does. Let's do it.

This hook is used in many places, so do you think we should add the sort to the initial state based on the flag? I think that would be safer.

Then I’ll provide an update tomorrow

QichenZhu · 2025-07-17T15:46:33Z

This hook is used in many places, so do you think we should add the sort to the initial state based on the flag? I think that would be safer.

Then I’ll provide an update tomorrow

Sounds good!

linhvovan29546 · 2025-07-18T01:34:45Z

@QichenZhu This is ready for review!

QichenZhu

Re-reviewed and retested. Both the original issue and this issue are fixed.

QichenZhu · 2025-07-18T12:40:43Z

@AndrewGable, could you take another look when you have a chance?

OSBotify · 2025-07-22T22:01:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-23T14:58:58Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.1.85-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-25T07:16:40Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.85-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

abdulrahuman5196 · 2025-11-04T12:09:30Z

src/hooks/useSearchResults.ts

+) {
    const [inputValue, setInputValue] = useState('');
-    const [result, setResult] = useState(data);
+    const [result, setResult] = useState(() => (shouldSortInitialData ? sortData(data) : data));


we should have fixed at other places as well on similar issue. Ref - #70659 (comment)

fix: cards are not sorted after page refresh

25db559

linhvovan29546 marked this pull request as ready for review July 10, 2025 04:11

linhvovan29546 requested a review from a team as a code owner July 10, 2025 04:11

melvin-bot bot requested a review from QichenZhu July 10, 2025 04:11

melvin-bot bot removed the request for review from a team July 10, 2025 04:11

chore: add comment to explain

fd3420a

QichenZhu approved these changes Jul 11, 2025

View reviewed changes

melvin-bot bot requested a review from AndrewGable July 11, 2025 17:50

linhvovan29546 added 2 commits July 18, 2025 07:45

Merge branch 'main' into fix/62202-cards-not-arranged-on-refresh-page

6f5842f

chore: add flag to sort initial data

13f89bd

QichenZhu approved these changes Jul 18, 2025

View reviewed changes

AndrewGable approved these changes Jul 22, 2025

View reviewed changes

AndrewGable merged commit 474cc0a into Expensify:main Jul 22, 2025
19 checks passed

linhvovan29546 deleted the fix/62202-cards-not-arranged-on-refresh-page branch July 22, 2025 23:52

github-actions bot mentioned this pull request Jul 23, 2025

Deploy Checklist: New Expensify 2025-07-23 #66960

Closed

74 tasks

BlameGPT mentioned this pull request Jul 24, 2025

[Due for payment 2025-08-15] [$250] Group - Group chat remains displayed on "Search" on member´s side after being removed. #67026

Closed

8 tasks

nkdengineer mentioned this pull request Jul 24, 2025

fix: company card list order changes everytime while assigning card #65233

Closed

51 tasks

melvin-bot bot mentioned this pull request Jul 25, 2025

[Due for payment 2025-08-01] [$250] Company card - Assigned cards are not arranged alphabetically by member's name #62202

Closed

8 tasks

QichenZhu mentioned this pull request Aug 1, 2025

Fix: add search bar to lists with items above 15 #60488

Merged

50 tasks

daledah mentioned this pull request Sep 16, 2025

[Due for payment 2025-11-04] [$250] Workspace Order Briefly Changes or flickers #70659

Closed

16 tasks

abdulrahuman5196 reviewed Nov 4, 2025

View reviewed changes

Conversation

linhvovan29546 commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 10, 2025

Uh oh!

QichenZhu commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu commented Jul 11, 2025

Uh oh!

QichenZhu commented Jul 11, 2025

Uh oh!

linhvovan29546 commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QichenZhu commented Jul 11, 2025

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 commented Jul 12, 2025

Uh oh!

QichenZhu commented Jul 14, 2025

Uh oh!

QichenZhu commented Jul 15, 2025

Uh oh!

AndrewGable commented Jul 16, 2025

Uh oh!

linhvovan29546 commented Jul 17, 2025

Uh oh!

QichenZhu commented Jul 17, 2025

Uh oh!

QichenZhu commented Jul 17, 2025

Uh oh!

linhvovan29546 commented Jul 17, 2025

Uh oh!

QichenZhu commented Jul 17, 2025

Uh oh!

linhvovan29546 commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

QichenZhu commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 commented Jul 18, 2025

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Jul 18, 2025

Uh oh!

Uh oh!

OSBotify commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 23, 2025

Uh oh!

github-actions bot commented Jul 25, 2025

Uh oh!

abdulrahuman5196 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

linhvovan29546 commented Jul 10, 2025 •

edited

Loading

QichenZhu commented Jul 11, 2025 •

edited

Loading

linhvovan29546 commented Jul 11, 2025 •

edited

Loading

linhvovan29546 commented Jul 17, 2025 •

edited

Loading

QichenZhu commented Jul 17, 2025 •

edited

Loading