[Due for payment 2025-07-25] [$250] Copilot - Error is shown after holding expense with a "Limited" Copilot account

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.72-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #64020
Email or phone of affected tester (no customers): applausetester+bg@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: macOS/chrome
App Component: Other

Action Performed:

Preconditions:
User A has unpaid expenses
User A has given a "Limited" Copilot access to User B

As User B

1. Log in with a "Limited" Copilot account
2. Switch account to user A
3. Go to any unpaid expense and hold the expense

Expected Result:

"Not so fast" message is displayed indicating that you are not able to perform this action before holding the expense

Actual Result:

Error is shown after finishing the Hold Expense flow

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6872120_1751085992589.Screen_Recording_2025-06-28_at_7.19.43_in_the_morning.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021940340724829893360
• Upwork Job ID: 1940340724829893360
• Last Price Increase: 2025-07-02
• Automatic offers:
• nkdengineer | Contributor | 107906914

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error is shown after finishing the Hold Expense flow

What is the root cause of that problem?

We don't show the showDelegateNoAccessModal when holding expense with a "Limited" Copilot account

App/src/components/MoneyReportHeader.tsx

Lines 781 to 788 in a8bf844

	onSelected: () => {
	if (!requestParentReportAction) {
	throw new Error('Parent action does not exist');
	}
	changeMoneyRequestHoldStatus(requestParentReportAction);
	},
	},

What changes do you think we should make in order to solve the problem?

We should call showDelegateNoAccessModal function to show the modal like we did with the unapprove action here

    if (isDelegateAccessRestricted) {
        showDelegateNoAccessModal();
        return;
    }

App/src/components/MoneyReportHeader.tsx

Lines 781 to 788 in a8bf844

	onSelected: () => {
	if (!requestParentReportAction) {
	throw new Error('Parent action does not exist');
	}
	changeMoneyRequestHoldStatus(requestParentReportAction);
	},
	},

App/src/components/MoneyReportHeader.tsx

Lines 755 to 759 in a8bf844

	onSelected: () => {
	if (isDelegateAccessRestricted) {
	showDelegateNoAccessModal();
	return;
	}

Note: We should do the same with the places where there is an action hold like here... and other actions that need to show the modal.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021940340724829893360

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)