Update delegate access modal to use context provider#64020
Conversation
|
@Gonals sorry for the noise, this isn't ready for review yet. |
…o use context provider
…DelegateAccessRestricted
|
ready for review @Gonals! |
|
This looks good to me. Do we want a C+ to get some extra testing, @NikkiWines? |
|
@Gonals I don't think we need it - but lemme know if you disagree! |
|
Requested C+ review for the checklist: https://expensify.slack.com/archives/C02NK2DQWUX/p1750187792564079 |
|
Taking over as C+ reviewer 👋 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-06-19.at.10.01.06.AM.movAndroid: mWeb ChromeScreen.Recording.2025-06-19.at.9.58.15.AM.moviOS: HybridAppScreen.Recording.2025-06-19.at.9.51.44.AM.moviOS: mWeb SafariScreen.Recording.2025-06-19.at.9.52.56.AM.movMacOS: Chrome / SafariScreen.Recording.2025-06-19.at.9.48.56.AM.movMacOS: DesktopScreen.Recording.2025-06-19.at.9.49.40.AM.mov |
|
@allgandalf updated! |
|
@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🎯 @allgandalf, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #64529. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.1.70-0 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀
|
3 similar comments
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.70-7 🚀
|
cc: @roryabraham as I noticed this when making those lock account changes
Explanation of Change
Just cleaning up some logic
Fixed Issues
$ N/A
PROPOSAL:
Tests
LimitedaccessPayaction by account A, like so:Screen.Recording.2025-06-12.at.18.06.55.mov
Screen.Recording.2025-06-12.at.18.09.39.mov
Screen.Recording.2025-06-12.at.18.16.44.mov
Offline tests
TBD
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-06-12.at.18.06.55.mov
Screen.Recording.2025-06-12.at.18.09.39.mov
Screen.Recording.2025-06-12.at.18.16.44.mov
MacOS: Desktop