Update TestDrive link for invited employees

[danielrvidal]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.78-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a - we're updating it in general
Email or phone of affected tester (no customers): n/a, this is live
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C01GTK53T8Q/p1752098749703439?thread_ts=1752075116.675999&cid=C01GTK53T8Q

Action Performed:

1. Invite a brand new account to a workspace
2. Sign-in to new.expensify.com as the invited user
3. Click on the + FAB
4. Click on the test drive menu item
5. Go to the Concierge DM
6. Click on the test drive task link
7. Go to the Reports page > Expenses
8. Click on the test drive link in the empty states of Expenses and Reports searches.

Expected Result:

For invited workspace members, we do not want the link their test drive to open the employee test drive to submit a receipt to their boss. We want it to open a test drive click through demo. Thus, for any user with "choice": "newDotSubmit" && "inviteType": "workspace" introSelected NVP attributes, we should update the “Take a test drive” links to this: https://expensify.navattic.com/35609gb.

Actual Result:

The links open the bottom-up submit a receipt test drive modal, which is redundant and kicks off a confusing flow for a user who's boss has already converted.

Workaround:

None.

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2025-07-09_11-59-56.mp4

View all open jobs on GitHub

Here's an example of the data in an introSelectedNVP for this type of user:

"introSelected": {
"choice": "newDotSubmit",
"inviteType": "workspace",
"isInviteOnboardingComplete": true,
"previousChoices": [
"newDotSubmit"
],
"submitExpense": "5476303235267591",
"viewTour": "7931557586768292"

Issue Owner

Current Issue Owner: @Ollyws

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update the TestDrive link for invited employees.

What is the root cause of that problem?

TestDrive link logic needs to be refactored to handle specific invite types.

What changes do you think we should make in order to solve the problem?

1. First, we need to add a new value WORKSPACE: 'workspace' to the onboardingInviteTypes object inside the CONST file (used as introSelected?.inviteType).

2. We can use the getNavatticURL function from @libs/TourUtils to retrieve the correct Navattic URL, provided it won’t cause any regressions (reference).
   We just need to update that function to return the correct URL based on the new condition. Specifically, extend the getNavatticURL function to accept an optional inviteType?: OnboardingInvite parameter and add the following condition:

   if (introSelected === CONST.ONBOARDING_CHOICES.SUBMIT && inviteType === CONST.ONBOARDING_INVITE_TYPES.WORKSPACE) {
       return employeeTourURL;
   }

3. In the following locations where we show the “Take a test drive” button:

• App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

  Lines 516 to 536 in def8188

  	interceptAnonymousUser(() => {
  	InteractionManager.runAfterInteractions(() => {
  	if (
  	introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM ||
  	introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER ||
  	introSelected?.choice === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE
  	) {
  	completeTestDriveTask(viewTourReport, viewTourReportID, isAnonymousUser());
  	Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
  	} else {
  	Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
  	}
  	});
  	}),
  	},
  	]
  	: []),
  	...(!isLoading && shouldShowNewWorkspaceButton
  	? [
  	{
  	displayInDefaultIconColor: true,

• App/src/pages/Search/EmptySearchView.tsx

  Lines 207 to 221 in 61dd158

  	const startTestDrive = () => {
  	InteractionManager.runAfterInteractions(() => {
  	if (
  	introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM ||
  	introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER ||
  	introSelected?.choice === CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE
  	) {
  	completeTestDriveTask(viewTourReport, viewTourReportID);
  	Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
  	} else {
  	Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
  	}
  	});
  	};

  We should add the following condition on top:

    if (introSelected?.choice === CONST.ONBOARDING_CHOICES.SUBMIT && introSelected?.inviteType === CONST.ONBOARDING_INVITE_TYPES.WORKSPACE) {
       completeTestDriveTask(viewTourReport, viewTourReportID) // optional in case we want to complete the test drive task before navigating, this way we ensure consistency with the existing flow
        getEnvironment().then((environment) => {
            const navatticURL = getNavatticURL(environment, introSelected?.choice, introSelected?.inviteType);
            openOldDotLink(navatticURL);
        });
        return;
    }

4. In the onboarding tasks logic (link), we should also handle this case as follows:

    testDriveURL: (() => {
        if (introSelected?.choice === CONST.ONBOARDING_CHOICES.SUBMIT && introSelected?.inviteType === CONST.ONBOARDING_INVITE_TYPES.WORKSPACE) {
            return getNavatticURL(environment, engagementChoice, introSelected?.inviteType);
        }
    
        return `${environmentURL}/${
            engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || engagementChoice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER
                ? ROUTES.TEST_DRIVE_DEMO_ROOT
                : ROUTES.TEST_DRIVE_MODAL_ROOT.route
        }`;
    })(),

5. also we should wait for the current related PR to be merged in order not to redo

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should create three test cases, one for each of the locations mentioned above, that test that the navigation is working as expected to the NavatticURL

• inside the EmptySearchViewTest
• FloatingActionButtonAndPopoverTests file that is being developed in this PR so we can wait for the current related PR to be merged in order not to redo the work
• ReportUtilsTest

What alternative solutions did you explore? (Optional)

If we don’t want to modify the existing getNavatticURL function because of potential regression here, we could create a custom helper function specifically for this new logic to determine the correct URL based on the environment.

[abzokhattab]

a small question: is there any action we need to do before navigating to the new link such as completing the test drive task ?
completeTestDriveTask(viewTourReport, viewTourReportID) if yes then i think we should call it before navigating