Update TestDrive link for invited employees by fabioh8010 · Pull Request #65900 · Expensify/App

fabioh8010 · 2025-07-10T18:49:13Z

Explanation of Change

I'm also doing a bit of refactor to remove Navattic leftovers in the code that are not being used anymore as we are switching to Storylane and the embedded demo experience.

Fixed Issues

$ #65797
PROPOSAL:

Tests

Prerequisite: Invite a brand new account to a workspace

Sign-in with the invited user.
Click on the + FAB.
Click the "Take a 2-minute test drive" option. Assert the Test Drive demo is shown with this content: https://expensify.navattic.com/35609gb.
Go to the Concierge DM.
Click the "test drive" link of the task. Assert the Test Drive demo is shown with this content: https://expensify.navattic.com/35609gb.
Go to the Reports tab > Expenses. Click the "Take a test drive" button and assert the Test Drive demo is shown with this content: https://expensify.navattic.com/35609gb.
Go to the Reports tab > Reports. Click the "Take a test drive" button and assert the Test Drive demo is shown with this content: https://expensify.navattic.com/35609gb.

Note: To facilitate tests, in my recordings I purposely changed the code to not hide the test drive buttons once I open the demo. For QA testing you will probably need to have a new invited account for each step in steps 5, 6, 7.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-07-11.at.18.09.16-compressed.mov

Android: mWeb Chrome

I couldn't record for this platform because Chrome is instantly crashing in my emulator.

iOS: Native

In my recording the demo URL isn't being displayed because of my local company certificate that mess with it.

Screen.Recording.2025-07-11.at.18.21.18-compressed.mov

iOS: mWeb Safari

In my recording the demo URL isn't being displayed because of my local company certificate that mess with it.

Screen.Recording.2025-07-11.at.18.23.19-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-11.at.18.24.50-compressed.mov

Screen.Recording.2025-07-11.at.18.25.53-compressed.mov

MacOS: Desktop

Screen.Recording.2025-07-11.at.18.29.13-compressed.mov

melvin-bot · 2025-07-11T17:36:34Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

fabioh8010 · 2025-07-11T17:36:50Z

Unit tests are flaky on main.

Ollyws · 2025-07-14T06:45:48Z

Reviewing this one now.

Ollyws · 2025-07-14T16:43:16Z

@fabioh8010 is the concierge link opening in the browser the expected behaviour?

Screen.Recording.2025-07-14.at.18.42.36.mov

fabioh8010 · 2025-07-14T17:33:52Z

@Ollyws Is this a account you created while testing my PR on dev, or you created in another environment? I'm asking because I noticed the open link is from staging, so if you created the account there first the task was created with the staging URL, so when testing in DEV this would happen with that account.

If you use an account that was created in DEV environment, this shouldn't happen while testing the PR.

Ollyws · 2025-07-14T22:45:46Z

Ah yeah that was the issue, thanks.

Ollyws · 2025-07-14T22:50:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: HybridApp

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

MacOS_Desktop.mov

Ollyws

LGTM.

OSBotify · 2025-07-15T00:03:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-15T03:23:14Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.1.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

grgia · 2025-07-15T13:05:09Z

src/pages/ConciergePage.tsx

-                    // Mark the viewTourTask as complete if we are redirected to Concierge after finishing the Navattic tour
-                    const {navattic} = (route.params as {navattic?: string}) ?? {};
-                    if (navattic === CONST.NAVATTIC.COMPLETED) {
-                        if (viewTourTaskReport) {
-                            if (viewTourTaskReport.stateNum !== CONST.REPORT.STATE_NUM.APPROVED || viewTourTaskReport.statusNum !== CONST.REPORT.STATUS_NUM.APPROVED) {
-                                completeTask(viewTourTaskReport);
-                            }
-                        }
-                    }


I think this may be related to #66152

luacmartins · 2025-07-16T18:10:12Z

@fabioh8010 steps 1-5 work, but I don't see the test drive button on the reports page. This is a new user invited to a workspace.

github-actions · 2025-07-16T19:54:56Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.81-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fabioh8010 · 2025-07-18T09:14:34Z

@luacmartins Once you see the Test drive demo the first time, the button will disappear in the other places.

luacmartins · 2025-07-18T14:50:32Z

Ah I see. I was a bit confused from the test steps in the OP. Thanks for clarifying.

fabioh8010 added 4 commits July 10, 2025 19:47

Update FAB and Empty Search test drive links for invited employees

421b20c

Merge branch 'main' into bugfix/65797

3853d50

Use demo route in onboarding task for invited employees

152d315

Refactor to remove Navattic code

6da17cf

fabioh8010 marked this pull request as ready for review July 11, 2025 17:36

fabioh8010 requested a review from a team as a code owner July 11, 2025 17:36

melvin-bot bot requested review from Ollyws and removed request for a team July 11, 2025 17:36

fabioh8010 mentioned this pull request Jul 11, 2025

Update TestDrive link for invited employees #65797

Closed

16 tasks

marcaaron assigned fabioh8010 Jul 11, 2025

marcaaron self-requested a review July 11, 2025 18:29

Merge branch 'main' into bugfix/65797

f75c4d5

Ollyws approved these changes Jul 14, 2025

View reviewed changes

marcaaron approved these changes Jul 14, 2025

View reviewed changes

marcaaron merged commit 50a6769 into Expensify:main Jul 14, 2025
18 checks passed

github-actions bot mentioned this pull request Jul 15, 2025

Deploy Checklist: New Expensify 2025-07-15 #66099

Closed

95 tasks

mitarachim mentioned this pull request Jul 15, 2025

Test Drive - Test Drive demo site shows "This content is blocked" #66121

Closed

8 tasks

jponikarchuk mentioned this pull request Jul 15, 2025

[Due for payment 2025-08-13] [$250] iOS - The concierge task is not auto-completed after completing Test drive via Reports tab #66152

Closed

8 tasks

grgia reviewed Jul 15, 2025

View reviewed changes

jponikarchuk mentioned this pull request Jul 15, 2025

Hybrid - PR65900 - Return to Expensify on the Test Drive demo site shows the login page #66158

Closed

8 tasks

BlameGPT mentioned this pull request Jul 16, 2025

Reports - Concierge message shows "In Chat Report" instead of "In Concierge" #66248

Closed

8 tasks

Conversation

fabioh8010 commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 11, 2025

Uh oh!

fabioh8010 commented Jul 11, 2025

Uh oh!

Ollyws commented Jul 14, 2025

Uh oh!

Ollyws commented Jul 14, 2025

Uh oh!

fabioh8010 commented Jul 14, 2025

Uh oh!

Ollyws commented Jul 14, 2025

Uh oh!

Ollyws commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

grgia Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

fabioh8010 commented Jul 18, 2025

Uh oh!

luacmartins commented Jul 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fabioh8010 commented Jul 10, 2025 •

edited

Loading

Ollyws commented Jul 14, 2025 •

edited

Loading

luacmartins commented Jul 16, 2025 •

edited

Loading