[Due for payment 2025-07-22] [Fix CP'd] Expense - System message when paid with bank account is different in LHN and thread

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.80-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #65296
Email or phone of affected tester (no customers): applausetester+ds90nu2@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace is set up with bank account.
• Admin invites member to the workspace.
• Member has a personal bank account.

1. Go to staging.new.expensify.com
2. [Member] Submit an expense with amount more than $100 to the workspace chat.
3. [Member] Click Submit on the expense preview.
4. [Admin] Open the expense report.
5. [Admin] Click Approve and Pay by bank account.
6. [Admin] Right click on paid system message > Reply in thread.

Expected Result:

• LHN preview willl show the same message as the expense report - paid with bank account 1111
• Paid system message thread header will show the same message as the parent message - paid with bank account 1111

Actual Result:

• LHN preview shows "paid amount with bank account 1111", expense report shows "paid with bank account 1111".
• Paid system message thread header shows "paid with wallet", when the parent message is "paid with bank account 1111".

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

System message when paid with bank account is different in LHN and thread

What is the root cause of that problem?

We are using wallet as default return here

App/src/libs/ReportUtils.ts

Lines 5148 to 5154 in 8b943bb

	if (originalMessage.paymentType === CONST.IOU.PAYMENT_TYPE.VBBA || originalMessage.paymentType === CONST.IOU.PAYMENT_TYPE.EXPENSIFY) {
	if (originalMessage.automaticAction) {
	return translateLocal('iou.automaticallyPaidWithExpensify');
	}
	return translateLocal('iou.paidWithExpensify');
	}
	}

that cause this message to appear in thread report because we are not explicitly checking for VBBA type here

App/src/languages/en.ts

Line 1171 in 8b943bb

paidWithExpensify: ({payer}: PaidWithExpensifyParams = {}) => `${payer ? `${payer} ` : ''}paid with wallet`,

What changes do you think we should make in order to solve the problem?

We should explicitly check for VBBA payment type and return the report name for bank account

const last4Digits = policy?.achAccount?.accountNumber.slice(-4) ?? '';
const {amount, currency} = originalMessage?.IOUDetails ?? originalMessage ?? {};
const formattedAmount = convertToDisplayString(Math.abs(amount ?? 0), currency) ?? '';
.
.
.
if (originalMessage.paymentType === CONST.IOU.PAYMENT_TYPE.VBBA) {
    return translateLocal('iou.businessBankAccount', {
        amount: formattedAmount,
        last4Digits,
    });
}

here

App/src/libs/ReportUtils.ts

Lines 5148 to 5154 in 8b943bb

	if (originalMessage.paymentType === CONST.IOU.PAYMENT_TYPE.VBBA || originalMessage.paymentType === CONST.IOU.PAYMENT_TYPE.EXPENSIFY) {
	if (originalMessage.automaticAction) {
	return translateLocal('iou.automaticallyPaidWithExpensify');
	}
	return translateLocal('iou.paidWithExpensify');
	}
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

if (originalMessage.paymentType === CONST.IOU.PAYMENT_TYPE.EXPENSIFY){
    return translateLocal('iou.paidWithExpensify');

}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[rushatgabhane]

@BlameGPT find the culprits