feat: standardize pay button

[getusha]

Explanation of Change

Standardize pay button for IOUs and Expenses

Fixed Issues

$ #61744
$ #55874
#55875
PROPOSAL:

Tests

Paying IOU for the first time - preview

1. Account B: submits an expense to Account A (a US based account)
2. Account A: Navigate to the expense preview and press on Pay %amount% button
3. Verify you are presented with 3 options Pay with personal account, Pay with business account, Mark as paid
4. Press Pay with personal account
5. Verify that you are prompted to setup a PBA
6. Complete steps to add PBA
7. Press on Pay %amount% button
8. Verify Pay with business account is present
9. Press Pay with business account
10. Verify that a collect workspace is created and the IOU is moved to the new workspace chat
11. Verify that there is a system message that clarifies the IOU is moved
12. Navigate to the new workspace
13. Create a new IOU
14. Verify that there is Pay via %workspace name% option
15. Press the option in step 14
16. Verify that the IOU is moved to the existing workspace

Paid IOU before - preview

1. Account B: Submit an expense to Account A
2. Account A: Open the chat to Account B and pay the IOU using any payment method
3. Verify that the recently used payment method is selected
4. Account B: Submit another expense
5. Account A: Tap on the default option on the new IOU
6. Verify that the IOU is paid

Paying expense report for the first time - preview

• Preconditions

1. Have a workspace with a preferred currency of USD
   Steps
2. Submit an expense to the workspace
3. Login to the admin account and open the expense chat
4. Verify that the settlement button matches the design below
5. Press on the settlement button
6. Verify that there is Pay with business account and Mark as paid.
7. Verify the expense view has the same pattern

Paying expense report for the first time - held expense

• Preconditions

1. A workspace with an expense that has held amount
   Steps
2. Press on the settlement button
3. Verify that you're presented with a dropdown to select the payment method first
4. Press on any payment method
5. Verify you're presented with a modal to confirm whether you want to pay the full or not-held amount.

Paid expense report before - preview

• Preconditions

1. A workspace chat with previously paid expenses using a BBA
2. A new expense report inside the workspace chat
   Steps
3. Navigate to the workspace chat
4. Verify the settlement button matches the pattern below

Test 65118:

1. Go to workspace chat.
2. Create an expense.
3. Tap Submit and Approve.
4. Go to Reports.
5. Tap Pay.
6. Select Mark as paid.
7. Verify that you can pay the expense

Test 65118:

1. Navigate to "Workspaces" and create a new workspace.
2. Open "Workflows" and disable delayed submissions and approvals.
3. Navigate to workspace chat.
4. Submit a manual expense.
5. Navigate to "Reports"
6. Check the size of the "Pay" button.
7. Return to chat and mark the expense as paid.
8. Open the expense and cancel the payment.
9. Return to "Reports"
10. Verify that the "Pay" button has the same size as before.

Test 65125

1. Go to staging.new.expensify.com
2. [User A] Submit an expense to User B.
3. [User B] Pay the expense.
4. [User A] Submit another expense to User B.
5. [User B] Go to Account > Preferences > Language.
6. [User B] Change the language to Spanish or Dutch
7. [User B] Go to Reports.
8. Verify that you see the Pay button.

Test 65120

Precondition:
User B has paid an expense from User A at least once.

1. Go to staging.new.expensify.com
2. [User A] Submit an expense to User B.
3. [User B] Go to Reports > Expenses.
4. [User B] Go offline.
5. [User B] Verify that Pay button is disabled.

• Verify that no errors appear in the JS console

Offline tests

N/a

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Paying IOU for the first time - preview

Paid IOU before - preview

Paying expense report for the first time - preview

Paying expense report for the first time - held expense

Screen.Recording.2025-04-22.at.6.11.01.in.the.evening.mov

Paid expense report before - preview

MacOS: Desktop

[melvin-bot]

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

[dubielzyk-expensify]

Tested this and works well on my end. I got quite a few workspaces and the list is long. I think I remember us having a max-height on these popovers so that it scrolls, right?

[shawnborton]

Can you share the whole screenshot there? I agree, we might want a max-height but I would think the max-height kicks in if we think the popover will exceed the screen limits - seems like maybe this one wouldn't?

Also, I wonder if we should use the workspace avatar for the workspace rows? Otherwise the repetitive generic building icon doesn't really offer much help.

[getusha]

I think it takes one more to kick in if not it's an issue.

[getusha]

Just confirmed that 7 is the limit.
We can adjust it to make it shorter.

[shawnborton]

Okay, that's probably fine then.

Curious what others think about showing the workspace avatar instead of a repeating building icon. Thoughts @joekaufmanexpensify ?

[dannymcclain]

Not against that. (But reserve the right to be against it if we implement it and looks like a bummer 😆)

[joekaufmanexpensify]

Same. Not super passionate either way. Though, it is probably not super likely that many will ever see a long list of workspaces here. Most people only have one workspace, and even if you have many, you only see this if you are moving IOUs to workspaces, which is itself not a super common flow for existing customers with lots of workspaces.

[github-actions]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.1.80-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅