-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Labels
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
We're currently using a post-install method to apply the patched version of react-native-web in this PR #6738
There are a few issues with this (cc @kidroca)
- The post install installs dependencies without maintaining a package-lock
- Result is not cacheable and requires a re-compile of the fork
- Makes the duration of our PR pipelines longer
Solution:
- Use github package service
- use patch-package
- bundle code in dist https://expensify.slack.com/archives/C01GTK53T8Q/p1637266193313200?thread_ts=1636047163.494200&cid=C01GTK53T8Q
Discussion thread https://expensify.slack.com/archives/C01GTK53T8Q/p1636047163494200
Version Number:
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Reactions are currently unavailable