Skip to content

Update how we apply forked version of react-native-web #6763

@thienlnam

Description

@thienlnam

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


We're currently using a post-install method to apply the patched version of react-native-web in this PR #6738

There are a few issues with this (cc @kidroca)

  1. The post install installs dependencies without maintaining a package-lock
  2. Result is not cacheable and requires a re-compile of the fork
  3. Makes the duration of our PR pipelines longer

Solution:

  1. Use github package service
  2. use patch-package
  3. bundle code in dist https://expensify.slack.com/archives/C01GTK53T8Q/p1637266193313200?thread_ts=1636047163.494200&cid=C01GTK53T8Q

Discussion thread https://expensify.slack.com/archives/C01GTK53T8Q/p1636047163494200

Version Number:
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions