Fix inverted list by applying forked version of react-native-web#6738
Fix inverted list by applying forked version of react-native-web#6738thienlnam merged 2 commits intoExpensify:mainfrom
Conversation
…ng forked react-native-web version from expensify;
|
@thienlnam ready for review. First Expensify/react-native-web#3 needs to be merged. |
|
@parasharrajat @PrashantMangukiya @kidroca Based on your previous reports I would appreciate if you could take a look at this PR. |
kidroca
left a comment
There was a problem hiding this comment.
We already decided against having to build this in the postinstall hook
It would be much better to use a prebuilt hash from our fork
Build once use the same bundle everywhere vs making everyone build it themselves
cc @thienlnam
|
@kidroca could you link the thread with discussion here |
|
Here's the slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1636047163494200 |
|
@thienlnam Simply changing |
|
This still looks like a hack and a workaround while we could have implemented github's package service as a better approach (Proposition #1 from the thread). |
|
As discussed in the thread, going to allow this for now so we can have QA test these changes and create another issue to have it fixed. Going to test this locally before approving / merging |
thienlnam
left a comment
There was a problem hiding this comment.
Tests well for me locally
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Linked the issue to update how we apply it #6763 For now, this can move along and we can have QA test the changes to the virtualized list |
|
🚀 Deployed to staging by @thienlnam in version: 1.1.20-3 🚀
|
|
Reverting to solve a deploy blocker #6792 |
|
🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀
|
I used a patched version of react-native-web with fixes for copying text into the buffer in reversed order;
React native change: Expensify/react-native-web#3
Details
I have removed flatlist inversion (by inverted=true prop) which used [transform: translate] css hack and instead adding flatlist array items in reverse order [unshift instead of push]; It also reverses ScrollView event response received from browser [e.nativeEvent.configOffset *= -1];
Fixed Issues
#3381
Tests
npm installwhich will patch react-native-web packagenpm run webQA Steps
Tested On
Screenshots
Web
Screen.Recording.2021-08-09.at.01.16.16.mov
Mobile Web
Desktop
iOS
Android