Backend - "On Hold" status is not removed after expense is moved to Self DM

[ahmedGaber93]

Original GH: #69109

Action Performed:

Prerequisite: Account has a Self DM

1. Open any workspace chat
2. Create a manual expense
3. Open the just created expense
4. Tap on "More" and select "Hold"
5. Enter any reason and hold the expense
6. Once redirected to report, tap on the report field
7. Tap on "Remove from report"
8. Navigate to Self DM
9. Note that "On Hold" status was not removed from expense

Expected Result:

• In api/ChangeTransactionsReport, when the expense will be moved to selfDM report, backend should remove "On Hold" status if it found.
• The API response should have onyx data similar to unholdRequest response.

Actual Result:

• In api/ChangeTransactionsReport, when the expense moved to selfDM report, backend doesn't remove "On Hold" status.

Screenshots/Videos

Add any screenshot/video evidence

20250912024049254.mp4

[melvin-bot]

Triggered auto assignment to @youssef-lr (AutoAssignerNewDotQuality)

[ahmedGaber93]

Opened this based on #69109 (comment), and we are handling the FE part there.

[youssef-lr]

Will try to get to this soon.

[AndrewGable]

@youssef-lr - This also could be good for the external contributors too! https://stackoverflowteams.com/c/expensify/questions/22342

[allgandalf]

I'll take a look at this