[Due for payment 2025-11-21] Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.48-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory #72941
Email or phone of affected tester (no customers): sodjnosdjsdosjod@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create two expenses.
4. Click Submit.
5. Create another expense.
6. Do not click Submit.
7. Go to Reports > Reports.
8. Expand both report rows.
9. Select one of the expenses from submitted report (from Step 4) and select the unsubmitted expense (from Step 6).
10. Click dropdown button.

Expected Result:

Dropdown menu will not show Submit button because one of the selected expenses is already submitted.

Actual Result:

Dropdown menu still shows Submit button when one of the selected expenses is already submitted.

This issue does not happen if user selects all expenses from both reports.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted

What is the root cause of that problem?

The shouldShowSubmitOption logic in SearchPage.tsx is missing the areSelectedTransactionsIncludedInReports check. Without this check, when selecting expenses from different reports (one submitted, one draft/open), the code fails to detect the conflicting states and incorrectly shows the Submit button. The Approve button already has this check, but Submit missing it.

What changes do you think we should make in order to solve the problem?

we should check areSelectedTransactionsIncludedInReports && in shouldShowSubmitOption

like this

const shouldShowSubmitOption =
    !isOffline &&
    areSelectedTransactionsIncludedInReports &&
    (selectedReports.length
        ? selectedReports.every((report) => report.allActions.includes(CONST.SEARCH.ACTION_TYPES.SUBMIT))
        : selectedTransactionsKeys.every((id) => selectedTransactions[id].action === CONST.SEARCH.ACTION_TYPES.SUBMIT));

here

App/src/pages/Search/SearchPage.tsx

Lines 438 to 443 in 23b260f

	const shouldShowSubmitOption =
	!isOffline &&
	(selectedReports.length
	? selectedReports.every((report) => report.allActions.includes(CONST.SEARCH.ACTION_TYPES.SUBMIT))
	: selectedTransactionsKeys.every((id) => selectedTransactions[id].action === CONST.SEARCH.ACTION_TYPES.SUBMIT));

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

@nkdengineer this is from your PR. Can you address it? CC: @hoangzinh @mjasikowski

[nkdengineer]

@trjExpensify please assign me, I will raise the follow up soon.

[CortneyOfstad]

done!

[nkdengineer]

@hoangzinh The PR is ready for review.