Change Submit button to primary action and make available in the bulk select menu by nkdengineer · Pull Request #72941 · Expensify/App

nkdengineer · 2025-10-20T05:02:22Z

Explanation of Change

Fixed Issues

$ #72083
PROPOSAL: #72083 (comment)

Tests

Pre-condition: Have a default workspace

Preconditions
Workspace is set to automated Delayed Submission frequency (e.g. weekly)

Create a report and add expenses to it
Resolve all errors and ensure receipts are added to all expenses in the report (i.e. it should be ready for submission, but not submitted)
Click on Report tab
Click on Submit
Select the checkbox next to the Report
Click on Selected
Verify that the submit option is displayed
Click on the submit option
Verify that the selected reports are submitted

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-10-24.at.15.59.13.mov

Android: mWeb Chrome

Screen.Recording.2025-10-24.at.15.54.35.mov

iOS: Native

Screen.Recording.2025-10-24.at.15.58.00.mov

iOS: mWeb Safari

Screen.Recording.2025-10-24.at.15.53.22.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-24.at.15.49.00.mov

MacOS: Desktop

Screen.Recording.2025-10-24.at.16.00.17.mov

… select menu

melvin-bot · 2025-10-20T05:02:35Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-10-20T05:14:56Z

Codecov Report

❌ Patch coverage is 24.00000% with 19 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pages/Search/SearchPage.tsx	0.00%	19 Missing ⚠️

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.71% <ø> (ø)`
src/libs/ReportPreviewActionUtils.ts	`91.53% <100.00%> (+0.49%)`	⬆️
src/libs/ReportPrimaryActionUtils.ts	`92.10% <100.00%> (+0.35%)`	⬆️
src/libs/actions/IOU.ts	`64.40% <100.00%> (-0.06%)`	⬇️
src/pages/Search/SearchPage.tsx	`0.00% <0.00%> (ø)`

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hoangzinh · 2025-10-22T01:13:47Z

@nkdengineer can you fix failing checks?

hoangzinh · 2025-10-22T01:16:53Z

Also add recordings for PR, please

hoangzinh · 2025-10-22T01:26:01Z

Bug 1: It doesn't display "Submit" action for some expenses in Reports -> Submit page

Screen.Recording.2025-10-22.at.08.23.54.mov

hoangzinh · 2025-10-22T01:31:12Z

Bug 2: Submit icon looks incorrect.

It should be like this:

hoangzinh · 2025-10-23T10:14:36Z

@nkdengineer can you also fix failing checks? TY

trjExpensify · 2025-10-23T14:43:33Z

@nkdengineer chances of getting this spruced today? I'd love to get it over the line.

nkdengineer · 2025-10-24T04:35:32Z

I'll prioritize it today

nkdengineer · 2025-10-24T09:29:54Z

@hoangzinh I already updated the PR to change the submit icon, lint errors and add the videos.

Bug 1: It doesn't display "Submit" action for some expenses in Reports -> Submit page

For this issue, I'm unclear how to reproduce. Can you please give me more information?

hoangzinh · 2025-10-24T10:57:43Z

Here are the steps @nkdengineer:

Create an expense
Hold that expense
Go to Reports -> Submit
Select that expense

Screen.Recording.2025-10-24.at.17.55.48.mov

trjExpensify · 2025-10-24T16:59:21Z

@nkdengineer any movement here?

nkdengineer · 2025-10-24T17:11:44Z

@hoangzinh I fixed this issue.

hoangzinh · 2025-10-27T14:27:18Z

src/pages/Search/SearchPage.tsx

+                        }
+                    });
+                    // eslint-disable-next-line @typescript-eslint/no-deprecated
+                    InteractionManager.runAfterInteractions(() => {


@nkdengineer, do we really need InteractionManager.runAfterInteractions here?

I think yes, it was added on purpose here

It was added since the beginning when they added clearSelectedTransactions. Given InteractionManager will be deprecated soon, can you help to check if we have any bugs without InteractionManager.runAfterInteractions

@hoangzinh I don't see any issue without InteractionManager.runAfterInteractions. I removed this here.

hoangzinh · 2025-10-27T14:37:15Z

src/pages/Search/SearchPage.tsx

+            !isOffline &&
+            (selectedReports.length
+                ? selectedReports.every((report) => report.allActions.includes(CONST.SEARCH.ACTION_TYPES.SUBMIT))
+                : selectedTransactionsKeys.every((id) => selectedTransactions[id].action === CONST.SEARCH.ACTION_TYPES.SUBMIT));


Do we need to check selectedTransactionsKeys? It seems we don't display "submit" button for a transaction thread report.

I'm not sure about that, I just did the same as approve.

It seems we don't display "submit" button for a transaction thread report.

I also tried it and see the selectedTransactions[id].action was View, but again I'm not sure if we should remove it.

Hi @trjExpensify, Given that a money report contains two expenses, I recall that users can only submit the entire money report to the admin for approval — they can’t submit individual expenses within that report, can they?

Ah whoops, answered below.

Correct, there's no partial Submit button revealed on one of two expenses on a report. If we're talking about the Reports > Expenses page here, then it's only a one-expense report that would have the Submit button. 👍

Thanks @trjExpensify. Then I think we can remove selectedTransactions code, what do you think? @nkdengineer

@hoangzinh We still need to check selectedTransactionsKeys. For an expense report with only one transaction, we can see the submit action here. If the report has at least two transactions, it still works correctly since the submit button doesn't appear in each transction item.

Screen.Recording.2025-10-30.at.16.23.36.mov

src/libs/actions/IOU.ts

src/libs/ReportPrimaryActionUtils.ts

src/pages/Search/SearchPage.tsx

hoangzinh · 2025-10-28T10:02:02Z

src/libs/ReportPreviewActionUtils.ts

        return true;
    }


I missed those lines. Can you check if we can remove those lines? TY

hoangzinh · 2025-10-28T10:08:10Z

src/pages/Search/SearchPage.tsx

+            !isOffline &&
+            (selectedReports.length
+                ? selectedReports.every((report) => report.allActions.includes(CONST.SEARCH.ACTION_TYPES.SUBMIT))
+                : selectedTransactionsKeys.every((id) => selectedTransactions[id].action === CONST.SEARCH.ACTION_TYPES.SUBMIT));


Hi @trjExpensify, Given that a money report contains two expenses, I recall that users can only submit the entire money report to the admin for approval — they can’t submit individual expenses within that report, can they?

hoangzinh · 2025-11-04T15:47:19Z

@trjExpensify I see. I tested this several times, and it looks like the issue is consistently reproducible.

@nkdengineer, can you fix this this issue?

nkdengineer · 2025-11-04T16:12:24Z

#72941 (comment)

@trjExpensify @hoangzinh The row disappeared after the backend response of Search API merged into Onyx. For bulk actions, we call 1 API per report, then we need to wait for all of them to finish before merging the response data into Onyx. We can see the same for Approve bulk action.

Screen.Recording.2025-11-04.at.23.10.28.mov

trjExpensify · 2025-11-05T14:38:14Z

Putting aside 3G to slow it down, I see what you mean.

2025-11-05_14-36-55.mp4

2025-11-05_14-35-17.mp4

So I'm happy as a follow-up to improve across the board. 👍

trjExpensify · 2025-11-05T14:39:10Z

@nkdengineer can you fix the conflicts, and @hoangzinh is that it to approve this one?

hoangzinh · 2025-11-06T09:52:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-06.at.18.08.19.android.mov

Android: mWeb Chrome

Screen.Recording.2025-11-06.at.18.09.54.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-11-06.at.22.06.50.mov

iOS: mWeb Safari

Screen.Recording.2025-11-06.at.19.28.04.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-06.at.17.07.05.web.mov

MacOS: Desktop

Screen.Recording.2025-11-06.at.17.33.11.desktop.mov

hoangzinh · 2025-11-06T11:02:39Z

@nkdengineer can you update the testing steps? It looks incorrect to me

trjExpensify · 2025-11-07T00:22:00Z

Bump @nkdengineer let's get this over the line.

nkdengineer · 2025-11-07T06:21:29Z

@hoangzinh Updated the test step.

hoangzinh

LGTM

mjasikowski

LGTM

OSBotify · 2025-11-07T08:57:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-07T23:46:23Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.2.47-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mitarachim · 2025-11-08T03:23:33Z

Hello @nkdengineer @trjExpensify , Submit button is not displayed in bulk select menu when offline , is this expected according this comment in original issue ?
Thanks in advance

Bug6997659_1762570591035.submit_disappear_in_bulk_menu.mp4

nkdengineer · 2025-11-08T03:51:32Z

@mitarachim The bulk action on search page doesn't support in offline so it's expected.

OSBotify · 2025-11-10T12:00:57Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.47-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Change Submit button to primary action and make available in the bulk…

4744b8c

… select menu

melvin-bot bot assigned nkdengineer Oct 20, 2025

nkdengineer marked this pull request as ready for review October 20, 2025 05:02

nkdengineer requested a review from a team as a code owner October 20, 2025 05:02

melvin-bot bot requested review from hoangzinh and removed request for a team October 20, 2025 05:02

merge main

01c84c1

hoangzinh mentioned this pull request Oct 22, 2025

[Due for payment 2025-11-17] [$250] [CFI] Delayed submit - Change Submit button to primary action and make available in the bulk select menu #72083

Closed

16 tasks

nkdengineer added 2 commits October 24, 2025 15:38

Merge branch 'main' into fix/72083

c0eb4ac

fix lint

a00f707

nkdengineer added 2 commits October 25, 2025 00:03

Merge branch 'main' into fix/72083

207bef4

update correct submit action

b7712c0

hoangzinh reviewed Oct 27, 2025

View reviewed changes

resolve comments

86ba990

hoangzinh reviewed Oct 28, 2025

View reviewed changes

nkdengineer added 2 commits October 29, 2025 23:50

Merge branch 'main' into fix/72083

6368d29

remove unnecessary condition

ae8eef5

resolve conflict

609f150

nkdengineer requested a review from a team as a code owner November 5, 2025 14:41

melvin-bot bot requested review from heyjennahay and removed request for a team November 5, 2025 14:41

nkdengineer added 5 commits November 5, 2025 21:46

resolve getReportPrimaryAction

7b43d06

remove log file

d74fd87

resolve conflict

eab092b

Merge branch 'main' into fix/72083

23e92d3

fix typescript error

81f4ab2

resolve conflict

4f969c2

hoangzinh approved these changes Nov 7, 2025

View reviewed changes

melvin-bot bot requested a review from mjasikowski November 7, 2025 08:28

mjasikowski reviewed Nov 7, 2025

View reviewed changes

mjasikowski approved these changes Nov 7, 2025

View reviewed changes

mjasikowski merged commit 3adf170 into Expensify:main Nov 7, 2025
29 checks passed

OSBotify mentioned this pull request Nov 7, 2025

Deploy Checklist: New Expensify 2025-11-07 #74626

Closed

48 tasks

jponikarchuk mentioned this pull request Nov 10, 2025

[Due for payment 2025-11-21] Reports - Dropdown menu shows "Submit" when one of the selected expenses is already submitted #74708

Closed

8 tasks

Conversation

nkdengineer commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 20, 2025

Uh oh!

codecov bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hoangzinh commented Oct 22, 2025

Uh oh!

hoangzinh commented Oct 22, 2025

Uh oh!

hoangzinh commented Oct 22, 2025

Uh oh!

hoangzinh commented Oct 22, 2025

Uh oh!

hoangzinh commented Oct 23, 2025

Uh oh!

trjExpensify commented Oct 23, 2025

Uh oh!

nkdengineer commented Oct 24, 2025

Uh oh!

nkdengineer commented Oct 24, 2025

Uh oh!

hoangzinh commented Oct 24, 2025

Uh oh!

trjExpensify commented Oct 24, 2025

Uh oh!

nkdengineer commented Oct 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Nov 4, 2025

Uh oh!

nkdengineer commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Nov 5, 2025

Uh oh!

trjExpensify commented Nov 5, 2025

Uh oh!

hoangzinh commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

nkdengineer commented Oct 20, 2025 •

edited

Loading

codecov bot commented Oct 20, 2025 •

edited

Loading

nkdengineer commented Nov 4, 2025 •

edited

Loading

hoangzinh commented Nov 6, 2025 •

edited

Loading