[Due for payment 2026-01-05] [$250] Wallet - Share button is shown for personal bank account, error shows up when trying to share it

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.86-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #73427
Email or phone of affected tester (no customers): applausetester+sdj0mssjsdidnd15@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Mac 26.1 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace owner has invited user as workspace admin.
• Workspace is set up with business bank account.
• Workspace owner has personal bank account.
• Perform the steps below as workspace owner.

1. Go to staging.new.expensify.com
2. Go to Profile > Wallet.
3. Click on the business bank account.
4. Click on the personal bank account.
5. Click Share.
6. Select workspace admin and click Share.

Expected Result:

Share button should be hidden for personal bank account.

Actual Result:

Share button is shown for personal bank account. Error shows up when trying to share personal bank account.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022005600464999106688
• Upwork Job ID: 2005600464999106688
• Last Price Increase: 2025-12-29

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #73427

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samarroy84]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Wallet - Share button is shown for personal bank account, error shows up when trying to share it

What is the root cause of that problem?

App/src/pages/settings/Wallet/WalletPage/index.tsx

Lines 133 to 135 in 5f74dd2

	if (accountData?.type === CONST.BANK_ACCOUNT.TYPE.BUSINESS) {
	setShouldShowShareButton(accountData?.state === CONST.BANK_ACCOUNT.STATE.OPEN);
	}

When click 3 dots menu on open business account, shouldShowShareButton becomes true and never resets to false whenever click 3 dots menu on other accounts.

What changes do you think we should make in order to solve the problem?

Replace above code with

setShouldShowShareButton(accountData?.type === CONST.BANK_ACCOUNT.TYPE.BUSINESS && accountData?.state === CONST.BANK_ACCOUNT.STATE.OPEN);

What alternative solutions did you explore? (Optional)

[joekaufmanexpensify]

discussing