[Internal QA]: Share bank account

[narefyev91]

Explanation of Change

Share bank account design doc - https://docs.google.com/document/d/1l8ODiSIiEIE-a9zjj69ACqCHGHeLPwf4c-H5SJn3uHg/edit?tab=t.0#heading=h.rrw1sioyg63r

Fixed Issues

$ #73250
PROPOSAL:

Tests

1. Go to wallet page in which user has already bank account in OPEN state
2. Click on bank account menu item -> Verify that share option is available
3. Click on share - verify that new page with available admins are shown
4. Pick some admins -> verify that Share button will be enabled
5. Click on Share -> verify that loader in the button is shown and we wait until BE will return success or failed data.
6. If API successfully executed - verify that user sees success confirmation page
7. Click Got it button -> user should be redirect to wallet page

• Verify that no errors appear in the JS console

Offline tests

1. Go to wallet page in which user has already bank account in OPEN state
2. Click on bank account menu item -> Verify that share option is available
3. Click on share - verify that new page with available admins are shown
4. Pick some admins -> verify that Share button will be enabled
5. Click on Share -> verify that loader in the button is shown and we wait until app will be online.

QA Steps

1. Go to wallet page in which user has already bank account in OPEN state
2. Click on bank account menu item -> Verify that share option is available
3. Click on share - verify that new page with available admins are shown
4. Pick some admins -> verify that Share button will be enabled
5. Click on Share -> verify that loader in the button is shown and we wait until BE will return success or failed data.
6. If API successfully executed - verify that user sees success confirmation page
7. Click Got it button -> user should be redirect to wallet page

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. If you want to automatically generate translations for other locales, you can run the Generate static translations GitHub workflow.

Please look at the code and make sure there are no malicious changes before running the workflow.

If you have the K2 extension, you can simply click: [this button]

[narefyev91]

Could i please get design review:
@Expensify/design

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	100.00% <ø> (ø)
src/SCREENS.ts	100.00% <ø> (ø)
src/components/Icon/chunks/illustrations.chunk.ts	0.00% <ø> (ø)
...ListWithSections/BaseSelectionListWithSections.tsx	75.98% <ø> (ø)
src/libs/API/types.ts	100.00% <ø> (ø)
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	75.00% <ø> (ø)
src/styles/index.ts	46.55% <ø> (ø)
src/ROUTES.ts	12.96% <0.00%> (-0.02%)	⬇️
...gation/AppNavigator/ModalStackNavigators/index.tsx	8.28% <0.00%> (-0.02%)	⬇️
... and 4 more
... and 7 files with indirect coverage changes

[melvin-bot]

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[narefyev91]

We still waiting for BE to be done - but FE part could be start checking

[dubielzyk-expensify]

The Select all should use this styling which I think we're starting to use everywhere in the app:

Basically text should be label size and supporting color

[dubielzyk-expensify]

This looks like a simple illustration scaled up which means the border is too thick. Let's use this instead, but not put it in the simple illustration folder:

Here's the SVGs. And again, they're separate from the simple-illustration ones. We don't wanna replace those cause they're used at 48x48 size.

bank-share.svg.zip
bank-unshared.svg.zip

[narefyev91]

@dubielzyk-expensify updated:

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[dubielzyk-expensify]

Awesome @narefyev91 . Nailed it 🙌

[situchan]

@narefyev91 please merge main. 1.5k commits behind

[situchan]

Screen.Recording.2025-11-03.at.9.21.37.PM.mov

UI issues here:

• order should not change.
• highlight not last item but all selected items

Please check workspace members page for reference:

[narefyev91]

@situchan for the selected items across devices - maybe i'm missing that by if we use just local onyx form - and not stored it somewhere in the api - would it be accessible on other device - i think no?
If we need to make it across devices we need to store it somewhere on the server? am i right?

[situchan]

@situchan for the selected items across devices - maybe i'm missing that by if we use just local onyx form - and not stored it somewhere in the api - would it be accessible on other device - i think no? If we need to make it across devices we need to store it somewhere on the server? am i right?

No need to save on server.
Btw this bug should not happen in the first place because already added sharees should not be visible here. (the selected one is already sharee)

[narefyev91]

@situchan for the selected items across devices - maybe i'm missing that by if we use just local onyx form - and not stored it somewhere in the api - would it be accessible on other device - i think no? If we need to make it across devices we need to store it somewhere on the server? am i right?

No need to save on server. Btw this bug should not happen in the first place because already added sharees should not be visible here. (the selected one is already sharee)

which means that again - sharees array was not correctly set after api executed

[situchan]

@narefyev91 ok but even not sharee yet, if api fails for some reason, the bug persists. No way to deselect

Screen.Recording.2025-12-17.at.10.30.07.PM.mov

[situchan]

Approving as the reported bugs are from the test relying on test bank account.
If all good from internal testing with real bank account, we can go ahead and merge.

[situchan]

We can fix #73427 (comment) as follow up

[joekaufmanexpensify]

We can fix #73427 (comment) as follow up

Just to make sure I am following this one, not all admins are showing up as share options across all platforms because all the data needed to show them is not returned unless you have gone to the workspace members page at some point? If so, I agree we should fix this. Fine with me to do it as follow up. I assume it is a backend issue?

[situchan]

We can fix #73427 (comment) as follow up

Just to make sure I am following this one, not all admins are showing up as share options across all platforms because all the data needed to show them is not returned unless you have gone to the workspace members page at some point? If so, I agree we should fix this. Fine with me to do it as follow up. I assume it is a backend issue?

yes correct. This requires backend fix.

[NikkiWines]

Maybe I am misunderstanding, but don't we have the openBankAccountSharePage command specifically for this purpose? Shouldn't that be called whenever we open the Share page to ensure we get the up-to-date bank account data?

[NikkiWines]

Oh nevermind I see what you're saying 😄 We should actually probably update openBankAccountSharePage to return list of available admins as well, unless we specifically need it in OpenPaymentsPage?

[NikkiWines]

Auth PR is up and in review to fix the missing employeeList issue, the admins should be returned in the employeeList for the users' policies when we call OpenBankAccountSharePage 🙇

https://github.com/Expensify/Auth/pull/18844

Edit: PR has been merged, should be deployed today

[NikkiWines]

Couple very small things, looks good overall!

[NikkiWines]

out of date

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.86-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

[NikkiWines]

Actually, I think this can be QA'd by applause if they have access to a non-US test account 🤔 asked in slack

[OSBotify]

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.86-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅