[HOLD 77959] Workspaces - Duplicate workspace doesn't copy default currency

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.89-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78004 and #77448
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Critical User Impact
Device used: Windows 11 pro /Chrome
App Component: Workspace Settings

Action Performed:

1. Navigate to staging.new.expensify.com
2. Log in with new account
3. Create WS
4. Change the WS default currency to other currency
5. Go to Workspaces and click the 3-dot menu of an existing workspace
6. Click “Duplicate workspace”
7. Note the default currency shows the currency changed in step 4
8. Click “Continue”
9. Click "Proceed" in the pop-up window
10. Navigate to the duplicated workspace overview page

Expected Result:

The duplicated workspace default currency should show the changed currency

Actual Result:

The duplicated workspace default currency show the original currency not the updated

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The duplicated workspace default currency show the original currency not the updated

What is the root cause of that problem?

The duplicated workspace wasn't receiving the updated currency because DuplicateWorkspaceParams didn't include a currency field, so the API wasn't getting the current currency.

App/src/libs/actions/Policy/Policy.ts

Lines 2969 to 2984 in 1fbb0f1

	const params: DuplicateWorkspaceParams = {
	policyID,
	targetPolicyID,
	adminsChatReportID,
	expenseChatReportID,
	policyName,
	adminsCreatedReportActionID,
	expenseCreatedReportActionID,
	announceChatReportID: optimisticAnnounceChat.announceChatReportID,
	announceChatReportActionID: optimisticAnnounceChat.announceChatReportActionID,
	customUnitID,
	parts: JSON.stringify(parts),
	welcomeNote,
	customUnitRateID,
	file: clonedFile,
	};

What changes do you think we should make in order to solve the problem?

We should add currency field to DuplicateWorkspaceParams type then update the duplication logic to pass the currency

    const params: DuplicateWorkspaceParams = {
        ... 
        currency: policy?.outputCurrency ?? CONST.CURRENCY.USD,
        file: clonedFile,
    };

App/src/libs/actions/Policy/Policy.ts

Lines 2969 to 2984 in 1fbb0f1

	const params: DuplicateWorkspaceParams = {
	policyID,
	targetPolicyID,
	adminsChatReportID,
	expenseChatReportID,
	policyName,
	adminsCreatedReportActionID,
	expenseCreatedReportActionID,
	announceChatReportID: optimisticAnnounceChat.announceChatReportID,
	announceChatReportActionID: optimisticAnnounceChat.announceChatReportActionID,
	customUnitID,
	parts: JSON.stringify(parts),
	welcomeNote,
	customUnitRateID,
	file: clonedFile,
	};

Then we should update the Back End to return the policy currency base on the currency params

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

Will be fixed here

[melvin-bot]

@bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

Need to check on #77959

[bfitzexpensify]

#77959 on staging, once it gets through we can retest this