[Due for payment 2026-01-20] Expense - Unable to delete expense from expense preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.96-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #77945
Email or phone of affected tester (no customers): sdjoinsjdosjnsodsijo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Right click on the expense preview > Delete expense.
5. Click Delete.

Expected Result:

Expense will be deleted.

Actual Result:

Expense is not deleted.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7043823_1767890056993.1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #77945

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

This is a frontend bug in the App repository.

Causing PR

High Confidence: #77945 - "refactored ConfirmModal usage to useConfirmModal" by @abbasifaizan70

Evidence:

1. The issue is reproducible only on staging (not production), indicating it was introduced in the current staging deploy
2. The issue description explicitly mentions this was caught during regression testing of PR refactored ConfirmModal usage to useConfirmModal #77945
3. The PR refactored the delete confirmation modal in PopoverReportActionContextMenu.tsx, which handles the right-click context menu delete action

Root Cause

The refactor introduced a race condition in the delete flow:

Old code flow:

1. User confirms deletion
2. confirmDeleteAndHideModal performs the delete operations
3. Modal is hidden
4. AFTER modal hide completes, onModalHide callback clears the refs via clearActiveReportAction()

New code flow (buggy):

1. User confirms deletion
2. performDelete() is called (initiates async delete operations)
3. Immediately clearActiveReportAction() is called, clearing reportActionRef.current
4. The delete operations try to use the already-cleared refs, causing the deletion to fail

The issue is in src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx lines 415-424:

if (result.action === ModalActions.CONFIRM) {
    onConfirm();
    performDelete();  // Starts async operations
} else {
    onCancel();
}

// BUG: Clears refs immediately without waiting for performDelete to complete
clearActiveReportAction();  
callbackWhenDeleteModalHide.current();

The old implementation correctly deferred ref clearing until after the modal hide animation completed.

Related Issues

Issue #79128 - "Report details RHP does not close after deleting the expense" - also caught during regression testing of PR #77945, likely caused by the same bug where the delete operation doesn't complete properly.

Recommendation

REVERT - PR #77945 should be reverted.

Reasoning:

• Clear root cause identified in the refactor
• Multiple deploy blockers caused by the same PR ([Due for payment 2026-01-20] Expense - Unable to delete expense from expense preview #79129 and [Due for payment 2026-01-20] Reports - Report details RHP does not close after deleting the expense #79128)
• The refactor changed critical timing/async behavior in the delete flow
• Reverting is safer than attempting a quick fix for the complex async behavior

---

Removing DeployBlocker label as this is a frontend bug and doesn't block the Web (backend) deploy.