refactored ConfirmModal usage to useConfirmModal#77945
refactored ConfirmModal usage to useConfirmModal#77945roryabraham merged 6 commits intoExpensify:mainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
No product considerations, removing my review |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-01-06.16.56.44.mov2026-01-06.16.57.18.mov2026-01-06.16.57.31.movAndroid: mWeb Chrome2026-01-06.17.02.15.mov2026-01-06.17.03.03.mov2026-01-06.17.04.54.moviOS: HybridApp2026-01-06.16.20.34.mov2026-01-06.16.01.43.mov2026-01-06.16.14.10.moviOS: mWeb Safari2026-01-06.16.17.53.mov2026-01-06.16.18.59.mov2026-01-06.16.19.19.movMacOS: Chrome / Safari2026-01-06.15.14.29.mov2026-01-06.15.30.50.mov2026-01-06.15.51.08.mov |
|
@abbasifaizan70 |
|
And as I can see, you didn't add all the videos or screenshots to your checklist |
|
When I try to delete a comment 2026-01-02.13.38.12.mov |
…d before performDelete() was called
|
@ZhenjaHorbach Fixed the above issue and added a screenshot for PopoverReportActionContextMenu.tsx on all platforms. |
|
Good |
|
@ZhenjaHorbach soft remainder for review. |
|
After pressing the confirm button, we don't have a close animation in some modals 2026-01-06.15.30.50.mov |
|
But overall changes look good |
|
@ZhenjaHorbach, anything else needed from my side? Or we wait for @waterim response to the issue that was mentioned. |
We have this issue in a few places But I don't think this is a critical issue CC: @roryabraham |
|
@ZhenjaHorbach I'm fine merging with that minor visual regression, but can you please file a follow-up issue in #expensify-bugs and tag me in it? Thanks! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Sure |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.96-1 🚀
|
|
This PR is failing because of issue ##79129 The issue is reproducible in: Web Bug7043823_1767890056993.1.1.mp4 |
Strange @abbasifaizan70 |
@ZhenjaHorbach, we fix the issue when we add a comment to any report (chat, expense, group chat, etc.) and try to delete it. But this issue occurs when we try to delete the expense through the right-click menu. |
Okay then |
@ZhenjaHorbach currently looking into that. Will update you here once i find some solution. |
|
@abbasifaizan70 |
agreed. I will make a new PR for these modal. |
I almost opened it |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀
|
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.96-6 🚀
|
Explanation of Change
This PR refactored ConfirmModal usage to useConfirmModal in the following files:
Fixed Issues
$ #76695
PROPOSAL: #76695 (comment)
Tests
ReportDetailsExportPage.tsx
precondition: Connect to your accounting system (e.g., QuickBooks, Xero)
PureReportActionItem.tsx
precondition: Find a Report Action with Receipt Error
PopoverReportActionContextMenu.tsx
HeaderView.tsx
This was dead code removal, so there's no modal to test. Just verify nothing broke.
Offline tests
same as tests.
QA Steps
same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-01-05.at.11.45.08.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-01-05.at.11.51.09.PM.mov
iOS: Native
Screen.Recording.2026-01-05.at.9.46.21.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-01-05.at.9.47.04.PM.mov
MacOS: Chrome / Safari
PureReportActionItem.tsx
Screen.Recording.2026-01-03.at.5.58.38.AM.mov
PopoverReportActionContextMenu.tsx
Screen.Recording.2026-01-03.at.5.48.41.AM.mov