[Due for payment 2026-01-23] Reports - "Delete report" modal opens when deleting one of the expenses

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.2-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #75261
Email or phone of affected tester (no customers): sdsnjsoisjnionjisdjos11@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense.
4. Go to Reports > Expenses.
5. Select the expense via checkbox.
6. Click dropdown button > Delete.
   → Delete expense modal opens.
7. Close the modal.
8. Go to workspace chat and add one more expense to the same report.
9. Go to Reports > Expenses.
10. Select one of the expenses via checkbox.
11. Click dropdown button > Delete.

Expected Result:

Delete expense modal will open.

Actual Result:

"Delete report" modal opens when deleting one of the expenses.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7049458_1768430447285.7.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @heyjennahay

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #75261

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #75261 - "Can't select an empty report from the Reports > Reports page" by @lorretheboy (High confidence)
Related Issues: None

Recommendation: REVERT

PR #75261 introduced logic to allow selection of empty reports from the Reports > Expenses page. However, there is a bug in how the selection state is managed when a report transitions from empty to having expenses. When selecting individual expenses from a report that was previously empty and selected, the modal incorrectly shows "Delete report" instead of "Delete expense".

Labels: Issue currently has DeployBlockerCash label which is correct since this is a frontend bug in the App repository.

Detailed Analysis

Evidence

The issue occurs when:

1. An empty report exists and can be selected (new feature from PR Can't select an empty report from the Reports > Reports page #75261)
2. Expenses are added to that report
3. User selects ONE expense to delete
4. Modal shows "Delete report" instead of "Delete expense"

Verification

I verified that PR #75261 modifies the key files involved:

• src/pages/Search/SearchPage.tsx - Contains the logic that determines whether to show "delete expense" vs "delete report" modal (lines 435-465)
• src/components/Search/index.tsx - Added mapEmptyReportToSelectedEntry() function that creates selection entries for empty reports
• src/components/Search/SearchContext.tsx - Modified to handle empty report selection

Root Cause

The bug is in how empty reports are tracked in the selection state:

1. Empty report selection: When an empty report is selected, it's added to selectedTransactions with key = reportID (from mapEmptyReportToSelectedEntry at line 151 in Search/index.tsx)

2. Modal logic issue: In SearchPage.tsx lines 445-447:

if (selectedItem.action === CONST.SEARCH.ACTION_TYPES.VIEW && key === selectedItem.reportID) {
    hasNonOneTransactionReport = true;
    reportIDs.add(selectedItem.reportID);

When the condition key === selectedItem.reportID is true, it indicates a report-level selection (not a transaction). This sets hasNonOneTransactionReport = true, which causes the modal to show "Delete report" instead of "Delete expense".

3. The bug: When a report transitions from empty to having expenses, stale empty-report selection entries may remain in selectedTransactions. When the user then selects a single expense to delete, both the transaction key AND the old report-level key exist in selectedTransactions, causing the system to incorrectly conclude that the user wants to delete the entire report.

The PR successfully allows empty reports to be selected, but the selection state cleanup when reports transition from empty to non-empty is not handled correctly.