Reports - Tax is 0.00, Tax rate is empty for unreported expense

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.6-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #78358
Email or phone of affected tester (no customers): osidjoisdjnojdisjid@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.1 / Chrome
App Component: Search

Action Performed:

Precondition:

• Taxes are enabled.

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Create an expense with 5% tax rate.
4. Go to Reports > Expenses.
5. Click Columns.
6. Select Tax and Tax rate and click Save.
7. Scroll the table to Tax and Tax rate.

Expected Result:

Tax and Tax rate column will be populated with correct data.

Actual Result:

Tax is 0.00.
Tax rate is empty.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7055143_1769042696714.7.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @koko57

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #78358

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #78358 - "fix: revert revert taxes field" by @koko57 (High confidence)
Related Issues: None

Recommendation: ROLL FORWARD

The fix is straightforward and localized to a single line in the search table component. Reverting #78358 would break the tax field functionality for unreported expenses everywhere else (expense details, confirmation pages), which was the intended feature. A roll-forward fix is simpler and less disruptive.

Labels: Keeping DeployBlockerCash (App deploy is blocked). Removing DeployBlocker since this is a frontend-only bug.

📋 Detailed Analysis

Evidence

PR #78358 added support for displaying tax fields on unreported expenses (tracked expenses in self DM reports). The PR correctly updated:

• MoneyRequestView.tsx (line 312): Added third parameter isExpenseUnreported to getTaxName()
• MoneyRequestConfirmationListFooter.tsx (lines 400-406): Added fallback to policyForMovingExpenses for unreported expenses

However, the PR failed to update the search table component at:

• src/components/TransactionItemRow/index.tsx line 531

Verification

Affected file: /home/runner/work/App/App/src/components/TransactionItemRow/index.tsx

Current buggy code (line 531):

<TextCell text={getTaxName(transactionItem.policy, transactionItem) ?? transactionItem.taxValue ?? '} />

Issue: For unreported expenses, transactionItem.policy is undefined or doesn't contain the correct tax rates. The search table needs to either:

1. Pass the correct policy (policyForMovingExpenses) to the search results data, OR
2. Use the third parameter of getTaxName() to fall back to transactionItem.taxValue when the policy is missing

Root Cause

For unreported expenses (tracked expenses in self DM):

• The transaction belongs to reportID = "-1" (unreported)
• The transaction should use the default workspace policy for tax rate lookups
• The search table receives transactionItem.policy which may be undefined or lack tax rate data
• Result: getTaxName(transactionItem.policy, transactionItem) returns undefined, fallback to transactionItem.taxValue also returns nothing, final fallback shows empty string

The PR modified the signature of getTaxName() to accept a third parameter shouldFallbackToValue = false but this wasn't utilized in the search table.