[$250] Expense - Distance unit changes when expense is removed from report.

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.28.0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #74967
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has a workspace with "Distance Rates" enabled.
Prerequisite 2: At least one rate created different than default.
Prerequisite 3: Account has Self DM.

1. Open the staging.new.expensify.com
2. Navigate to Self DM.
3. Create a map distance expense with a rate different than default.
4. Open the report of the just created expense.
5. Tap on "Report" field and select "Create Report"
6. Navigate to workspace chat and reopen report.
7. Note that distance rate and unit weren´t changed.
8. Tap on "Report" field again and select "Remove from report"
9. Navigate to Self DM and open report again.
10. Note that distance rate and unit were changed.

Expected Result:

Distance rate and unit should remain the same after moving a distanc expense to Self DM again.

Actual Result:

Distance rate and unit are changed after a distance track expense is moved to Self DM again.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7092482_1772508434916.Changes.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @cristipaval

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022028763042155909140
• Upwork Job ID: 2028763042155909140
• Last Price Increase: 2026-03-03
• Automatic offers:
• FitseTLT | Contributor | 110642887

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #74967

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #74967 - "Fix - [Unreported] Add distance rate to the distance expenses tracked in selfDM" by @FitseTLT (High confidence)
Related Issues: None

Recommendation: REVERT

PR #74967 introduced a logic error in DistanceRequestUtils.ts that causes distance expenses to lose their custom rate when moved back to Self DM (unreported). The bug is reproducible only on staging (new feature) and blocks the App deploy.

Labels: DeployBlockerCash label should be kept. This is a frontend bug requiring an App PR revert.

📋 Detailed Analysis

Evidence

The issue reports that distance rate and unit change when a distance expense is removed from a report and moved back to Self DM. This matches exactly with the functionality added in PR #74967, which was merged on 2026-02-28 and is included in the current staging deploy (9.3.28-1).

The bug report states:

• Version: 9.3.28.0
• Reproducible in staging: Yes
• Reproducible in production: N/A (new feature)
• Melvin-bot automatically assigned PR Fix - [Unreported] Add distance rate to the distance expenses tracked in selfDM #74967 as the causing PR

Verification

PR #74967 modifies src/libs/DistanceRequestUtils.ts in the getRate() function (lines 382-421). The specific problematic change is on lines 399-404:

Before PR #74967:

const customMileageRate = (customUnitRateID && mileageRates?.[customUnitRateID]) || defaultMileageRate;

After PR #74967:

const isUnreportedExpense = isExpenseUnreported(transaction);
const customMileageRate = (customUnitRateID && (mileageRates?.[customUnitRateID] ?? mileageRatesForMovingExpenses?.[customUnitRateID])) || (isUnreportedExpense ? undefined : defaultMileageRate);

Root Cause

The logic (isUnreportedExpense ? undefined : defaultMileageRate) is flawed. When an expense is moved back to Self DM (becomes unreported):

1. The expense has a customUnitRateID from when it was created with a non-default rate
2. However, that rate may not exist in the Self DM context (no policy)
3. The lookup mileageRates?.[customUnitRateID] ?? mileageRatesForMovingExpenses?.[customUnitRateID] returns undefined
4. The fallback logic sees isUnreportedExpense = true and returns undefined instead of falling back to the default rate
5. This causes the transaction to lose its custom rate and revert to P2P default

The PR attempted to handle unreported expenses specially but inadvertently broke the case where a previously-reported expense with a custom rate is moved back to Self DM.

Reproduction

Following the exact steps from the issue:

1. Create distance expense with custom rate in Self DM
2. Move to workspace report → rate preserved (correct)
3. Move back to Self DM → rate changes to default (BUG)

The bug affects all platforms (Android App, Windows Chrome, MacOS Chrome/Safari) as reported in the issue.