Fix - [Unreported] Add distance rate to the distance expenses tracked in selfDM#74967
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…field-for-track-distance-expenses
…field-for-track-distance-expenses
…field-for-track-distance-expenses
…field-for-track-distance-expenses
…field-for-track-distance-expenses
…field-for-track-distance-expenses
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Agree that mileage expenses should have a rate even when added in selfDM
|
@FitseTLT @parasharrajat, the currency edits on unreported distance requests will be disabled as part of this PR |
|
Can you please add test steps @FitseTLT? |
|
Deploy Blocker #83957 was identified to be related to this PR. |
|
Deploy Blocker #83958 was identified to be related to this PR. |
|
Deploy Blocker #83964 was identified to be related to this PR. |
|
Deploy Blocker #83969 was identified to be related to this PR. |
|
Deploy Blocker #83972 was identified to be related to this PR. |
|
Deploy Blocker #83990 was identified to be related to this PR. |
|
Deploy Blocker #84007 was identified to be related to this PR. |
|
Deploy Blocker #84006 was identified to be related to this PR. |
|
Deploy Blocker #84010 was identified to be related to this PR. |
|
Deploy Blocker #84013 was identified to be related to this PR. |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.30-0 🚀
|
…FitseTLT/feat-apply-policyForMovingExpenses-for-rate-field-for-track-distance-expenses""
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.30-3 🚀
|
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.3.31-0 🚀
|
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.3.31-12 🚀
|
Explanation of Change
Fixed Issues
$ #72230
PROPOSAL:
Tests
I) User with no group workspace
Creation flow
Edit flow
II) User with a group workspace set as the default workspace
III) User with multiple group workspaces that have the personal policy set as the default one
NOTE: To have such a user, you have to go to OldDot and make the personal policy the default workspace from there
Creation flow
Edit flow
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2025-12-06.00-56-10.mp4
Android: mWeb Chrome
2025-12-03.17-53-59.mp4
iOS: Native
2025-12-03.19-40-55.mp4
iOS: mWeb Safari
2025-12-03.17-52-46.mp4
MacOS: Chrome / Safari
2025-12-03.17-52-02.mp4