Skip to content

fix image styles in article pages #12136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luke9389 merged 8 commits into from
Oct 27, 2022
Merged

fix image styles in article pages #12136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
64f1cc2
center article images
marcochavezf Oct 25, 2022
2379e22
add img-wrap class to style 2 images
marcochavezf Oct 25, 2022
5298d92
add images to container
marcochavezf Oct 25, 2022
7ddb357
remove unused class image
marcochavezf Oct 25, 2022
b8abbbb
fix images in android chrome
marcochavezf Oct 25, 2022
983ab3f
add maxBreakpoint
marcochavezf Oct 25, 2022
fc50606
add empty space at the end of the file
marcochavezf Oct 25, 2022
da6ef2d
remove semicolon
marcochavezf Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/_sass/_breakpoints.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,9 @@ $breakpoint-wide: 1600px;
@content
}
}

@mixin maxBreakpoint($breakpoint) {
@media screen and (max-width: $breakpoint) {
@content
}
}
25 changes: 25 additions & 0 deletions docs/_sass/_main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,31 @@ button {
font-size: 2.25em;
}
}

img {
display: block;
margin-left: auto;
margin-right: auto;
padding-bottom: 20px;

@include maxBreakpoint($breakpoint-tablet) {
width: 100%;
height: 100%;
max-width: auto;
max-height: auto;
}

@include breakpoint($breakpoint-tablet) {
max-width: -webkit-fill-available;
Copy link
Contributor

@dominictb dominictb Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-webkit browsers like Firefox do not support this value, causing overflown images. See #72249

max-height: -webkit-fill-available;
}
}

.img-wrap {
display: flex;
justify-content: space-around;
flex-wrap: wrap;
}
}

.link {
Expand Down
12 changes: 7 additions & 5 deletions docs/articles/send-money/The-Free-Plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ The free plan is ideal for start-ups and small businesses to manage expenses. Wi
- Navigate to new.expensify.com, enter your company email address, and set a password
- Click the **green “+”** button and select **_New workspace_**

<img class="image" width="400" src="/assets/images/new-workspace.png">
<img width="400" src="/assets/images/new-workspace.png">

Once you’ve created your Workspace, you should receive a message from Concierge encouraging you to chat with your Setup Specialist.

<img class="image" width="800" src="/assets/images/chat-with-concierge-setup.png">
<img width="800" src="/assets/images/chat-with-concierge-setup.png">

- Click the link sent to you by Concierge, and your designated Setup Specialist will guide you through how to configure your company setup.

<img class="image" width="400" src="/assets/images/chat-with-setup-specialist.png">
<img width="800" src="/assets/images/chat-with-setup-specialist.png">

Once you’ve completed your company setup, you should have done the following:

Expand All @@ -44,8 +44,10 @@ Once you’ve completed your company setup, you should have done the following:
# Managing the Free Plan
To access your workspace settings, click your profile icon and then on your workspace name:

<img class="image" width="400" src="/assets/images/profile-settings.png">
<img class="image" width="400" src="/assets/images/workspace-settings.png">
<div class="img-wrap">
<img width="400" src="/assets/images/profile-settings.png">
<img width="400" src="/assets/images/workspace-settings.png">
</div>

This menu allows you to manage your workspace members, issue additional Expensify Cards, and utilize this plan’s various bill pay and payment options.

Expand Down
Loading