Fix janky Android splash screen by Julesssss · Pull Request #12642 · Expensify/App

Julesssss · 2022-11-10T15:23:52Z

Details

Fixes an issue where the Android Splash screen icon jumped up and down on app open. This introduces a new issue with the status bar colour, but this is being handled separately here.

Fixed Issues

$ #8236

Tests

Android only

Compile an Android release build
Completely kill and launch the app a few times
Try newer/older versions of Android
The Splash Screen icon should remain static

iOS and Android

In dark mode, the status bar icons should be white

QA Steps

Android only

Compile an Android release build
Completely kill and launch the app a few times
Try newer/older versions of Android
The Splash Screen icon should remain static

iOS and Android

In dark mode, the status bar icons should be white

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Only Android code was modified

Android

device-2022-11-28-122609.mp4

Screenshots

Dark mode

Android

Android/mWeb

iOS

iOS/mWeb

Web

Desktop

Light mode

Android

Android/mWeb

iOS

iOS/mWeb

Web

Desktop

Videos

Android 8.1 - Nexus 5x
https://user-images.githubusercontent.com/10736861/201134924-5ba9d492-78a3-4bce-8a06-7b0c6b3fa151.mp4

Android 13 - Pixel 6A
Still seems a bit janky, need to investigate further
https://user-images.githubusercontent.com/10736861/201135214-d9657e02-7c3e-4c7f-b000-46133e37f5d2.mp4

Luke9389 · 2022-11-10T22:04:01Z

Hmm, looks like pullerbear is frozen here or something

Julesssss · 2022-11-25T14:07:49Z

Hmm, looks like pullerbear is frozen here or something

Hopefully because of the PR being a WIP? Let's see what happens when the hold is removed.

melvin-bot · 2022-11-28T10:57:10Z

@aimane-chnaif @stitesExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

aimane-chnaif · 2022-11-28T11:01:03Z

Wow, Melvin already knows I would be a reviewer 😄

Julesssss · 2022-11-28T11:20:59Z

Hey @stitesExpensify & @aimane-chnaif. This is on hold, but Id would be great to get an initial code review so that I can very quickly merge this after the dark mode change PR is merged (likely today/tomorrow).

The dark mode/light mode test is only possible after I have re-merged main.

# Conflicts: # src/components/CustomStatusBar/index.android.js

Julesssss · 2022-11-28T12:28:12Z

@aimane-chnaif @stitesExpensify ignore my last message. I merged the dark mode PR so this is fully testable now. We don't really need to care about light mode right now and I created a follow up issue for this here.

mountiny

Testing this!

mountiny · 2022-11-28T14:25:09Z

src/components/CustomStatusBar/index.android.js

+import themeColors from '../../styles/themes/default';
 import {StatusBar} from 'react-native';


@Julesssss There is a linter issue here

mountiny · 2022-11-28T14:27:01Z

Reviewer Checklist

I have tested on Android and iOS since this code only changes Android specific codebase and also the test steps mentioned to check iOS

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

appPull12642Android.mov

mountiny

Thanks!

mountiny · 2022-11-28T14:58:20Z

I think we can push this one forward so merging.

melvin-bot · 2022-11-28T14:58:38Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2022-11-28T14:59:38Z

Not an emergency, the Jobs failing should be fixed here #13078

aimane-chnaif · 2022-11-28T14:59:39Z

@Julesssss on devices with embedded bottom navigation bar and in device light mode, screen doesn't look good

device dark mode:

device light mode:

aimane-chnaif · 2022-11-28T15:00:20Z

oh @mountiny too early to merge

OSBotify · 2022-11-28T15:03:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2022-11-28T15:05:21Z

Hey @aimane-chnaif thanks for raising that, I'll look into that as a separate issue.

aimane-chnaif · 2022-11-28T15:06:59Z

Hey @aimane-chnaif thanks for raising that, I'll look into that as a separate issue.

ok I suggest to add navigationBarColor in xml attribute (same color as status bar maybe?)

Julesssss · 2022-11-28T15:08:15Z

Yeah, this is a simple attribute fix but I'm going to keep it internal. Issue here.

mountiny · 2022-11-28T15:08:39Z

Oh apologies, thanks for testing @aimane-chnaif

I think we can look at these quirks in new issues to just keep things going forward

OSBotify · 2022-11-28T21:20:30Z

🚀 Deployed to staging by @mountiny in version: 1.2.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-28T22:24:38Z

🚀 Deployed to staging by @mountiny in version: 1.2.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

aimane-chnaif · 2022-11-29T00:15:45Z

@Julesssss @mountiny I also found another issue while testing. composer input is hidden by keyboard for the height of status bar

OSBotify · 2022-11-29T19:36:49Z

🚀 Deployed to staging by @mountiny in version: 1.2.33-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-30T04:01:58Z

🚀 Deployed to production by @luacmartins in version: 1.2.33-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-30T04:26:31Z

🚀 Deployed to production by @luacmartins in version: 1.2.33-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix janky Android splash screen

cfb429e

Julesssss self-assigned this Nov 10, 2022

Julesssss mentioned this pull request Nov 10, 2022

[$4000] Logo shifts to bottom (Bootsplash) when launched - reported by Ekram Khan #8236

Closed

Julesssss added 6 commits November 18, 2022 15:50

Merge branch 'main' into jules-fixAndroidSplashIcon

61f8aa3

revert the sidebar to the same theme as every other page

2eafe92

remove the sidebar background colour change

c43eb99

Merge branch 'main' into jules-fixAndroidSplashIcon

4bd04a5

remove hardcoded status bar colour

bc139dc

use theme colour for status bar, to prepare for dark theme

7a4b244

Julesssss changed the title ~~Fix janky Android splash screen~~ [HOLD on 12944 for further changes] Fix janky Android splash screen Nov 24, 2022

hardcode white status until we merge dark theme

b4d8a6a

Julesssss mentioned this pull request Nov 28, 2022

Make the Switch to Dark Mode #12944

Merged

100 tasks

Julesssss marked this pull request as ready for review November 28, 2022 10:56

Julesssss requested a review from a team as a code owner November 28, 2022 10:56

Julesssss removed the request for review from a team November 28, 2022 10:56

melvin-bot bot requested review from aimane-chnaif and stitesExpensify November 28, 2022 10:57

Julesssss changed the title ~~[HOLD on 12944 for further changes] Fix janky Android splash screen~~ Fix janky Android splash screen Nov 28, 2022

Julesssss added 2 commits November 28, 2022 11:41

Merge branch 'main' into jules-fixAndroidSplashIcon

8d7068c

# Conflicts: # src/components/CustomStatusBar/index.android.js

hardcode the android status bar

f5e8d12

Julesssss mentioned this pull request Nov 28, 2022

Implement fully translucent Android status bar #13082

Closed

mountiny reviewed Nov 28, 2022

View reviewed changes

fix invalid RN import order

f87c948

mountiny approved these changes Nov 28, 2022

View reviewed changes

mountiny merged commit a58b6a0 into main Nov 28, 2022

mountiny deleted the jules-fixAndroidSplashIcon branch November 28, 2022 14:58

melvin-bot bot added the Emergency label Nov 28, 2022

mountiny removed the Emergency label Nov 28, 2022

OSBotify mentioned this pull request Nov 28, 2022

Deploy Checklist: New Expensify 2022-11-28 #13099

Closed

26 tasks

0xmiroslav mentioned this pull request Nov 29, 2022

[HOLD for payment 2022-12-08] Android -Chat - The compose field is covered by keyboard #13111

Closed

0xmiroslav mentioned this pull request Dec 15, 2022

[HOLD for payment] [$500] Android - Composer is hidden by native emoji picker - Reported by @rushatgabhane #10483

Closed

		import themeColors from '../../styles/themes/default';
		import {StatusBar} from 'react-native';

Conversation

Julesssss commented Nov 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots

Android

Screenshots

Dark mode

Light mode

Videos

Uh oh!

Luke9389 commented Nov 10, 2022

Uh oh!

Julesssss commented Nov 25, 2022

Uh oh!

melvin-bot bot commented Nov 28, 2022

Uh oh!

aimane-chnaif commented Nov 28, 2022

Uh oh!

Julesssss commented Nov 28, 2022

Uh oh!

Julesssss commented Nov 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Nov 28, 2022

Choose a reason for hiding this comment

Uh oh!

mountiny commented Nov 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Nov 28, 2022

Uh oh!

melvin-bot bot commented Nov 28, 2022

Uh oh!

mountiny commented Nov 28, 2022

Uh oh!

aimane-chnaif commented Nov 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aimane-chnaif commented Nov 28, 2022

Uh oh!

OSBotify commented Nov 28, 2022

Uh oh!

Julesssss commented Nov 28, 2022

Uh oh!

aimane-chnaif commented Nov 28, 2022

Uh oh!

Julesssss commented Nov 28, 2022

Uh oh!

mountiny commented Nov 28, 2022

Uh oh!

OSBotify commented Nov 28, 2022

Uh oh!

OSBotify commented Nov 28, 2022

Uh oh!

aimane-chnaif commented Nov 29, 2022

Uh oh!

OSBotify commented Nov 29, 2022

Uh oh!

OSBotify commented Nov 30, 2022

Uh oh!

OSBotify commented Nov 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Julesssss commented Nov 10, 2022 •

edited

Loading

Julesssss commented Nov 28, 2022 •

edited

Loading

mountiny commented Nov 28, 2022 •

edited

Loading

aimane-chnaif commented Nov 28, 2022 •

edited

Loading