Simplify the PDF renderer for the Web#1521
Conversation
|
Let me know any styling-related feedback. I added some based on my observations. the Components accepts the CC: @shawnborton |
marcaaron
left a comment
There was a problem hiding this comment.
Nice start. We'll need @shawnborton to help explain what kinds of UI additions we need (if any).
|
This looks pretty great to me. Do we have control over the color that is used as the background gray behind the PDF content? |
|
@shawnborton. Yes, I have tried to keep all the functionality the same. so we were passing a style prop previously which can set the styles which take gray as default. |
|
Great, could we see this with |
|
@shawnborton Which one do you like? I would say gray2 is looking best. Just added a commit for text selection on PDF. |
|
I do like |
|
Is something remaining on this PR? |
|
yep, will give another review once @shawnborton OK the design we've got. |
|
Yup, I'm good with the design and with |
|
Updated. @marcaaron Please review. |
marcaaron
left a comment
There was a problem hiding this comment.
👍 awesome work on this one!




@marcaaron Please review.
Details
Fixed Issues
Fixes #1383 Fixes #1514Tests
Send a Pdf in the chat and click it to see the attachment modal.
Tested On
Screenshot
Web
Mobile Web