Always use the non proxy url when we need a true link back to expensify.com or com.dev#1509
Merged
Always use the non proxy url when we need a true link back to expensify.com or com.dev#1509
Conversation
Contributor
Author
|
cc @parasharrajat this should fix your issue |
5 tasks
Contributor
Author
|
Bumping this one. Another contributor has run into this issue. Which reminded me that this was still here. |
Contributor
|
Sorry, totally missed this somehow. Next time feel free to bump it much sooner. |
iwiznia
approved these changes
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixes issue causing contributors to not be able to access PDFs
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/154722
Tests
Tested On
This issue only affects web
Screenshots
Web
Mobile Web
Desktop
iOS
Android