Download attachments in the chat by SameeraMadushan · Pull Request #1585 · Expensify/App

SameeraMadushan · 2021-02-27T18:28:38Z

Details

This feature contains download functionality for any type of attachments (images, pdf)

The file download function is a reusable function that is laid in the src/libs/fileDownload

iOS and Android follows index.native.js that is developed with rn-fetch-blob
Web, Desktop, and mobile web follows index.js that is developed with fetch and blob
Filename will auto-generated with a timestamp

Fixed Issues

Fixes #1040

Tests

iOS

UIFileSharingEnabled and LSSupportsOpeningDocumentsInPlace enabled in info.plist to save downloaded files to document folder.
FIles can be accessed through Files app on the iOS device
Separate folder will create for attachments (Expensify.cash)
Since multiple types of attachment downloads there, Images won't be shown in the gallery.
Alert will show when the file is downloaded
Otherwise, it will show an error alert

Android

WRITE_EXTERNAL_STORAGE and READ_EXTERNAL_STORAGE enabled in the AndroidMenifest.xml
User will be asked to allow storage permission if already not given
When the user allows the permission download will start
Android Download Manager will show a notification in the status bar
Files will be saved in the storage's Downloads/Expensify folder
Images will be displayed in the gallery under downloads

Web, Desktop, and Mobile web

The user can open the attachment and click the download button
Then after the download window appear, the user can select a location and save the file

Tested On

Screenshots

Desktop

Image download

Pdf download

Web

Image download

Pdf download

iOS (Simulator)

Image download

Pdf download

Downloaded files

Android

Permission dialog

Image download

Pdf download

Downloaded files

bondydaa

Just a couple of comments but also going to have someone more familiar give a look at the native stuff.

ios/Podfile.lock

bondydaa · 2021-03-02T04:40:48Z

src/libs/fileDownload/index.js

+            );
+
+            // creating anchor tag to initiate download
+            const link = document.createElement('a');


I was really confused here and thought "there's no way this is the best way to download something in 2021, right?" but after doing some searching uh ya I guess it still is 🤯 https://davidwalsh.name/javascript-download

Yes right?
I was also searching for a better way to do that. But found this is still valid.

src/libs/fileDownload/index.js

bondydaa

great thanks for those updates 👍 all you @AndrewGable (or re-assign to someone who might have more native knowledge 🙏 )

bondydaa · 2021-03-02T18:59:42Z

oh looks like conflicts in the Podfile.lock and Expensicons.js

….cash into sameera-download-image-from-chat

SameeraMadushan · 2021-03-02T20:03:23Z

@bondydaa Just fix conflicts. Got a pull from the upstream master. have a look. 👍🏻

bondydaa · 2021-03-02T20:18:46Z

ios/Podfile.lock

    - React-Core
  - RNCAsyncStorage (1.12.1):
    - React-Core
-  - RNCPicker (1.9.11):


hmm looks like this was just added and merged a few hours ago here https://github.com/Expensify/Expensify.cash/pull/1553/files

sounds like you need to npx pod-install to fix? cc @marcaaron ?

I did pod install and RNCPicker got removed. What can be the case?
Even in the master when I do pod install, It's getting removed from pod.lock

Okay.. since the picker is newly added, I need to do run npm install. Then only pod install.

I pulled master, ran npm install in the root then cd ios/ && pod install and looks like I'm getting the same changes so something is messed up. Asking in our Slack to try and get it figured out

okay sorry for the delay. I'm pretty sure this https://github.com/Expensify/Expensify.cash/pull/1553/files was done wrong and what you have here is correct.

Looking at https://artsy.github.io/blog/2016/05/03/podspec-checksums/ and https://romainbrunie.medium.com/podfile-lock-87df8c744dc6 helped show me how to confirm the checksum. only thing to note is we install the pods into the repo directory instead of a global ~/.cocoapods.

Expensidev/Expensify.cash (master) $ pod ipc spec ios/Pods/Local\ Podspecs/react-native-document-picker.podspec.json | openssl sha1 b3e78a8f7fef98b5cb069f20fc35797d55e68e28

looks like another conflict in the podfile.lock 😭 so if you could pull master again, npm i && cd ios && pod install and repush.

I'll merge to once conflicts are gone. Thanks for bearing with me.

@bondydaa please check now.. 😊

….cash into sameera-download-image-from-chat

SameeraMadushan added 9 commits February 27, 2021 01:41

Adding a download button

8d3ac6e

adding camera roll package

0f76538

Button visibility check

80b4b10

Enable file sharing on iOS

ad3c3f7

Read external storage permission enabled

beb6557

Attachment download on iOS and android

b9607f2

Removing camera roll package

def5639

Attachment download on web and desktop

392e12c

Check android read write permission

e3b3a53

SameeraMadushan requested a review from a team as a code owner February 27, 2021 18:28

botify requested review from bondydaa and removed request for a team February 27, 2021 18:28

SameeraMadushan added 2 commits February 28, 2021 00:32

rn-fetch-blob mock for jest

2ea6b8e

Changed jes.mock to jest.fn

752eec4

bondydaa assigned SameeraMadushan Mar 2, 2021

bondydaa suggested changes Mar 2, 2021

View reviewed changes

bondydaa requested a review from AndrewGable March 2, 2021 04:47

Adding display none to link and cleanup href

049f6c0

SameeraMadushan requested a review from bondydaa March 2, 2021 17:19

bondydaa previously approved these changes Mar 2, 2021

View reviewed changes

Merge branch 'master' of https://github.com/SameeraMadushan/Expensify…

7b4131c

….cash into sameera-download-image-from-chat

SameeraMadushan dismissed bondydaa’s stale review via 7b4131c March 2, 2021 20:02

bondydaa reviewed Mar 2, 2021

View reviewed changes

Merge conflict fix

fa1de20

AndrewGable previously approved these changes Mar 3, 2021

View reviewed changes

Merge branch 'master' of https://github.com/SameeraMadushan/Expensify…

48738e2

….cash into sameera-download-image-from-chat

SameeraMadushan dismissed AndrewGable’s stale review via 48738e2 March 3, 2021 04:42

bondydaa approved these changes Mar 3, 2021

View reviewed changes

bondydaa merged commit 653750d into Expensify:master Mar 3, 2021

github-actions bot locked and limited conversation to collaborators Mar 3, 2021

Conversation

SameeraMadushan commented Feb 27, 2021 • edited by bondydaa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

iOS

Android

Web, Desktop, and Mobile web

Tested On

Screenshots

Desktop

Web

iOS (Simulator)

Android

Uh oh!

bondydaa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bondydaa left a comment

Choose a reason for hiding this comment

Uh oh!

bondydaa commented Mar 2, 2021

Uh oh!

SameeraMadushan commented Mar 2, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bondydaa Mar 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SameeraMadushan commented Feb 27, 2021 •

edited by bondydaa

Loading

bondydaa Mar 3, 2021 •

edited

Loading