Revert: 17138 17360 listen keydown from user #17475

tienifr · 2023-04-15T08:56:24Z

Details

Straight revert of #17138 and #17360

Note: It will reintroduce this issue #16098 since this will revert the fix there.

Fixed Issues

$ #17413
$ #17138 (comment)
$ #17428 (comment)
$ #17478

Tests

Validate the issues linked in Fixed Issues are fixed:

Open any chat that already has some messages (or open an empty chat and send some messages there)
Click on top of a message to remove focus from the composer
[Web&Desktop] Start typing some characters in the keyboard (letters, numbers and so on but not Enter/Shift/Ctrl/...)
[Web&Desktop] Make sure you the composer is not focused and whatever you typed isn't sent to the composer box
Make sure you can send a message successfully
Make sure you can edit a message content successfully
Make sure you can react to a message and search for an emoji using the keyboard
Make sure that when you try to react to a message by clicking on the "Add reaction" icon that you can also click on the "Change default skin tone" option and that typing with your keyboard focus on the emoji search.
Make sure you can send an emoji in your message, also make sure that you can search for an emoji using the keyboard
Make sure you can copy and paste content into and from the composer box using Ctrl+C/Cmd+C and Ctrl+V/Cmd+V
Make sure the search feature in the LNH is working

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Validate the issues linked in Fixed Issues are fixed:

Open any chat that already has some messages (or open an empty chat and send some messages there)
Click on top of a message to remove focus from the composer
[Web&Desktop] Start typing some characters in the keyboard (letters, numbers and so on but not Enter/Shift/Ctrl/...)
[Web&Desktop] Make sure you the composer is not focused and whatever you typed isn't sent to the composer box
Make sure you can send a message successfully
Make sure you can edit a message content successfully
Make sure you can react to a message and search for an emoji using the keyboard
Make sure that when you try to react to a message by clicking on the "Add reaction" icon that you can also click on the "Change default skin tone" option and that typing with your keyboard focus on the emoji search.
Make sure you can send an emoji in your message, also make sure that you can search for an emoji using the keyboard
Make sure you can copy and paste content into and from the composer box using Ctrl+C/Cmd+C and Ctrl+V/Cmd+V
Make sure the search feature in the LNH is working

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

N/A since it's a straight revert

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

…poser" This reverts commit 3cac462, reversing changes made to 8fd518c.

This reverts commit f496b9f, reversing changes made to 34c5155.

MelvinBot · 2023-04-15T09:04:21Z

@PauloGasparSv @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

PauloGasparSv · 2023-04-17T12:35:27Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- [x ] iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-04-17.at.14.39.58.mov

Mobile Web - Chrome

Screen.Recording.2023-04-17.at.14.56.19.mov

Mobile Web - Safari

Screen.Recording.2023-04-17.at.15.17.30.mov

Desktop

Screen.Recording.2023-04-17.at.15.19.29.mov

iOS

Screen.Recording.2023-04-17.at.15.15.00.mov

Android

Screen.Recording.2023-04-17.at.14.53.28.mov

rushatgabhane · 2023-04-17T12:36:23Z

@tienifr looks like we have conflicts

tienifr · 2023-04-17T15:04:19Z

@rushatgabhane I've resolved the conflicts. Please take a look

PauloGasparSv · 2023-04-17T17:39:38Z

Can we maybe add these as the QA/Test steps? I think we should specify everything here in the P.R.!

Open any chat that already has some messages (or open an empty chat and send some messages there)

Click on top of a message to remove focus from the composer

[Web&Desktop] Start typing some characters in the keyboard (letters, numbers and so on but not Enter/Shift/Ctrl/...)

[Web&Desktop] Make sure you the composer is not focused and whatever you typed isn't sent to the composer box

Make sure you can send a message successfully

Make sure you can edit a message content successfully

Make sure you can react to a message and search for an emoji using the keyboard

Make sure that when you try to react to a message by clicking on the "Add reaction" icon that you can also click on the "Change default skin tone" option and that typing with your keyboard focus on the emoji search.

Make sure you can send an emoji in your message, also make sure that you can search for an emoji using the keyboard

Make sure you can copy and paste content into and from the composer box using Ctrl+C/Cmd+C and Ctrl+V/Cmd+V

Make sure the search feature in the LNH is working

tienifr · 2023-04-17T18:15:10Z

Can we maybe add these as the QA/Test steps? I think we should specify everything here in the P.R.!

@PauloGasparSv sure thing, updated.

PauloGasparSv

LGTM!

@thesahindia can we merge this?

github-actions · 2023-04-17T18:26:51Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

mountiny

Looking good to me , thanks @PauloGasparSv and @tienifr for pushing this forwards!

PauloGasparSv · 2023-04-17T18:32:02Z

I think 2 reviews are enough here so merging this!

…own-from-user Revert: 17138 17360 listen keydown from user (cherry picked from commit 86f7eff)

OSBotify · 2023-04-17T20:54:07Z

🚀 Cherry-picked to staging by https://github.com/PauloGasparSv in version: 1.3.0-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-04-17T22:57:35Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.0-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:33:31Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:51:15Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 2 commits April 15, 2023 15:50

Revert "Merge pull request Expensify#17360 from rushatgabhane/fix-com…

8c0f610

…poser" This reverts commit 3cac462, reversing changes made to 8fd518c.

Revert "Merge pull request Expensify#17138 from tienifr/fix/16098"

d82c654

This reverts commit f496b9f, reversing changes made to 34c5155.

tienifr marked this pull request as ready for review April 15, 2023 09:04

tienifr requested a review from a team as a code owner April 15, 2023 09:04

melvin-bot bot requested review from PauloGasparSv and thesahindia and removed request for a team April 15, 2023 09:04

tienifr mentioned this pull request Apr 15, 2023

[HOLD for payment 2023-07-21] [$2000] Selecting a chat message and pressing any key focus the message instead of switching the focus to the composer. #16098

Closed

6 tasks

rushatgabhane mentioned this pull request Apr 16, 2023

[HOLD for payment 2023-04-26] [HOLD for payment 2023-04-24] Focus is set to composer and I'm able to type in it when RHN is opened #17478

Closed

6 tasks

PauloGasparSv assigned tienifr Apr 17, 2023

PauloGasparSv mentioned this pull request Apr 17, 2023

[$1000] Pressing space key scrolls chat and brings focus to the composer #17465

Closed

6 tasks

fix: merge main

51d2787

PauloGasparSv mentioned this pull request Apr 17, 2023

Use DOM activeElement instead of event target in composer focus logic #17428

Closed

56 tasks

fix: merge main

7e0bcb4

bernhardoj mentioned this pull request Apr 17, 2023

Create a common function to insert an emoji into a text #17346

Merged

56 tasks

Merge branch 'main' into revert/17138-17360-listen-keydown-from-user

ff34f20

PauloGasparSv approved these changes Apr 17, 2023

View reviewed changes

mountiny added the CP Staging label Apr 17, 2023

mountiny approved these changes Apr 17, 2023

View reviewed changes

PauloGasparSv merged commit 86f7eff into Expensify:main Apr 17, 2023

OSBotify pushed a commit that referenced this pull request Apr 17, 2023

Merge pull request #17475 from tienifr/revert/17138-17360-listen-keyd…

f509aed

…own-from-user Revert: 17138 17360 listen keydown from user (cherry picked from commit 86f7eff)

OSBotify mentioned this pull request Apr 17, 2023

🍒 Cherry pick PR #17475 to staging 🍒 #17528

Merged

OSBotify mentioned this pull request Apr 17, 2023

Deploy Checklist: New Expensify 2023-04-13 #17379

Closed

26 tasks

MelvinBot mentioned this pull request Apr 17, 2023

[HOLD for payment 2023-04-26] [HOLD for payment 2023-04-24] Web - Chat - Typing from emoji picker also fills composer input unnecessarily #17413

Closed

6 tasks

OSBotify mentioned this pull request Apr 18, 2023

Deploy Checklist: New Expensify 2023-04-17 #17546

Closed

53 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

Revert: 17138 17360 listen keydown from user #17475

Revert: 17138 17360 listen keydown from user #17475

Uh oh!

Conversation

tienifr commented Apr 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Apr 15, 2023

Uh oh!

PauloGasparSv commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane commented Apr 17, 2023

Uh oh!

tienifr commented Apr 17, 2023

Uh oh!

PauloGasparSv commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Apr 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PauloGasparSv left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 17, 2023

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

PauloGasparSv commented Apr 17, 2023

Uh oh!

OSBotify commented Apr 17, 2023

Uh oh!

OSBotify commented Apr 17, 2023

Uh oh!

OSBotify commented Jun 15, 2023

Uh oh!

OSBotify commented Jun 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tienifr commented Apr 15, 2023 •

edited

Loading

PauloGasparSv commented Apr 17, 2023 •

edited

Loading

PauloGasparSv commented Apr 17, 2023 •

edited

Loading

tienifr commented Apr 17, 2023 •

edited

Loading