Skip to content

🍒 Cherry pick PR #17475 to staging 🍒 #17528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thienlnam merged 3 commits into from
Apr 17, 2023
Merged

🍒 Cherry pick PR #17475 to staging 🍒 #17528

thienlnam merged 3 commits into from
Apr 17, 2023

Conversation

@OSBotify
Copy link
Contributor

@OSBotify OSBotify commented Apr 17, 2023

🍒 Cherry pick #17475 to staging 🍒

OSBotify and others added 2 commits April 17, 2023 18:45
@OSBotify
Merge pull request #17526 from Expensify/version-BUILD-854C81FE-0D38-…
c46b05f 
…4227-B02B-AF0C7A8E1938

Update version to 1.3.0-2 on main

(cherry picked from commit df39a90)
@PauloGasparSv @OSBotify
Merge pull request #17475 from tienifr/revert/17138-17360-listen-keyd…
f509aed 
…own-from-user

Revert: 17138 17360 listen keydown from user
(cherry picked from commit 86f7eff)
@OSBotify OSBotify requested a review from a team as a code owner April 17, 2023 18:45
@melvin-bot melvin-bot bot removed request for a team April 17, 2023 18:45
@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 17, 2023

This pull request has merge conflicts and can not be automatically merged. 😞
Please manually resolve the conflicts, push your changes, and then request another reviewer to review and merge.
Important: There may be conflicts that GitHub is not able to detect, so please carefully review this pull request before approving.

@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Apr 17, 2023

Taking a look at this rn

@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Apr 17, 2023

I don't feel comfortable merging this without a review so I asked for one in engineering-chat and will assign someone from puller bear here.

@PauloGasparSv PauloGasparSv requested a review from a team April 17, 2023 19:23
@melvin-bot melvin-bot bot requested review from thienlnam and removed request for a team April 17, 2023 19:23
@MelvinBot
Copy link
Contributor

MelvinBot commented Apr 17, 2023

@thienlnam Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@thienlnam
Copy link
Contributor

thienlnam commented Apr 17, 2023

Looks good, going to make sure it still builds correctly

@thienlnam
Copy link
Contributor

thienlnam commented Apr 17, 2023

Screenshot 2023-04-17 at 12 39 28 PM

Changes look fine and builds alright!

@thienlnam thienlnam merged commit 5837f67 into staging Apr 17, 2023
@thienlnam thienlnam deleted the OSBotify-cherry-pick-staging-17475 branch April 17, 2023 19:39
This was referenced Apr 17, 2023
Closed
Closed
Closed
@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 17, 2023

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.3.0-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

OSBotify commented Apr 17, 2023

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.0-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 15, 2023

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 16, 2023

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thienlnam thienlnam thienlnam approved these changes

Assignees

@PauloGasparSv PauloGasparSv

Labels

automerge Engineering Hourly KSv2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@OSBotify @PauloGasparSv @MelvinBot @thienlnam