Merged
Conversation
AndrewGable
changed the title
Contributor
|
@tgolen - Ready for review! |
tgolen
requested changes
Aug 15, 2020
src/page/HomePage/SidebarView.js
Outdated
| constructor(props) { | ||
| super(props); | ||
|
|
||
| this.openTestFlightLink = this.openTestFlightLink.bind(this); |
Contributor
There was a problem hiding this comment.
These don't need to be bound because there is no references to this inside the methods.
src/page/HomePage/SidebarView.js
Outdated
| <View style={[styles.flexRow]}> | ||
| <Text | ||
| style={[styles.sidebarFooterLink, styles.mr2]} | ||
| onPress={this.openTestFlightLink} |
Contributor
There was a problem hiding this comment.
Since there is no logic happening in the method, I wouldn't bother with those methods, and just change this to:
Suggested change
| onPress={this.openTestFlightLink} | |
| onPress={Linking.openURL('https://testflight.apple.com/join/vBYbMRQG')} |
Better yet... we could create an <Anchor href="https://testflight.apple.com/join/vBYbMRQG"> component which could be reused quite a bit I think.
Contributor
|
Updated with |
Contributor
|
Ah, conflicts :( |
Contributor
|
Fixed conflicts! |
8 tasks
Closed
7 tasks
This was referenced Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added links that open to TestFlight & latest APK.
Fixes #93