17013 - migrate OptionRow to PressableWithFeedback #19612

Skalakid · 2023-05-25T15:47:13Z

Details

Fixed Issues

$ 17013
PROPOSAL: 17013

Tests

This component is used in many places, you can test it by checking the list of users that

reacted with specific emoji
are members of a workspace
are in the group chat
in your workspace (list with the invite and remove buttons)

Steps that I took:

Log in
Enter a group chat
Click its name, to see its details
Click Members
Now you should see the list of users that uses the OptionRow component. Verify if these buttons work fine

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

web-mobile-chrome.mov

Mobile Web - Safari

web-mobile-safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

melvin-bot · 2023-05-25T15:47:45Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

arosiclair · 2023-05-30T13:46:36Z

@Skalakid make sure to assign yourself when creating PRs. Some of our automation depends on that. @robertKozik could you do the checklist for this as well?

robertKozik · 2023-05-30T16:49:50Z

Sure, I'll do it later today

robertKozik

Please change these two thing and It should be GTG

robertKozik · 2023-05-30T20:52:54Z

src/components/OptionRow.js

+                            accessibilityLabel={this.props.option.text}
+                            accessibilityRole="button"
+                            hoverDimmingValue={1}
+                            pressDimmingValue={0.8}


the current default value for press opacity is the same

App/src/styles/variables.js

Line 143 in 79ddcab

pressDimValue: 0.8,

robertKozik · 2023-05-30T20:58:23Z

src/components/OptionRow.js

@@ -174,6 +174,10 @@ class OptionRow extends Component {
                                this.props.isDisabled && styles.cursorDisabled,


I know it wasn't changed in your PR, but this style is now redundant as PressableWithFeedback is managing it itself. Thus this line can be removed.

robertKozik · 2023-05-31T09:41:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

desktop.-.web.mov

Mobile Web - Chrome

android.-.web.mov

Mobile Web - Safari

iOS.-.web.mov

Desktop

desktop.-.native.mov

iOS

iOS.-.native.mov

Android

android.-.native.mov

robertKozik · 2023-05-31T09:57:21Z

@Skalakid I've found one inconsistency. With the new implementation if the optionRow is in keyboard focus and then hovered the blue border is dismissed. In the old one it stayed
steps to repro:

Enter a group chat
Click its name, to see its details
Click Members
With tab key focus the optionRow
Hover focused row with mouse

CC. @arosiclair

OLD

old.mov

NEW

new.mov

Skalakid · 2023-05-31T10:54:18Z

@arosiclair I've added a fix for the on-focus styling problem, that @robertKozik mentioned above. To prevent the blue border from disappearing I changed the focus style to be the same as the hover style. With this on-focused style looks more standardized, what do you think about it?

Nagranie.z.ekranu.2023-05-31.o.12.54.53.mov

arosiclair · 2023-05-31T16:19:26Z

Hmm I think preferably we just apply both the focus border and hover highlight. It looks like PressibleWithFeedback should be able to apply both. Why isn't it working here?

Skalakid · 2023-06-01T15:57:46Z

Hmm I think preferably we just apply both the focus border and hover highlight. It looks like PressibleWithFeedback should be able to apply both. Why isn't it working here?

The blue border is rendered by a web browser, I believe. We are adding styles to OpacityView so they are rendering above the blue border. I think we can apply both blue border and custom styles by passing them to the GenericPressable and using hoverStyle and focusStyle props. However, it can limit our styling possibilities because in this situation we would have only one child - OpacityView, not the ones that we passed.
But I've replaced the blue border in #19660 and I got design acceptance (comment) so I think it can be like that :D

arosiclair · 2023-06-02T14:43:57Z

But I've replaced the blue border in #19660 and I got design acceptance (#19660 (comment)) so I think it can be like that :D

Fair enough let's move forward with that!

robertKozik · 2023-06-07T08:04:36Z

Looks good 🚀 Reviewer checklist is now filled @arosiclair all yours

OSBotify · 2023-06-07T18:02:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-08T17:02:21Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.26-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

isagoico · 2023-06-09T13:16:19Z

This PR QA is failing because of this issue #20513

OSBotify · 2023-06-13T00:23:03Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.26-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Christinadobrzyn · 2023-06-13T19:15:18Z

This might be a regression - #20585

@Skalakid @arosiclair could you take a peek?

kushu7 · 2023-06-14T18:05:52Z

While we are working on this #19766
There was no highlight on Press/longPress on OptionRow in mWeb . but This PR introduced it.
@Skalakid Can you take look at it?

WhatsApp.Video.2023-06-14.at.11.28.43.PM.mp4

allroundexperts · 2023-06-21T23:27:44Z

src/components/OptionRow.js

These changes resulted in the following regression #19612. We probably forgot to test this case.

s77rt · 2023-06-23T10:58:43Z

src/components/OptionRow.js

                            accessibilityRole="button"
                            hoverDimmingValue={1}
                            hoverStyle={this.props.hoverStyle}
+                            focusStyle={this.props.hoverStyle}


This caused a regression #20585

migrate OptionRow to PressableWithFeedback

338484d

Skalakid requested a review from a team as a code owner May 25, 2023 15:47

melvin-bot bot requested review from arosiclair and removed request for a team May 25, 2023 15:47

Skalakid added 2 commits May 26, 2023 10:16

fixed dimming

45904c5

removed comment

55e9f71

arosiclair assigned Skalakid May 30, 2023

robertKozik suggested changes May 30, 2023

View reviewed changes

review changes

bc87400

Skalakid requested a review from robertKozik May 31, 2023 07:57

removed unnecessary changes

0d2d2c1

robertKozik previously approved these changes May 31, 2023

View reviewed changes

fixed styling on focus

36c0e4b

Skalakid dismissed robertKozik’s stale review via 36c0e4b May 31, 2023 10:48

Skalakid requested a review from robertKozik May 31, 2023 10:48

Skalakid mentioned this pull request May 31, 2023

17014 - migrate OptionRowLHN to PressableWithFeedback #19660

Closed

57 tasks

Merge branch 'main' into 17013-migrate-OptionRow

d73c965

robertKozik approved these changes Jun 7, 2023

View reviewed changes

arosiclair approved these changes Jun 7, 2023

View reviewed changes

arosiclair merged commit a292aa9 into Expensify:main Jun 7, 2023

OSBotify mentioned this pull request Jun 8, 2023

Deploy Checklist: New Expensify 2023-06-08 #20466

Closed

74 tasks

kbecciv mentioned this pull request Jun 9, 2023

[HOLD for payment 2023-06-28] [$1000] mweb - Chat - Reaction list does not appear after navigating to chat from member detail #20513

Closed

6 tasks

kushu7 mentioned this pull request Jun 10, 2023

fire hover event on supported devices only #20432

Closed

57 tasks

bernhardoj mentioned this pull request Jun 13, 2023

[HOLD for payment 2023-06-29] Web - Split Bill - Money request confirmation list stays highlighted after press #20585

Closed

6 tasks

Skalakid mentioned this pull request Jun 15, 2023

fix: 20585 - Web - Split Bill - Money request confirmation list stays highlighted after press #20838

Merged

57 tasks

allroundexperts mentioned this pull request Jun 21, 2023

[$1000] [HOLD for payment 2023-06-21] [HOLD for payment 2023-06-19] WS - Members list - Tooltip “Blocked” appears when user moves cursor over usernames / avatars #20495

Closed

6 tasks

allroundexperts reviewed Jun 21, 2023

View reviewed changes

s77rt reviewed Jun 23, 2023

View reviewed changes

dukenv0307 mentioned this pull request Jun 24, 2023

[C+ Checklist Needs Completion] [$1000] Keyboard navigation and selection is inconsistent in Split Bill UI #21392

Closed

6 tasks

		@@ -174,6 +174,10 @@ class OptionRow extends Component {
		this.props.isDisabled && styles.cursorDisabled,

17013 - migrate OptionRow to PressableWithFeedback #19612

17013 - migrate OptionRow to PressableWithFeedback #19612

Uh oh!

Conversation

Skalakid commented May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented May 25, 2023

Uh oh!

arosiclair commented May 30, 2023

Uh oh!

robertKozik commented May 30, 2023

Uh oh!

robertKozik left a comment

Choose a reason for hiding this comment

Uh oh!

robertKozik May 30, 2023

Choose a reason for hiding this comment

Uh oh!

robertKozik May 30, 2023

Choose a reason for hiding this comment

Uh oh!

robertKozik commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

robertKozik commented May 31, 2023

Uh oh!

Skalakid commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arosiclair commented May 31, 2023

Uh oh!

Skalakid commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arosiclair commented Jun 2, 2023

Uh oh!

robertKozik commented Jun 7, 2023

Uh oh!

OSBotify commented Jun 7, 2023

Uh oh!

OSBotify commented Jun 8, 2023

Uh oh!

isagoico commented Jun 9, 2023

Uh oh!

OSBotify commented Jun 13, 2023

Uh oh!

Christinadobrzyn commented Jun 13, 2023

Uh oh!

kushu7 commented Jun 14, 2023

Uh oh!

allroundexperts Jun 21, 2023

Choose a reason for hiding this comment

Uh oh!

s77rt Jun 23, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Skalakid commented May 25, 2023 •

edited

Loading

robertKozik commented May 31, 2023 •

edited

Loading

Skalakid commented May 31, 2023 •

edited

Loading

Skalakid commented Jun 1, 2023 •

edited

Loading