Fix: Mention does not show beam on selection #20447

tienifr · 2023-06-08T11:04:11Z

Details

Mention does not show I beam on selection which is not consistent with other pressable links. This PR fixes that.

Fixed Issues

$ #19303
PROPOSAL: #19303 (comment)

Tests

Login with any account
Open any report
Send a message with mention and text
Click and drag to highlight the whole message (including the mention)
Verify that the cursor is I beam while selecting the mention

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Login with any account
Open any report
Send a message with mention and text
Click and drag to highlight the whole message (including the mention)
Verify that the cursor is I beam while selecting the mention

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screencast.from.08-06-2023.18.04.33.webm

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-06-09.at.11.34.50.mov

iOS

Android

melvin-bot · 2023-06-12T15:51:03Z

@joelbettner @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joelbettner · 2023-06-13T16:53:34Z

src/components/TextLink.js

 };

 const TextLink = (props) => {
+    const rest = _.omit(props, _.keys(propTypes));


I just want to make sure I understand what is happening here...

When we call TextLink and pass props, the rest variable is going to contain all the props that are not in the propTyles defined above.

Then, we are adding the props that are in rest to the props that we are sending to Text below.

Is that all correct?

Yes, it is.

joelbettner · 2023-06-13T18:07:15Z

@eVoloshchak all yours.

…mention-not-show-beam-on-selection

eVoloshchak · 2023-06-14T12:55:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-14.at.16.04.29.mov

Mobile Web - Chrome

screen-20230614-161146.mp4

Mobile Web - Safari

Screen.Recording.2023-06-14.at.16.12.11.mov

Desktop

Screen.Recording.2023-06-14.at.16.08.18.mov

iOS

Screen.Recording.2023-06-14.at.16.09.23.mov

Android

screen-20230614-161334.mp4

eVoloshchak

Tests well!

OSBotify · 2023-06-14T18:18:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-14T21:24:59Z

🚀 Deployed to staging by https://github.com/joelbettner in version: 1.3.28-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	failure ❌

Julesssss · 2023-06-15T14:10:41Z

it looks like this PR might have introduced this regression, could you both please double-check? It's the only PR merged to staging that touches mention text.

eVoloshchak · 2023-06-15T15:27:06Z

Confirmed this PR has caused the regression, specifically the usage of href prop for Text(Link)

joelbettner · 2023-06-15T16:22:45Z

@tienifr Can you work on a the fix for this ASAP, please?

tienifr · 2023-06-15T16:34:08Z

Yay, working on it.

tienifr · 2023-06-15T19:05:57Z

We have two regressions:

[HOLD for payment 2023-06-28] [$1000] Inconsistent behavior when copying mentions with different methods #20814
[HOLD for payment 2023-06-28] Font color is blue instead of white in mention #20819

I think the second one is more severe but easy to fix so should be prioritized. Its PR is up here #20845.

On the other hand, the first one seems a little bit tricky and needs more investigation so I'll continue working on that and push the PR later.

cc @eVoloshchak @joelbettner

tienifr · 2023-06-16T10:44:52Z

The first regression's PR is up #20894.

OSBotify · 2023-06-16T18:40:06Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 2 commits June 8, 2023 17:59

fix tooltip

e097e78

fix lint

7b64076

tienifr marked this pull request as ready for review June 12, 2023 15:50

tienifr requested a review from a team as a code owner June 12, 2023 15:50

melvin-bot bot requested review from eVoloshchak and joelbettner and removed request for a team June 12, 2023 15:51

tienifr mentioned this pull request Jun 12, 2023

[HOLD for payment 2023-06-28] [HOLD for payment 2023-06-23] [$1000] Cursor does not change to I beam on selecting mentions like it does for other clickable links #19303

Closed

6 tasks

joelbettner reviewed Jun 13, 2023

View reviewed changes

joelbettner previously approved these changes Jun 13, 2023

View reviewed changes

tienifr added 2 commits June 14, 2023 10:19

Merge branch 'main' of https://github.com/tienifr/App into fix/19303-…

0ba8fbc

…mention-not-show-beam-on-selection

Merge 'main' into fix/19303

f24fb4f

tienifr dismissed joelbettner’s stale review via f24fb4f June 14, 2023 03:22

eVoloshchak approved these changes Jun 14, 2023

View reviewed changes

joelbettner approved these changes Jun 14, 2023

View reviewed changes

joelbettner merged commit 7f936b7 into Expensify:main Jun 14, 2023

OSBotify mentioned this pull request Jun 14, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

This was referenced Jun 15, 2023

Fix: Wrong text color for our mention #20845

Merged

Fix: Mention is selected as anchor tag #20894

Merged

sobitneupane mentioned this pull request Jun 21, 2023

[HOLD for payment 2023-06-28] [$1000] Inconsistent behavior when copying mentions with different methods #20814

Closed

6 tasks

Fix: Mention does not show beam on selection #20447

Fix: Mention does not show beam on selection #20447

Uh oh!

Conversation

tienifr commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 12, 2023

Uh oh!

joelbettner Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

tienifr Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

joelbettner commented Jun 13, 2023

Uh oh!

eVoloshchak commented Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jun 14, 2023

Uh oh!

OSBotify commented Jun 14, 2023

Uh oh!

Julesssss commented Jun 15, 2023

Uh oh!

eVoloshchak commented Jun 15, 2023

Uh oh!

joelbettner commented Jun 15, 2023

Uh oh!

tienifr commented Jun 15, 2023

Uh oh!

tienifr commented Jun 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tienifr commented Jun 16, 2023

Uh oh!

OSBotify commented Jun 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tienifr commented Jun 8, 2023 •

edited

Loading

eVoloshchak commented Jun 14, 2023 •

edited

Loading

tienifr commented Jun 15, 2023 •

edited

Loading