#10148 — The message got sent but it also stayed in the compose box by robertKozik · Pull Request #22227 · Expensify/App

robertKozik · 2023-07-04T21:53:14Z

Details

This PR introduces new clearing input mechanic for sending messages. It utilize the reanimated worklets to run code on native UI thread, when JS thread tends to be occupied

Fixed Issues

$ #10148
PROPOSAL: #10148 (comment)

Tests

Open any chat
Start typing
Press send
Right after pressing the send icon, start typing again quickly
Verify that text from input is cleared

Verify that no errors appear in the JS console

Offline tests

Same as Test steps

QA Steps

Same as Test steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-13.at.20.18.14.mov

Mobile Web - Chrome

Screen.Recording.2023-07-13.at.20.28.27.mov

Mobile Web - Safari

Screen.Recording.2023-07-13.at.20.16.06.mov

Desktop

Screen.Recording.2023-07-13.at.20.33.01.mov

iOS

Screen.Recording.2023-07-11.at.19.05.09.mov

Android

Screen.Recording.2023-07-12.at.12.32.41.mov

ahmdshrif · 2023-07-07T05:11:22Z

src/pages/home/report/ReportActionCompose.js

I know this is still a draft, but as far as I know, in React Native for iOS, the text input switches between single-line and multi-line input. So, if the name is mandatory to update, it may cause some issues with multi-line input.

here is the source of the code in react native :
https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Components/TextInput/TextInput.js#L1412-L1416

and it may have a different name in Android I think it's AndroidTextInput .

what do you think?

…ared

melvin-bot · 2023-07-17T06:31:13Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-07-18T11:54:00Z

On clicking the send message button, the app keeps crashing for me on the release build.
Investigating..

robertKozik · 2023-07-18T12:09:01Z

I'll check it too. maybe after fixing tests I've broke something. On which platform does it occur for you? @rushatgabhane

robertKozik · 2023-07-18T12:15:05Z

Yeah my bad, will fix it!

rushatgabhane

Thanks for the fix! Tests well and the composer feels fluid to use

Requesting a few minor style changes

src/pages/home/report/ReportActionCompose.js

src/components/withAnimatedRef.js

src/components/RNTextInput.js

rename aref to animatedRef Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>

robertKozik · 2023-07-18T20:52:50Z

Hi @rushatgabhane ! All review requests are implemented and conflicts resolved 🚀

rushatgabhane · 2023-07-21T15:01:24Z

Thank you! Reviewing

rushatgabhane · 2023-07-21T15:42:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-21.at.22.40.20.mov

Mobile Web - Chrome

WhatsApp.Video.2023-07-21.at.21.26.48.mp4

Mobile Web - Safari

Screen.Recording.2023-07-21.at.23.40.25.mov

Desktop

Screen.Recording.2023-07-21.at.23.45.10.mov

iOS

Screen.Recording.2023-07-21.at.22.33.38.mov

Screen.Recording.2023-07-21.at.22.35.13.mov

Android

WhatsApp.Video.2023-07-21.at.21.14.21.mp4

Multiline -

WhatsApp.Video.2023-07-21.at.21.22.03.mp4

ahmdshrif · 2023-07-21T15:45:13Z

src/pages/home/report/ReportActionCompose.js

+                'worklet';
+
+                const viewTag = animatedRef();
+                const viewName = 'RCTMultilineTextInputView';


is the view name important for _updatePropsPaper?
because i still think this is not the correct name in Android.
as I remember it was something like AndroidTextInput.

It’s relevant only for iOS, on Android this argument is ignored.

rushatgabhane

LGTM! (storybook tests well too)

rushatgabhane · 2023-07-25T10:43:01Z

All yours @AndrewGable

robertKozik · 2023-07-26T13:44:27Z

@AndrewGable bumping

OSBotify · 2023-07-26T16:16:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-27T22:07:25Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

src/pages/home/report/ReportActionCompose.js

OSBotify · 2023-07-31T18:35:54Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.47-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

c3024 · 2023-08-03T17:22:45Z

Did this fix the issue in iOS as well? On Dev, on iOS app, I found the message still stays in the composer if i click send quickly and then keep typing text.

Screen.Recording.2023-08-03.at.10.51.57.PM.mov

rushatgabhane · 2023-09-05T04:45:33Z

src/pages/home/report/ReportActionCompose.js

+        const animatedRef = this.props.animatedRef;
+        const setCommentEmpty = () => this.setState({isCommentEmpty: true});
+        const Tap = Gesture.Tap()
+            .enabled(!(this.state.isCommentEmpty || isBlockedFromConcierge || this.props.disabled || hasExceededMaxCommentLength))


Hi, this PR caused a bug. The cursor is not of type disabled when the composer is disabled.

More details here - #23848 (comment)

ahmdshrif reviewed Jul 7, 2023

View reviewed changes

robertKozik added 7 commits July 13, 2023 19:55

create HOC with useAnimatedRef hook

061d889

clear composer on UI thread

e9c4d12

prettier

506cc93

change animatedRed propType

5f783cd

set isCommentEmpty state to true when native state of composer is cle…

e4a7b21

…ared

remove buttonSuccess style when button is pressed

8b3ed48

make _updatePropsPaper to be native only

8b1c0fd

robertKozik force-pushed the 8k branch from f43c9f4 to 8b1c0fd Compare July 13, 2023 17:59

prettier

8eebf0d

robertKozik force-pushed the 8k branch from 3a64099 to 5ab79c5 Compare July 16, 2023 21:00

fix tests

e30c445

robertKozik force-pushed the 8k branch from 5ab79c5 to e30c445 Compare July 16, 2023 21:04

revert the accessibilityRole change

009cb95

robertKozik marked this pull request as ready for review July 17, 2023 06:31

robertKozik requested a review from a team as a code owner July 17, 2023 06:31

melvin-bot bot removed the request for review from a team July 17, 2023 06:31

melvin-bot bot requested a review from rushatgabhane July 17, 2023 06:31

check platform in ReportActionCompose constructor

67b7b6c

rushatgabhane suggested changes Jul 18, 2023

View reviewed changes

src/pages/home/report/ReportActionCompose.js Outdated Show resolved Hide resolved

src/pages/home/report/ReportActionCompose.js Outdated Show resolved Hide resolved

src/components/withAnimatedRef.js Show resolved Hide resolved

src/components/RNTextInput.js Show resolved Hide resolved

robertKozik and others added 6 commits July 18, 2023 18:19

rename aref to animatedRef

c79734f

rename aref to animatedRef Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>

fix usage of animatedRef

b010637

hoist platform-specific code to different files

91d6855

add coment why animated component is used

eef185e

fix forwardRef console error on web

1d5279f

Merge branch 'main' into 8k

9e4deb5

robertKozik requested a review from rushatgabhane July 18, 2023 21:38

ahmdshrif reviewed Jul 21, 2023

View reviewed changes

rushatgabhane approved these changes Jul 21, 2023

View reviewed changes

melvin-bot bot requested a review from AndrewGable July 21, 2023 18:18

AndrewGable approved these changes Jul 26, 2023

View reviewed changes

AndrewGable merged commit 46fb873 into Expensify:main Jul 26, 2023

OSBotify mentioned this pull request Jul 27, 2023

Deploy Checklist: New Expensify 2023-07-27 #23765

Closed

79 tasks

shubham1206agra mentioned this pull request Jul 31, 2023

Refactor EmojiPickerMenu native to functional component and using scrollTo method #23854

Merged

57 tasks

Beamanator reviewed Jul 31, 2023

View reviewed changes

src/pages/home/report/ReportActionCompose.js Show resolved Hide resolved

Beamanator mentioned this pull request Jul 31, 2023

[HOLD for payment 2023-08-21] [$1000] Web -Pointer cursor is displayed on send button even when compose box is empty #23848

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 31, 2023

[HOLD for payment 2023-08-07] [$8000] The message got sent but it also stayed in the compose box #10148

Closed

rushatgabhane reviewed Sep 5, 2023

View reviewed changes

hoangzinh mentioned this pull request Oct 16, 2023

[TS migration] Migrate 'withAnimatedRef.js' HOC to TypeScript - Remove dead code #29443

Merged

59 tasks

Delgee mentioned this pull request May 4, 2024

[Hold for 40548] [$500] iOS - Chat - Send button is not responding after viewing avatar in full screen #40797

Closed

6 tasks

j-piasecki mentioned this pull request May 27, 2024

[HOLD on #40548] [$250] iOS - Send button is not responsive after returning from transaction thread #41528

Closed

6 tasks

Conversation

robertKozik commented Jul 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

ahmdshrif Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Jul 17, 2023

Uh oh!

rushatgabhane commented Jul 18, 2023

Uh oh!

robertKozik commented Jul 18, 2023

Uh oh!

robertKozik commented Jul 18, 2023

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robertKozik commented Jul 18, 2023

Uh oh!

rushatgabhane commented Jul 21, 2023

Uh oh!

rushatgabhane commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ahmdshrif Jul 21, 2023

Choose a reason for hiding this comment

Uh oh!

tomekzaw Jul 24, 2023

Choose a reason for hiding this comment

Uh oh!

rushatgabhane left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Jul 25, 2023

Uh oh!

robertKozik commented Jul 26, 2023

Uh oh!

OSBotify commented Jul 26, 2023

Uh oh!

OSBotify commented Jul 27, 2023

Uh oh!

Uh oh!

OSBotify commented Jul 31, 2023

Uh oh!

c3024 commented Aug 3, 2023

Uh oh!

rushatgabhane Sep 5, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

robertKozik commented Jul 4, 2023 •

edited

Loading

rushatgabhane commented Jul 21, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading