Fix all offline created transaction is deleted when we delete one of the transaction by bernhardoj · Pull Request #27306 · Expensify/App

bernhardoj · 2023-09-13T05:47:28Z

Details

Deleting one transaction will delete the whole iou that is optimistically created while offline.

Fixed Issues

$ #24366
PROPOSAL: #24366 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open any chat without outstanding IOU
Turn off the internet connection
Request money from the chat twice
Click the request preview to open IOU report
Delete the second request/transaction
Verify the second request is pending delete (currently, the pending delete shows a skeleton, there is an issue for this, but I forgot the link)
Verify the IOU report and other request/transaction is not deleted

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-13.at.13.07.02.mov

Mobile Web - Chrome

Screen.Recording.2023-09-13.at.13.14.13.mov

Mobile Web - Safari

Screen.Recording.2023-09-13.at.13.15.37.mov

Desktop

Screen.Recording.2023-09-13.at.13.09.27.mov

iOS

Screen.Recording.2023-09-13.at.13.16.21.mov

Android

Screen.Recording.2023-09-13.at.13.10.29.mov

melvin-bot · 2023-09-13T05:47:33Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-09-13T06:20:36Z

The issue also happens on split bill, so I fixed it too.

Screen.Recording.2023-09-13.at.13.46.25.mov

bernhardoj · 2023-09-13T06:21:19Z

tests/actions/IOUTest.js

                                    // The CREATED action should not be created after the IOU action
-                                    expect(Date.parse(createdAction.created)).toBeLessThanOrEqual(Date.parse(iouAction.created));
+                                    expect(Date.parse(createdAction.created)).toBeLessThan(Date.parse(iouAction.created));



Fortunately we already have the unit test, but it uses toBeLessThanOrEqual, so I changed it to toBeLessThan.

bernhardoj · 2023-09-13T06:22:01Z

tests/actions/IOUTest.js

                                    // The CREATED action should not be created after the IOU action
-                                    expect(Date.parse(createdAction.created)).toBeLessThanOrEqual(Date.parse(iouAction.created));
+                                    expect(Date.parse(iouCreatedAction.created)).toBeLessThan(Date.parse(iouAction.created));



I changed it from createdAction to iouCreatedAction because createdAction is the CREATED action of the chat report, not the iou report, otherwise it will fail.

bernhardoj · 2023-09-13T06:22:45Z

tests/actions/IOUTest.js

                                    expect(julesIOUAction.originalMessage.type).toBe(CONST.IOU.REPORT_ACTION_TYPE.CREATE);
-                                    expect(Date.parse(julesCreatedAction.created)).toBeLessThanOrEqual(Date.parse(julesIOUAction.created));
+                                    expect(Date.parse(julesIOUCreatedAction.created)).toBeLessThan(Date.parse(julesIOUAction.created));



Same reason as above

bernhardoj · 2023-09-13T06:22:52Z

tests/actions/IOUTest.js

                                    expect(carlosIOUAction.originalMessage.type).toBe(CONST.IOU.REPORT_ACTION_TYPE.CREATE);
-                                    expect(Date.parse(carlosCreatedAction.created)).toBeLessThanOrEqual(Date.parse(carlosIOUAction.created));
+                                    expect(Date.parse(carlosIOUCreatedAction.created)).toBeLessThan(Date.parse(carlosIOUAction.created));



Same reason as above

eVoloshchak · 2023-09-15T09:44:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-12.at.17.57.45.mov

Mobile Web - Chrome

screen-20231012-202624.mp4

Mobile Web - Safari

Screen.Recording.2023-10-12.at.20.19.24.mov

Desktop

Screen.Recording.2023-10-12.at.20.29.43.mov

iOS

Screen.Recording.2023-10-12.at.20.15.47.mov

Android

screen-20231012-205544.mp4

eVoloshchak

Bug:

Open any chat without outstanding IOU
Turn off the internet connection
Request money from the chat twice
Click the request preview to open IOU report
Delete the second request/transaction
Verify the second request is pending delete (currently, the pending delete shows a skeleton, there is an issue for this, but I forgot the link)
Verify the IOU report and other request/transaction is not deleted
Turn the internet back again
Notice the IOU report still says "2 requests"
Click the request preview to open IOU report, notice you're presented with Hmm... it's not here page and the IOU report disappears from LHN

Screen.Recording.2023-09-15.at.14.05.07.mov

bernhardoj · 2023-09-15T16:25:16Z

@eVoloshchak it's most likely a BE issue.

When you logout and login back, you will see the (undefined) iou disappears from the chat. The only guess I have is, on the BE, the whole IOU report is deleted when we delete the 2nd transaction.

We are fixing this in the FE, but looks like the same issue happened on BE?

The root cause could be different because the delete money request only send transactionID and reportActionID

App/src/libs/actions/IOU.js

Lines 1376 to 1383 in 83b3f5d

    
           API.write( 
        
               'DeleteMoneyRequest', 
        
               { 
        
                   transactionID, 
        
                   reportActionID: reportAction.reportActionID, 
        
               }, 
        
               {optimisticData, successData, failureData}, 
        
           );

The sequence of the request is:
Request Money 1, Request Money 2, Delete Money Request 2

and somehow the Delete Money Request 2 delete the whole IOU on the BE.

bernhardoj · 2023-10-12T07:02:00Z

@eVoloshchak I totally forgot about this PR. I just retested and looks like the BE issue is resolved. Can you retest it to make sure it is fixed?

Screen.Recording.2023-10-12.at.14.56.11.mov

eVoloshchak · 2023-10-12T14:06:10Z

@bernhardoj, I can see 2 issues with this

When we delete a request, it says Cash $0.00 instead of a blank skeleton UI
The total amount requested (in LHN) isn't updated until you go back online and go back to the original chat

bernhardoj · 2023-10-12T14:12:13Z

It is a known issue. Looks like they are okay with that.
Hmm, can you share the video? From my video, you can see the total on LHN is updated.

eVoloshchak · 2023-10-12T14:21:56Z

@bernhardoj, I was incorrect about the "go back to the original chat" part, it's updated when you go back online (the delay confused me)

Screen.Recording.2023-10-12.at.16.15.17.mov

eVoloshchak · 2023-10-12T14:24:43Z

Actually, looks like this has been already resolved in prod, @bernhardoj, could you double-check that, please?

Screen.Recording.2023-10-12.at.16.23.44.mov

bernhardoj · 2023-10-12T14:32:05Z

@eVoloshchak You need to create the request while offline

Screen.Recording.2023-10-12.at.22.29.51.mov

eVoloshchak

LGTM

eVoloshchak · 2023-10-16T11:08:05Z

@bondydaa, gentle bump on this

bernhardoj · 2023-10-19T02:53:27Z

@bondydaa ready for your review

bernhardoj · 2023-10-25T05:40:37Z

@bondydaa gentle bump

OSBotify · 2023-10-26T18:26:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-26T22:59:11Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.92-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-30T07:42:29Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.92-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-30T08:03:26Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.3.93-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-31T21:36:35Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj added 2 commits September 13, 2023 13:20

fix iou CREATED and transaction action created time is the same

cff45ee

fix iou CREATED and transaction action created time is the same

d7a37cd

bernhardoj requested a review from a team as a code owner September 13, 2023 05:47

melvin-bot bot requested review from eVoloshchak and removed request for a team September 13, 2023 05:47

update test

702c960

bernhardoj commented Sep 13, 2023

View reviewed changes

fix var is not defined

9548e2a

eVoloshchak suggested changes Sep 15, 2023

View reviewed changes

Merge branch 'main' into fix/24366-iou-transaction

70e7830

eVoloshchak mentioned this pull request Sep 15, 2023

[HOLD for payment 2023-11-06] [$1000] IOU - All IOUs created in offline mode disappear when the second IOU is deleted #24366

Closed

6 tasks

Merge branch 'main' into fix/24366-iou-transaction

df77b50

eVoloshchak approved these changes Oct 12, 2023

View reviewed changes

melvin-bot bot requested a review from bondydaa October 12, 2023 18:58

bondydaa approved these changes Oct 26, 2023

View reviewed changes

bondydaa merged commit 6c2e087 into Expensify:main Oct 26, 2023

OSBotify mentioned this pull request Oct 26, 2023

Deploy Checklist: New Expensify 2023-10-26 #30469

Closed

64 tasks

OSBotify mentioned this pull request Oct 30, 2023

Deploy Checklist: New Expensify 2023-10-30 #30560

Closed

Conversation

bernhardoj commented Sep 13, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 13, 2023

Uh oh!

bernhardoj commented Sep 13, 2023

Uh oh!

bernhardoj Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

bernhardoj Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

bernhardoj Sep 13, 2023

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Sep 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Sep 15, 2023

Uh oh!

bernhardoj commented Oct 12, 2023

Uh oh!

eVoloshchak commented Oct 12, 2023

Uh oh!

bernhardoj commented Oct 12, 2023

Uh oh!

eVoloshchak commented Oct 12, 2023

Uh oh!

eVoloshchak commented Oct 12, 2023

Uh oh!

bernhardoj commented Oct 12, 2023

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Oct 16, 2023

Uh oh!

bernhardoj commented Oct 19, 2023

Uh oh!

bernhardoj commented Oct 25, 2023

Uh oh!

OSBotify commented Oct 26, 2023

Uh oh!

OSBotify commented Oct 26, 2023

Uh oh!

OSBotify commented Oct 30, 2023

Uh oh!

OSBotify commented Oct 30, 2023

Uh oh!

OSBotify commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bernhardoj Sep 13, 2023 •

edited

Loading

eVoloshchak commented Sep 15, 2023 •

edited

Loading