Fix/27165: don't allow go to next step if empty waypoint by DylanDylann · Pull Request #28308 · Expensify/App

DylanDylann · 2023-09-27T08:35:06Z

Details

In distance request, prevent request money if empty waypoint

Fixed Issues

$ #27383
PROPOSAL: #27383 (comment)

Tests

Request money -> distance
Change /distance in the URL to /participants
Verify that the App redirect to Distance request page

Verify that no errors appear in the JS console

Offline tests

Same above

QA Steps

Request money -> distance
Change /distance in the URL to /participants
Verify that the App redirect to Distance request page

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-resize.mp4

Mobile Web - Chrome

chrome-resize.mp4

Mobile Web - Safari

safari-resize.mp4

Desktop

Screen.Recording.2023-09-20.at.11.08.00.mp4

iOS

ios-resize.mp4

Android

android-resize.mp4

melvin-bot · 2023-09-27T08:35:11Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tgolen

Thank you for using withOnyx to load the transaction!

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

allroundexperts · 2023-10-02T10:41:45Z

Hi @DylanDylann!
Can you please make sure to upload the latest screen recording? The ones you've uploaded currently looks like the same as your original PR.

DylanDylann · 2023-10-03T04:05:43Z

@allroundexperts @tgolen Currently, We have a general bug that relates to shouldReset logic as mentioned in #26946 (comment) and #28566

Context:

Go to Distance Request -->
Fill start point and finish point -->
Go to Participant Page -->
Go to Confirmation Page -->
Go back 2 times to Distance Request -->
Click Next Button

After step 3, id field in iou will be request${reportID of participant}. When clicking next button at step 6, we miss reportID of previous participant

App/src/libs/actions/IOU.js

Line 2252 in c415f7b

const shouldReset = iou.id !== moneyRequestID;

It makes shouldReset is true and iou field is reset, all data is lost

DylanDylann · 2023-10-03T04:57:59Z

IMO, we should hold this PR until #26538 is resolved

tgolen · 2023-10-03T13:33:05Z

Yeah, either we should hold this PR until my refactorings are done, or merge this PR with the known shouldReset bug. It's up to you.

DylanDylann · 2023-10-03T14:05:17Z

@tgolen I think we should hold this PR to avoid unexpected behavior for users. If it is ok, please help to hold this PR. Thanks

tgolen · 2023-10-13T16:24:46Z

Just an FYI that my PR went into review yesterday.

DylanDylann · 2023-10-20T09:25:50Z

@allroundexperts It seems there are no blocker now, could you help to check? thanks

DylanDylann · 2023-10-23T18:16:11Z

Bump @allroundexperts Could you help to take a look at this issue?

allroundexperts · 2023-10-24T00:12:13Z

@DylanDylann I think we need to remove the Hold label before proceeding with the PR review. @tgolen Can you please remove the hold?

DylanDylann · 2023-10-24T00:14:57Z

@allroundexperts It seems some other change makes this PR no longer hold. I can remove the hold label now

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

DylanDylann · 2023-10-27T03:11:43Z

@allroundexperts Bump please help to take a look at this PR. Thanks

DylanDylann · 2023-10-30T05:22:17Z

@allroundexperts Bump could you help to check this PR?

tgolen · 2023-10-30T13:40:24Z

I'm not sure why this was taken off HOLD. The PR that it was held on has not been merged.

Yeah, either we should hold this PR until my refactorings are done, or merge this PR with the known shouldReset bug. It's up to you.

Did you decide to move ahead with merging this with the known shouldReset bug @DylanDylann?

DylanDylann · 2023-10-30T15:22:31Z

@tgolen We decided to hold this PR because of this reason. But in some days ago, I re-tested this PR and saw that It works well. It seems some recent changes make this PR isn't blocked anymore.

tgolen · 2023-10-30T16:03:36Z

OK, as long as the shouldReset bug isn't an issue, I'm fine with that. Thanks for explaining!

DylanDylann · 2023-10-31T04:52:54Z

@allroundexperts Bump, please help to check this PR? Thanks

allroundexperts · 2023-11-02T15:39:39Z

On it today!

allroundexperts · 2023-11-02T15:46:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-11-02.at.8.57.57.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-11-02.at.9.14.07.PM.mov

Mobile Web - Safari

Screen.Recording.2023-11-02.at.9.14.57.PM.mov

Desktop

Screen.Recording.2023-11-02.at.9.22.50.PM.mov

iOS

Screen.Recording.2023-11-02.at.9.16.18.PM.mov

Android

Screen.Recording.2023-11-02.at.9.18.16.PM.mov

allroundexperts

Tests well!

OSBotify · 2023-11-04T16:16:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-06T22:31:43Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:49:16Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-10T15:45:54Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.97-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

DylanDylann added 2 commits September 27, 2023 15:31

don't allow go to next step if empty waypoint

e14ba5d

merge main

fe3a3f1

DylanDylann requested a review from a team as a code owner September 27, 2023 08:35

melvin-bot bot requested review from allroundexperts and removed request for a team September 27, 2023 08:35

DylanDylann mentioned this pull request Sep 27, 2023

Fix/27383: Prevent request money if empty waypoint #27826

Merged

59 tasks

DylanDylann added 4 commits September 27, 2023 15:45

fix lint

0e23a7b

fix lint issue

537af3d

fix cannot read property undefined transactionID

add0863

fix optional chaining

bab3fc8

tgolen reviewed Sep 28, 2023

View reviewed changes

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js Outdated Show resolved Hide resolved

DylanDylann added 2 commits September 28, 2023 13:14

merge main

f4ee68b

make logic more accurate

8c3526d

DylanDylann changed the title ~~Fix/27165: don't allow go to next step if empty waypoint~~ [HOLD 26538] Fix/27165: don't allow go to next step if empty waypoint Oct 5, 2023

joekaufmanexpensify mentioned this pull request Oct 9, 2023

[HOLD for payment 2023-10-09] [$500] [Distance] - Ability to request money without filling start and finish points #27383

Closed

6 tasks

DylanDylann mentioned this pull request Oct 12, 2023

[$500] Deeplinking to distantce request money allows requesting 0 amount #29401

Closed

6 tasks

DylanDylann mentioned this pull request Oct 19, 2023

[HOLD for payment 2024-01-17] [$500] Distance - Able to request money by distance by adding a stop same as finish point without enterring start point From #29895

Closed

6 tasks

DylanDylann added 2 commits October 19, 2023 15:22

merge main

7dfeba7

Merge branch 'main' into fix/27165-after-revert

808f9da

DylanDylann changed the title ~~[HOLD 26538] Fix/27165: don't allow go to next step if empty waypoint~~ Fix/27165: don't allow go to next step if empty waypoint Oct 24, 2023

allroundexperts reviewed Oct 26, 2023

View reviewed changes

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js Show resolved Hide resolved

DylanDylann force-pushed the fix/27165-after-revert branch from dfec7b7 to 808f9da Compare October 26, 2023 07:01

merge main

cf69f71

merge main

3f34924

DylanDylann added 3 commits October 30, 2023 12:37

fix lint

0719a89

fix lint

087f909

fix lint

80d1013

allroundexperts approved these changes Nov 3, 2023

View reviewed changes

melvin-bot bot requested a review from roryabraham November 3, 2023 03:30

tgolen approved these changes Nov 3, 2023

View reviewed changes

roryabraham approved these changes Nov 4, 2023

View reviewed changes

roryabraham merged commit 846a4b7 into Expensify:main Nov 4, 2023

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

kbecciv mentioned this pull request Nov 7, 2023

Chat - Participants screen briefly shown and distance page opens few times after opening link #30936

Closed

6 tasks

situchan mentioned this pull request Nov 7, 2023

[HOLD for payment 2023-11-17] [$500] The app crashes when taping on link https://staging.new.expensify.com/request/new/participants #30933

Closed

6 tasks

OSBotify mentioned this pull request Nov 8, 2023

Deploy Checklist: New Expensify 2023-11-08 #31077

Closed

Conversation

DylanDylann commented Sep 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 27, 2023

Uh oh!

tgolen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

allroundexperts commented Oct 2, 2023

Uh oh!

DylanDylann commented Oct 3, 2023

Uh oh!

DylanDylann commented Oct 3, 2023

Uh oh!

tgolen commented Oct 3, 2023

Uh oh!

DylanDylann commented Oct 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgolen commented Oct 13, 2023

Uh oh!

DylanDylann commented Oct 20, 2023

Uh oh!

DylanDylann commented Oct 23, 2023

Uh oh!

allroundexperts commented Oct 24, 2023

Uh oh!

DylanDylann commented Oct 24, 2023

Uh oh!

Uh oh!

DylanDylann commented Oct 27, 2023

Uh oh!

DylanDylann commented Oct 30, 2023

Uh oh!

tgolen commented Oct 30, 2023

Uh oh!

DylanDylann commented Oct 30, 2023

Uh oh!

tgolen commented Oct 30, 2023

Uh oh!

DylanDylann commented Oct 31, 2023

Uh oh!

allroundexperts commented Nov 2, 2023

Uh oh!

allroundexperts commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Nov 4, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

OSBotify commented Nov 9, 2023

Uh oh!

OSBotify commented Nov 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DylanDylann commented Sep 27, 2023 •

edited

Loading

DylanDylann commented Oct 3, 2023 •

edited

Loading

allroundexperts commented Nov 2, 2023 •

edited

Loading