[No QA] [TS migration] Migrate 'ReportActionsUtils.js' lib to TypeScript by fabioh8010 · Pull Request #28570 · Expensify/App

fabioh8010 · 2023-10-01T21:53:30Z

Details

Fixed Issues

$ #24910
PROPOSAL: N/A

Tests

Report actions testing

Send a message
React to the message
Reply something in thread
Edit the message
Delete the message
Request money
Edit money request
Delete the money request
Create a task
Mark it as complete
Mark it as incomplete
Cancel the task
Pay an IOU

Offline tests

Send a message
React to the message
Reply something in thread
Edit the message
Send another message
Delete the message
Request money
Edit money request
Request money again
Delete the money request
Create a task
Mark it as complete
Mark it as incomplete
Cancel the task
Pay an IOU

QA Steps

Same as above.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-01.at.21.58.21.mp4

Screen.Recording.2023-10-01.at.22.04.32.mp4

Desktop

Screen.Recording.2023-10-01.at.22.09.40.mp4

Mobile Web - Chrome

Screen.Recording.2023-10-01.at.22.15.19.mp4

Android

Screen.Recording.2023-10-01.at.22.20.47.mp4

Mobile Web - Safari

Screen.Recording.2023-10-01.at.22.28.26.mp4

iOS

Screen.Recording.2023-10-01.at.22.34.19.mp4

…tils

src/libs/actions/IOU.js

src/languages/types.ts

src/types/onyx/ReportAction.ts

rezkiy37

LGTM, after resolving comments.

…tils

fabioh8010 · 2023-10-05T14:17:40Z

FYI I will be on vacations starting tomorrow for the next two weeks and will return on Oct 23, so @kubabutkiewicz will replace me on this PR!

src/libs/actions/IOU.js

blazejkustra · 2023-10-05T13:59:41Z

src/libs/ReportActionsUtils.ts

+import {ValueOf} from 'type-fest';
 import CONST from '../CONST';
 import ONYXKEYS from '../ONYXKEYS';
+import * as OnyxTypes from '../types/onyx';


NAB: I would import types a bit different:

import ReportActions from '../../types/onyx/ReportActions';

blazejkustra · 2023-10-05T14:01:23Z

src/libs/ReportActionsUtils.ts

-        _.has(reportAction.originalMessage, 'IOUDetails')
-    );
+function isSentMoneyReportAction(reportAction: OnyxEntry<OnyxTypes.ReportAction>): boolean {
+    return reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && reportAction.originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.PAY && !!reportAction.originalMessage.IOUDetails;


Suggested change

return reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && reportAction.originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.PAY && !!reportAction.originalMessage.IOUDetails;

return reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && reportAction?.originalMessage?.type === CONST.IOU.REPORT_ACTION_TYPE.PAY && !!reportAction?.originalMessage?.IOUDetails;

blazejkustra · 2023-10-05T14:03:34Z

src/libs/ReportActionsUtils.ts

-        (originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.CREATE || (originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.PAY && _.has(originalMessage, 'IOUDetails')))
+        parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU &&
+        (parentReportAction.originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.CREATE ||
+            (parentReportAction.originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.PAY && !!parentReportAction.originalMessage.IOUDetails))


Logic was changed here on purpose? originalMessage.type -> parentReportAction.originalMessage.type

Actually there is no logic change, here Fabio just removed const originalMessage = lodashGet(parentReportAction, 'originalMessage', {});

and just use parentReportAction.originalMessage etc

blazejkustra · 2023-10-05T14:50:21Z

src/libs/ReportActionsUtils.ts

-function isCreatedTaskReportAction(reportAction) {
-    return reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && _.has(reportAction.originalMessage, 'taskReportID');
+function isCreatedTaskReportAction(reportAction: OnyxEntry<OnyxTypes.ReportAction>): boolean {
+    return reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && Boolean(reportAction.originalMessage?.taskReportID);


Suggested change

return reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && Boolean(reportAction.originalMessage?.taskReportID);

return reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ADDCOMMENT && !!reportAction.originalMessage?.taskReportID;

blazejkustra · 2023-10-05T14:51:54Z

src/libs/ReportActionsUtils.ts

+    if (reportAction && Object.hasOwn(reportAction, 'isAttachment')) {
+        // The condition asserts "isAttachment" exists.
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+        return reportAction.isAttachment!;
+    }


Suggested change

if (reportAction && Object.hasOwn(reportAction, 'isAttachment')) {

// The condition asserts "isAttachment" exists.

// eslint-disable-next-line @typescript-eslint/no-non-null-assertion

return reportAction.isAttachment!;

}

if (reportAction && 'isAttachment' in reportAction) {

return reportAction.isAttachment ?? false;

}

kubabutkiewicz · 2023-10-11T07:35:33Z

@blazejkustra comments are resolved, can you recheck?

melvin-bot · 2023-10-11T11:03:42Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kubabutkiewicz · 2023-10-11T15:12:53Z

@thesahindia Hi, will you be able to check it asap? this is a blocker for few other TS migrations and would be perfect to merge it soon 😄

thesahindia · 2023-10-12T21:42:28Z

Hey @fabioh8010, can you please resolve the conflicts?

…b/ReportActionsUtils

kubabutkiewicz · 2023-10-13T07:13:21Z

@thesahindia resolved

thesahindia · 2023-10-13T18:20:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-13.at.2.46.14.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-10-13.at.3.09.21.AM.mov

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-10-13.at.23.19.45.mp4

Desktop

Screen.Recording.2023-10-13.at.2.56.03.AM.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-10-13.at.23.16.20.mp4

Android

Screen.Recording.2023-10-13.at.10.08.54.PM.mov

thesahindia

Sorry for the delay

melvin-bot · 2023-10-13T18:21:23Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #24910 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

neil-marcellini

I left some non blocking comments. It's looking good, thanks.

neil-marcellini · 2023-10-16T19:33:23Z

src/libs/ReportActionsUtils.ts

 *
- * @param {Object} reportAction report action
- * @returns {Boolean}
+ * @param reportAction report action


NAB: Why leave this JSDoc? It seems kind of useless.

neil-marcellini · 2023-10-16T19:36:19Z

src/libs/ReportActionsUtils.ts

+    }
+
+    if (message) {
+        return isReportMessageAttachment(message) ?? false;


NAB: I don't think we need ?? false if isReportMEssageAttachment returns a boolean already.

…b/ReportActionsUtils

kubabutkiewicz · 2023-10-17T07:19:13Z

@neil-marcellini Comments resolved can you check/approve again?

neil-marcellini · 2023-10-17T20:02:58Z

@kubabutkiewicz good to go but we have conflicts

…b/ReportActionsUtils

kubabutkiewicz · 2023-10-18T09:14:53Z

@neil-marcellini resolved 😄

OSBotify · 2023-10-18T18:09:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-19T00:32:49Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-19T00:58:30Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mountiny · 2023-10-19T14:19:47Z

src/libs/ReportActionsUtils.ts

+        // Then fallback on reportActionID as the final sorting criteria. It is a random number,
+        // but using this will ensure that the order of reportActions with the same created time and action type
+        // will be consistent across all users and devices
+        return (first.reportActionID < second.reportActionID ? -1 : 1) * invertedMultiplier;


Seems like this must be returning an object instead of an array 🤔 based on the stacktrace shared here #29965 (comment)

@mountiny it should be vice versa. This function should return an array. reportActions should be an array of reportAction objects

This return value affects only sort logic.
No doubt reportActions.filter(Boolean).sort always returns array.
So this function should not be related to the root cause of #29965

agreed with @situchan

Yep you are right, this should have gone to the getMostRecentIOURequestActionID method

OSBotify · 2023-10-20T21:07:34Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.87-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-20T21:40:03Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:52:15Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

jakub-trzebiatowski · 2024-02-05T10:26:07Z

src/types/onyx/OriginalMessage.ts

+
+type OriginalMessageReimbursementQueued = {
+    actionName: typeof CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENTQUEUED;
+    originalMessage: unknown;


@fabioh8010 Could you comment on this typing? Why is it unknown? Do we really not know the type?

At that time we didn't know the type (same as other types previously declared here), that's why we typed as unknown.

fabioh8010 added 4 commits September 26, 2023 22:30

Rename file to TS

ed6e2da

Merge branch 'main' into ts/lib/ReportActionsUtils

d159170

Convert file to TS

6731db8

Merge remote-tracking branch 'origin/main' into ts/lib/ReportActionsU…

8ad122f

…tils

kubabutkiewicz reviewed Oct 2, 2023

View reviewed changes

src/libs/actions/IOU.js Show resolved Hide resolved

gedu reviewed Oct 2, 2023

View reviewed changes

src/languages/types.ts Show resolved Hide resolved

rezkiy37 reviewed Oct 2, 2023

View reviewed changes

src/types/onyx/ReportAction.ts Show resolved Hide resolved

rezkiy37 reviewed Oct 2, 2023

View reviewed changes

fabioh8010 added 6 commits October 3, 2023 16:39

Merge branch 'main' into ts/lib/ReportActionsUtils

1b50456

Merge remote-tracking branch 'origin/main' into ts/lib/ReportActionsU…

484eefb

…tils

Use OnyxEntry when applicable

12ed819

Fix prettier

2d37dfd

Merge branch 'main' into ts/lib/ReportActionsUtils

8690c0a

Improve comment

22cfff6

rezkiy37 approved these changes Oct 4, 2023

View reviewed changes

blazejkustra suggested changes Oct 5, 2023

View reviewed changes

kubabutkiewicz added 4 commits October 9, 2023 08:55

Merge branch 'main' into ts/lib/ReportActionsUtils

0aec412

fix: resolve comments

258d0a8

fix: fixed import

e74d724

fix: resolve comment

5906975

blazejkustra approved these changes Oct 11, 2023

View reviewed changes

fabioh8010 marked this pull request as ready for review October 11, 2023 11:03

fabioh8010 requested a review from a team as a code owner October 11, 2023 11:03

melvin-bot bot requested review from thesahindia and removed request for a team October 11, 2023 11:03

Merge branch 'main' of github.com:fabioh8010/expensify-app into ts/li…

a55f1a4

…b/ReportActionsUtils

thesahindia approved these changes Oct 13, 2023

View reviewed changes

melvin-bot bot requested a review from neil-marcellini October 13, 2023 18:21

neil-marcellini previously approved these changes Oct 16, 2023

View reviewed changes

kubabutkiewicz added 2 commits October 17, 2023 09:13

Merge branch 'main' of github.com:fabioh8010/expensify-app into ts/li…

934a95e

…b/ReportActionsUtils

fix: resolved comments

60d97bb

kubabutkiewicz dismissed neil-marcellini’s stale review via 60d97bb October 17, 2023 07:18

neil-marcellini previously approved these changes Oct 17, 2023

View reviewed changes

Merge branch 'main' of github.com:fabioh8010/expensify-app into ts/li…

fabce75

…b/ReportActionsUtils

kubabutkiewicz dismissed neil-marcellini’s stale review via fabce75 October 18, 2023 07:41

neil-marcellini approved these changes Oct 18, 2023

View reviewed changes

neil-marcellini merged commit 3b86da6 into Expensify:main Oct 18, 2023

OSBotify mentioned this pull request Oct 18, 2023

Deploy Checklist: New Expensify 2023-10-18 #29926

Closed

64 tasks

mountiny reviewed Oct 19, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Oct 20, 2023

[HOLD for payment 2023-10-27] [TS migration] Migrate 'ReportActionsUtils.js' lib to TypeScript #24910

Closed

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

jakub-trzebiatowski reviewed Feb 5, 2024

View reviewed changes

	return reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && reportAction.originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.PAY && !!reportAction.originalMessage.IOUDetails;
	return reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && reportAction?.originalMessage?.type === CONST.IOU.REPORT_ACTION_TYPE.PAY && !!reportAction?.originalMessage?.IOUDetails;

Conversation

fabioh8010 commented Oct 1, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rezkiy37 left a comment

Choose a reason for hiding this comment

Uh oh!

fabioh8010 commented Oct 5, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz commented Oct 11, 2023

Uh oh!

melvin-bot bot commented Oct 11, 2023

Uh oh!

kubabutkiewicz commented Oct 11, 2023

Uh oh!

thesahindia commented Oct 12, 2023

Uh oh!

kubabutkiewicz commented Oct 13, 2023

Uh oh!

thesahindia commented Oct 13, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

thesahindia left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Oct 13, 2023

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kubabutkiewicz commented Oct 17, 2023

Uh oh!

neil-marcellini commented Oct 17, 2023

Uh oh!

kubabutkiewicz commented Oct 18, 2023

Uh oh!

OSBotify commented Oct 18, 2023

Uh oh!

OSBotify commented Oct 19, 2023

Uh oh!

OSBotify commented Oct 19, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment