Refactor how data is loaded into the edit request page#28645
Merged
Conversation
Contributor
Author
|
@pecanoro bump for review please |
pecanoro
reviewed
Oct 5, 2023
| }, | ||
| }), | ||
| // eslint-disable-next-line rulesdir/no-multiple-onyx-in-file | ||
| withOnyx({ |
Contributor
There was a problem hiding this comment.
Why not combining both withOnyx? I am reading this and I am not totally sure why they can't be combined.
Contributor
Author
There was a problem hiding this comment.
I'm glad you caught that! Basically, it can't be done until Expensify/react-native-onyx#385 is merged and implemented.
Contributor
There was a problem hiding this comment.
Gotcha! Thank you for clarifying!
pecanoro
approved these changes
Oct 6, 2023
Contributor
Reviewer Checklist
Screenshots/VideosWeb
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android
|
Contributor
|
Testing in all platforms before merging! |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
@pecanoro I'm getting an error when trying to access the report sub-page via deep link. Try accessing deeplink after logout (imp) |
b4s36t4
reviewed
Oct 9, 2023
| const parentReportAction = ReportActionsUtils.getParentReportAction(report); | ||
| const transaction = TransactionUtils.getLinkedTransaction(parentReportAction); | ||
| function EditRequestPage({betas, report, route, parentReport, policy, session, policyCategories, policyTags, parentReportActions, transaction}) { | ||
| const parentReportAction = parentReportActions[report.parentReportActionID]; |
Contributor
There was a problem hiding this comment.
Maybe we can use lodashGet function here to fetch parentReportAction.
Contributor
Author
There was a problem hiding this comment.
Yeah, we could. Ideally, this would be done in the withOnyx selector for the key parentReportActions. When I am able to remove the withOnyx nesting, I would like to:
- Remove this
const parentReportAction - Rename
parentReportActionsprop toparentReportAction - Update the
transactionprop to useparentReportAction
parentReportAction: {
key: ({report}) => `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report ? report.parentReportID : '0'}`,
selector: (parentReportActions, {report}) => {lodashGet(parentReportActions, [report.parentReportActionID])},
canEvict: false,
},
transaction: {
key: ({parentReportAction}) => `${ONYXKEYS.COLLECTION.TRANSACTION}${lodashGet(parentReportAction, 'originalMessage.IOUTransactionID', 0)}`,
},
This will be possible once Expensify/react-native-onyx#385 is merged.
6 tasks
64 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.80-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.80-3 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 1.3.81-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
2 similar comments
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.83-11 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
This PR removes two deprecated function calls and moves the data loading into
withOnyxFixed Issues
Part of #27262
Tests
Offline tests
Same
QA Steps
Same
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android