Add Browser Notifications for Web / Desktop #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@roryabraham bumping this one |
roryabraham
requested changes
Aug 27, 2020
Contributor
roryabraham
left a comment
roryabraham
left a comment
There was a problem hiding this comment.
Code looks great and it passed lots of testing too. Only change I'm requesting is that we save the Expensify Icon URL in CONST.js, because it could very conceivably be used elsewhere in the application.
| @@ -0,0 +1,126 @@ | |||
| // Web implementation only. Do not import for direct use. Use Notification. | |||
Contributor
There was a problem hiding this comment.
** Web and desktop, right?
| import CONST from '../../CONST'; | ||
| import * as ActiveClientManager from '../ActiveClientManager'; | ||
|
|
||
| const EXPENSIFY_ICON_URL = `${CONST.CLOUDFRONT_URL}/images/favicon-2019.png`; |
Contributor
There was a problem hiding this comment.
I think we should move this to CONST.js
Contributor
Author
There was a problem hiding this comment.
yeah we probably should I'll fix this up.
Contributor
Author
|
Updated! |
roryabraham
approved these changes
Aug 27, 2020
Contributor
roryabraham
left a comment
roryabraham
left a comment
There was a problem hiding this comment.
Great, this code seems to work really well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #285
Testing Steps: