Fix report action context menu stuck when open search page with keyboard shortcut by tsa321 · Pull Request #29152 · Expensify/App

tsa321 · 2023-10-10T05:47:20Z

Details

Fixed Issues

$ #27244
PROPOSAL: #27244 (comment)

Tests

For Macos chrome / Desktop:

Open any report
Click FAB button then right click report action then Open search page with cmd + k
Notice there is no popover/context menu being stuck and search page is opened
Click emoji picker -> right click reportaction -> cmd + k
Notice there is no popover/context menu being stuck and search page is opened
Right click context menu -> choose emoji picker inside context menu -> cmd + k
Notice there is no popover/context menu being stuck and search page is opened
Click Fab button -> right click on LHN -> cmd + k
Notice there is no popover/context menu being stuck and search page is opened
Click any button that trigger popover / context menu with other different combinations -> cmd + k
Notice there is no popover/context menu being stuck and search page is opened

For mobile:

Click emoji picker, fab button, long press report action and other actions to trigger popover or context menu
Verify the components functions properly when opening and closing the context menu.

Verify that no errors appear in the JS console

Offline tests

QA Steps

For Macos chrome / Desktop:

Open any report
Click FAB button then right click report action then Open search page with cmd + k
Notice there is no popover/context menu being stuck and search page is opened
Click emoji picker -> right click reportaction -> cmd + k
Notice there is no popover/context menu being stuck and search page is opened
Right click context menu -> choose emoji picker inside context menu -> cmd + k
Notice there is no popover/context menu being stuck and search page is opened
Click Fab button -> right click on LHN -> cmd + k
Notice there is no popover/context menu being stuck and search page is opened
Click any button that trigger popover / context menu with other different combinations -> cmd + k
Notice there is no popover/context menu being stuck and search page is opened

For mobile:

Click emoji picker, fab button, long press report action and other actions to trigger popover or context menu
Verify the components functions properly when opening and closing the context menu.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native_d.mp4

Android: mWeb Chrome

android-mweb_d.mp4

iOS: Native

ios-native_d.mp4

iOS: mWeb Safari

ios-msafari_d.mp4

MacOS: Chrome / Safari

macos-web_d.mp4

MacOS: Desktop

macos-dekstop_d.mp4

…ard shortcut Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

melvin-bot · 2023-10-10T05:47:25Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tsa321 · 2023-10-10T23:26:02Z

@mollfpr Could you review my pr when you have a chance? thank you...

tsa321 · 2023-10-13T06:25:25Z

@mollfpr Friendly bump...

mollfpr

Sorry for the late review @tsa321, I just got out from the hospital after surgery on my right because of the motorcycle accident on Wednesday 🙏

I left a comment but the test looks good.

mollfpr · 2023-10-15T14:58:59Z

src/components/PopoverProvider/index.js

        }
+
        activePopoverRef.current.close();
+        lodashGet(activePopoverRef, 'current.onCloseCallback', () => {})();


I understand you want to call the function after it returns from the lodashGet, but I found this harder to understand at first glance. Usually, people use lodashGet to assign the return to another variable instead of calling it immediately, so this will make us for a moment. Could we make it more explanatory instead of making it simple?

@mollfpr just to make sure for the easy to read code. Should we change the code into something like this?:

const closeCallback = lodashGet(activePopoverRef, 'current.onCloseCallback', () => {}) closeCallback();

Or should we use if clause instead? something like this:

if (activePopoverRef && activePopoverRef.current && activePopoverRef.current.onCloseCallback) { activePopoverRef.current.onCloseCallback(); }

Or do you have other options?

The if clause looks good to me!

mollfpr · 2023-10-15T14:59:08Z

src/components/PopoverProvider/index.js

                closePopover(activePopoverRef.current.anchorRef);
            }
            activePopoverRef.current = popoverParams;
+            lodashGet(activePopoverRef, 'current.onOpenCallback', () => {})();


Same as the above.

tsa321 · 2023-10-16T03:37:53Z

Sorry for the late review @tsa321, I just got out from the hospital after surgery on my right because of the motorcycle accident on Wednesday 🙏

I am sorry to hear that @mollfpr 🙏, I hope you get well soon and wishing you a speedy recovery.

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 · 2023-10-16T06:18:16Z

and @mollfpr I have checked the recent history of popoverWithoutOverly and the related PRs and I think this PR could solve the issue in:

#28241 and #29341

mollfpr · 2023-10-16T06:26:58Z

@tsa321 Have you try revert the mentioned PR here?

tsa321 · 2023-10-16T06:34:36Z

@mollfpr yes, I have reverted the two PRs.

mollfpr · 2023-10-16T06:37:54Z

Thanks @tsa321! Could you cross-post it in #29341 and get their thoughts about this PR?

parasharrajat · 2023-10-16T09:36:21Z

IF this issue is related to same root cause as #29341. Please hold this PR.

tsa321 · 2023-10-16T10:28:14Z

@parasharrajat This is different root cause with #29341
The issue I am fixing here is dated 12 september, more than 1 month ago.

What I am saying is my PR could also solve #28241 (the attachment refresh navigation issue, I have tested it by reverting the PR that solve the issue and executing my PR) So I found a solution for my issue that I am trying to solve here and the other issue #28241 (the attachment navigation issue)

Can we move forward?
Thank you...

tsa321 · 2023-10-16T11:29:47Z

@mollfpr Could we move forward? It is different root cause...

tsa321 · 2023-10-16T16:46:16Z

cc @mollfpr: parasharrajat replies from other issue: #28241 (comment)

mollfpr · 2023-10-17T04:16:25Z

@tsa321 Let's wait for the revert, and we can move forward with this.

mollfpr · 2023-10-17T04:54:23Z

@tsa321 Could you add [HOLD] to the PR title? Thanks!

tsa321 · 2023-10-18T21:43:13Z

@mollfpr The revert has been merged, let's continue this PR. Thank you...

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

mollfpr · 2023-10-19T14:58:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

29152.Web.mp4

Mobile Web - Chrome

29152.mWeb-Chrome.mp4

Mobile Web - Safari

29152.mWeb-Safari.mp4

Desktop

29152.Desktop.mp4

iOS

29152.iOS.mp4

Android

29152.Android.mp4

mollfpr

LGTM and tests well 👍

All yours @cead22

cead22 · 2023-10-19T15:37:47Z

src/components/PopoverProvider/index.js

        }
+
        activePopoverRef.current.close();
+        if (activePopoverRef && activePopoverRef.current && activePopoverRef.current.onCloseCallback) {


I don't think we need activePopoverRef && activePopoverRef.current && since above we're calling activePopoverRef.current.close();

Suggested change

if (activePopoverRef && activePopoverRef.current && activePopoverRef.current.onCloseCallback) {

if (activePopoverRef.current.onCloseCallback) {

@cead22 done

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

cead22

Thanks for testing several different popup conbinations!

OSBotify · 2023-10-19T18:04:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-20T21:38:30Z

🚀 Deployed to staging by https://github.com/cead22 in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:50:42Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Fix report action context menu stuck when open search page with keybo…

c58c53e

…ard shortcut Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 requested a review from a team as a code owner October 10, 2023 05:47

melvin-bot bot requested review from mollfpr and removed request for a team October 10, 2023 05:47

mollfpr requested changes Oct 15, 2023

View reviewed changes

Using if clause instead of lodaashGet

2245a7e

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 mentioned this pull request Oct 16, 2023

[HOLD for payment 2023-10-25] [$500] Fab - App disables CTRL+K / CTRL+SHIFT+K shortcuts on FAB menu option pages #29341

Closed

6 tasks

tsa321 requested a review from mollfpr October 16, 2023 11:20

tsa321 mentioned this pull request Oct 16, 2023

[$500] Web - Navigation breaks on opening attachment, reload and opening search by shortcut #28241

Closed

6 tasks

tsa321 changed the title ~~Fix report action context menu stuck when open search page with keyboard shortcut~~ [HLD] Fix report action context menu stuck when open search page with keyboard shortcut Oct 17, 2023

tsa321 changed the title ~~[HLD] Fix report action context menu stuck when open search page with keyboard shortcut~~ [HOLD] Fix report action context menu stuck when open search page with keyboard shortcut Oct 17, 2023

tsa321 mentioned this pull request Oct 17, 2023

Revert "Fix navigation breaks on opening search page after reloading the attachment" #29784

Merged

59 tasks

tsa321 changed the title ~~[HOLD] Fix report action context menu stuck when open search page with keyboard shortcut~~ Fix report action context menu stuck when open search page with keyboard shortcut Oct 18, 2023

merge main and resolve conflict

769f01e

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

mollfpr approved these changes Oct 19, 2023

View reviewed changes

cead22 requested changes Oct 19, 2023

View reviewed changes

modify if conditionn before calling onCloseCallback

e7da926

Signed-off-by: Tsaqif <tsaiinkwa@yahoo.com>

tsa321 requested a review from cead22 October 19, 2023 16:02

cead22 approved these changes Oct 19, 2023

View reviewed changes

cead22 merged commit 20cd522 into Expensify:main Oct 19, 2023

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

melvin-bot bot mentioned this pull request Oct 23, 2023

[HOLD for payment 2023-10-30] [$500] Web - Right click popup is stuck on search page open #27244

Closed

6 tasks

Pujan92 mentioned this pull request Dec 11, 2023

[PAID] [LOW] [$500] Web - Chat - Console error shows up when opening emoji picker and then clicking on send button #32743

Closed

6 tasks

	if (activePopoverRef && activePopoverRef.current && activePopoverRef.current.onCloseCallback) {
	if (activePopoverRef.current.onCloseCallback) {

Conversation

tsa321 commented Oct 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 10, 2023

Uh oh!

tsa321 commented Oct 10, 2023

Uh oh!

tsa321 commented Oct 13, 2023

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

mollfpr Oct 15, 2023

Choose a reason for hiding this comment

Uh oh!

tsa321 Oct 16, 2023

Choose a reason for hiding this comment

Uh oh!

mollfpr Oct 16, 2023

Choose a reason for hiding this comment

Uh oh!

mollfpr Oct 15, 2023

Choose a reason for hiding this comment

Uh oh!

tsa321 commented Oct 16, 2023

Uh oh!

tsa321 commented Oct 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr commented Oct 16, 2023

Uh oh!

tsa321 commented Oct 16, 2023

Uh oh!

mollfpr commented Oct 16, 2023

Uh oh!

parasharrajat commented Oct 16, 2023

Uh oh!

tsa321 commented Oct 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsa321 commented Oct 16, 2023

Uh oh!

tsa321 commented Oct 16, 2023

Uh oh!

mollfpr commented Oct 17, 2023

Uh oh!

mollfpr commented Oct 17, 2023

Uh oh!

tsa321 commented Oct 18, 2023

Uh oh!

mollfpr commented Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

cead22 Oct 19, 2023

Choose a reason for hiding this comment

Uh oh!

tsa321 Oct 19, 2023

Choose a reason for hiding this comment

Uh oh!

cead22 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 19, 2023

Uh oh!

OSBotify commented Oct 20, 2023

Uh oh!

OSBotify commented Oct 23, 2023

tsa321 commented Oct 10, 2023 •

edited

Loading

tsa321 commented Oct 16, 2023 •

edited

Loading

tsa321 commented Oct 16, 2023 •

edited

Loading

mollfpr commented Oct 19, 2023 •

edited

Loading