Update LHN/chat header to handle displayName not being set - MR participants list fix by lukemorawski · Pull Request #30342 · Expensify/App

lukemorawski · 2023-10-25T14:12:56Z

Details

This PR addresses the issue with creating a distance money request described here.

Fixed Issues

$ #27393
PROPOSAL: No proposal

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app (prefferably in a web browser)
Open dev tools and take a look in to the IndexedDB (Application tab in Chrome Dev Tools)
In personalDetailsList key, find the object that represents personal details of a contact you want to make hidden
In the dev console punch in the following command:

Onyx.merge('personalDetailsList', {<account id you want to change>: {accountID: <account id you want to change>, avatar: "https://d2k5nsl2zxldvw.cloudfront.net/images/avatars/default-avatar_24.png", displayName: "", firstName: "", lastName: "", login: "", phoneNumber: "", validated: true}})

Observe the LHN and look for "Hidden" instead of the name of the contact
Open the chat with that contact
Put the above command in the console again (Onyx probably overwrote the data with real ones by now)
Observe the header changing name to Hidden
Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-10-25T14:13:02Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

puneetlath · 2023-10-26T13:30:18Z

@mananjadhav will you be able to review/test this today?

allroundexperts · 2023-10-26T16:25:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2023-10-31.at.9.12.47.AM.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2023-10-31.at.9.11.03.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-10-31.at.9.01.28.AM.mov

MacOS: Desktop

Screen.Recording.2023-10-31.at.9.08.22.AM.mov

allroundexperts · 2023-10-26T18:19:49Z

@lukemorawski Instead of showing Hidden, the name does not show at all.

puneetlath · 2023-10-27T13:49:14Z

@lukemorawski will you be able to address that today?

lukemorawski · 2023-10-27T13:57:31Z

@puneetlath yep, I think so

lukemorawski · 2023-10-27T14:17:39Z

@allroundexperts I cannot reproduce that. Everything works good. Can you provide steps for reproduction?

lukemorawski · 2023-10-27T14:39:30Z

@allroundexperts @puneetlath in effort to reproduce the issue I have found two other places where "Hidden" was not showing up. It's the report welcome message and report action item header.

lukemorawski · 2023-10-27T15:03:47Z

yep, I have even checked out this PR directly and everything seems to run as it should be

lukemorawski · 2023-10-27T15:05:07Z

Also there this odd lint error, though I'm running both npm run prettier and npm run lint locally and nothing happens. Anyone has any idea how to get rid of it?

puneetlath · 2023-10-27T15:15:18Z

I think it's unrelated to this PR and you should be able to fix it by merging main (soon).

allroundexperts · 2023-10-27T15:57:39Z

@allroundexperts I cannot reproduce that. Everything works good. Can you provide steps for reproduction?

@lukemorawski I'm following the exact steps mentioned in OP.

lukemorawski · 2023-10-30T10:27:12Z

@allroundexperts Really don't know what's going on. Looking at the screenshot you took it looks like there have been no changes to the code and thus there's no logic present responsible for the "Hidden" fallback.
Maybe it's a git issue?

hidden.fallback.mov

allroundexperts · 2023-10-30T10:39:42Z

I can take a look again. No problem

puneetlath · 2023-10-30T19:39:23Z

@allroundexperts did you get a chance to re-test?

allroundexperts · 2023-10-31T04:18:18Z

@puneetlath Just finished.

@lukemorawski It's testing well now. One thing I'm not sure about is that on tooltips, we're just showing the icon and not the text Hidden.

Also, lint is failing. If you can please fix that.

lukemorawski · 2023-10-31T10:14:01Z

@allroundexperts cool, will fix that today

lukemorawski · 2023-10-31T14:24:46Z

@allroundexperts Fixed

allroundexperts

Looks good to me. @puneetlath I wasn't able to test on Android and iOS native because I'm having some issues with my setup. I think the changes aren't related to a specific platform so we should be fine here. Let me know if you'd disagree.

puneetlath · 2023-11-01T15:46:37Z

I'm comfortable with it for this PR. Going to go ahead and merge.

OSBotify · 2023-11-02T10:37:56Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.95-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dangrous · 2023-11-03T15:01:48Z

Hi all! Looks like this caused this regression - #30846 - with this particular line causing the trouble:

https://github.com/Expensify/App/pull/30342/files#diff-c7cedf6bd1e6af4654c7eb3d6ab6179f7a2ee5eb1c483a78d491674472cfeb4fR111

We can fix this by changing that line to:

    const primaryDisplayName = isWorkspaceActor ? displayName : ReportUtils.getDisplayNameForParticipant(actorAccountID);

But as there's a bunch going on in the PR, I'd love to get some testing (or an alternate fix) from y'all to make sure that's the best idea and doesn't introduce anything new. Thank you!

dummy-1111 · 2023-11-03T15:09:16Z

@lukemorawski

This PR also ignores the delegate details implemented in #22848
Please let me now if this is intentional

puneetlath · 2023-11-03T16:37:06Z

@s-alves10 I don't think that's intentional. I think we just missed that scenario.

lukemorawski · 2023-11-03T16:37:33Z

@s-alves10 I don't it was intentional. If you take a look a the diff for src/pages/home/report/ReportActionItemSingle.js you'll see that this PR doesn't change that part of the code that was implemented in #22848

dummy-1111 · 2023-11-03T16:40:30Z

@lukemorawski

If so, const primaryDisplayName = displayName would be fine. What do you think?

lukemorawski · 2023-11-03T16:43:32Z

@dangrous @s-alves10 yep, I guess so as it's conditionally reassigned on line 96. Sorry, my bad!

OSBotify · 2023-11-06T22:07:59Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-06T22:35:19Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.3.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-09T22:52:52Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

luacmartins · 2023-11-23T20:42:40Z

FYI I think this PR introduced this regression #31792. We filter the participant list here so the participant list is empty when we start a split bill request from a group chat with anonymous users.

ntdiary · 2023-12-29T12:48:12Z

src/components/UserDetailsTooltip/BaseUserDetailsTooltip.web.js


    const userDetails = lodashGet(props.personalDetailsList, props.accountID, props.fallbackUserDetails);
-    let userDisplayName = userDetails.displayName ? userDetails.displayName.trim() : '';
+    let userDisplayName = ReportUtils.getDisplayNameForParticipant(props.accountID);


Coming from #31720.
For a user that has never been chatted with, getDisplayNameForParticipant might return an empty string, causing the tooltip not to display.

money request participants list fix

a84a14a

lukemorawski requested a review from a team as a code owner October 25, 2023 14:12

melvin-bot bot requested review from mananjadhav and removed request for a team October 25, 2023 14:13

lukemorawski and others added 3 commits October 25, 2023 17:16

Merge branch 'main' into 27393-displayName_fallback_to_hidden

bbf20ab

display name fallback to hidden

011f8c2

Merge branch 'Expensify:main' into 27393-displayName_fallback_to_hidden

3f7fc03

lukemorawski added 2 commits October 27, 2023 17:36

fallback to hidden for report action item header

a5fd715

fallback to hidden for report welcome text

aa9637a

lukemorawski and others added 3 commits October 31, 2023 14:35

tooltip user name fallback to hidden

54dfef5

Merge branch 'main' into 27393-displayName_fallback_to_hidden

03edf32

prettier

47dede3

puneetlath approved these changes Oct 31, 2023

View reviewed changes

allroundexperts approved these changes Nov 1, 2023

View reviewed changes

melvin-bot bot requested a review from puneetlath November 1, 2023 01:44

puneetlath approved these changes Nov 1, 2023

View reviewed changes

puneetlath merged commit b9e202d into Expensify:main Nov 1, 2023

OSBotify mentioned this pull request Nov 2, 2023

Deploy Checklist: New Expensify 2023-11-02 #30752

Closed

dummy-1111 mentioned this pull request Nov 3, 2023

[HOLD for payment 2023-11-13] Expense - Workspace avatar and name change after creating a workspace expense #30846

Closed

6 tasks

dangrous mentioned this pull request Nov 3, 2023

Show displayName in IOU if the primary actor is a workspace #30862

Merged

59 tasks

melvin-bot bot mentioned this pull request Nov 6, 2023

[HOLD for payment 2023-11-13] [HOLD for payment 2023-10-30] [$500] Update LHN/chat header to handle displayName not being set #27393

Closed

OSBotify mentioned this pull request Nov 6, 2023

Deploy Checklist: New Expensify 2023-11-06 #30929

Closed

bernhardoj mentioned this pull request Nov 22, 2023

[Payment Due 2023-12-21][$500] Web – Chat – Tooltip is out if hover the cursor on the mentioned user you have no conversation #31720

Closed

6 tasks

luacmartins mentioned this pull request Nov 23, 2023

[HOLD for payment 2023-12-12] [$500] IOU - Unable to create IOU with "Hidden" users #31792

Closed

6 tasks

aldo-expensify mentioned this pull request Nov 24, 2023

[LOW] [Splits] Web - Request Money Action Item changes to $0.00 when requesting money from an account that is not on Expensify. #23038

Closed

6 tasks

ntdiary reviewed Dec 29, 2023

View reviewed changes

Conversation

lukemorawski commented Oct 25, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 25, 2023

Uh oh!

puneetlath commented Oct 26, 2023

Uh oh!

allroundexperts commented Oct 26, 2023 • edited by puneetlath Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Oct 26, 2023

Uh oh!

puneetlath commented Oct 27, 2023

Uh oh!

lukemorawski commented Oct 27, 2023

Uh oh!

lukemorawski commented Oct 27, 2023

Uh oh!

lukemorawski commented Oct 27, 2023

Uh oh!

lukemorawski commented Oct 27, 2023

Uh oh!

lukemorawski commented Oct 27, 2023

Uh oh!

puneetlath commented Oct 27, 2023

Uh oh!

allroundexperts commented Oct 27, 2023

Uh oh!

lukemorawski commented Oct 30, 2023

Uh oh!

allroundexperts commented Oct 30, 2023

Uh oh!

puneetlath commented Oct 30, 2023

Uh oh!

allroundexperts commented Oct 31, 2023

Uh oh!

lukemorawski commented Oct 31, 2023

Uh oh!

lukemorawski commented Oct 31, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

puneetlath commented Nov 1, 2023

Uh oh!

OSBotify commented Nov 2, 2023

Uh oh!

dangrous commented Nov 3, 2023

Uh oh!

dummy-1111 commented Nov 3, 2023

Uh oh!

puneetlath commented Nov 3, 2023

Uh oh!

lukemorawski commented Nov 3, 2023

Uh oh!

dummy-1111 commented Nov 3, 2023

Uh oh!

lukemorawski commented Nov 3, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

OSBotify commented Nov 6, 2023

Uh oh!

OSBotify commented Nov 9, 2023

Uh oh!

luacmartins commented Nov 23, 2023

Uh oh!

ntdiary Dec 29, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

allroundexperts commented Oct 26, 2023 •

edited by puneetlath

Loading