[Bank Account Flow Refactor] Update the Bank account flow design#31456
Closed
[Bank Account Flow Refactor] Update the Bank account flow design#31456
Conversation
…ify/App into michal/personal-info-page
…into michal/personal-info-page
https://github.com/gedu/App into michal/personal-info-page
…into michal/personal-info-page
…tive_sub_step_header
…ify/App into michal/personal-info-page
useSubStep hook
…ify/App into michal/personal-info-page
…s-migration Refactor/conect bank account ts migration
…eForReimbursementAccountField-usage Refactor/remove get default value for reimbursement account field usage
fix: move to the last step when editing data
Contributor
|
Test back button in editing mode:
Expected result: user. should be redirected to the step's summary 34408_ios.mov |
mountiny
commented
Jan 12, 2024
|
|
||
| interactiveStepHeaderLockedStepLine: { | ||
| backgroundColor: colors.productDark400, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| }, | |
| }, | |
| padding: 20, | ||
| width: 'auto', | ||
| textAlign: 'left', | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Can you keep the same spacing in this file as in the rest of it? thanks!
Suggested change
| }, | |
| }, | |
50 tasks
Use new vbba 111 commands and swap order of company step and requestor steps
Contributor
Author
|
This is all handled here #34498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @gedu @MrMuzyk @Swor71
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop