Use new vbba 111 commands and swap order of company step and requestor steps#33838
Merged
mountiny merged 1 commit intovit-tieredBankAccountFlowfrom Jan 16, 2024
Merged
Use new vbba 111 commands and swap order of company step and requestor steps#33838mountiny merged 1 commit intovit-tieredBankAccountFlowfrom
mountiny merged 1 commit intovit-tieredBankAccountFlowfrom
Conversation
9f4dad5 to
ff47eb8
Compare
e7955ce to
03e4b05
Compare
Contributor
Author
Contributor
Author
|
Things I noticed that can be tackled in a follow up PR:
|
Contributor
Author
Contributor
Author
262fb57 to
9b7d412
Compare
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
|
@nkuoch Can you change the target branch to https://github.com/barttom/App-expensify/tree/vit-tieredBankAccountFlow? |
Contributor
Author
Contributor
|
@mountiny Do I need to review this now or in the final PR? |
Contributor
|
@shubham1206agra lets just merge and then let @barttom sync with the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



































Fixed Issues
Part of #30442
$ #31357
Attach vbba logic to new 1:1:1 backend with new ordering + some refactoring and bug fixes.
Tests
See comments below. More tests and review will be made in the parent PR.
#33838 (comment)